[INFO] updating cached repository rsumner31/badtouch2 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rsumner31/badtouch2 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rsumner31/badtouch2" "work/ex/clippy-test-run/sources/stable/gh/rsumner31/badtouch2"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rsumner31/badtouch2'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rsumner31/badtouch2" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rsumner31/badtouch2"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rsumner31/badtouch2'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d667f9fd8c2070db3fd8a7c74e720b43903a15b0 [INFO] sha for GitHub repo rsumner31/badtouch2: d667f9fd8c2070db3fd8a7c74e720b43903a15b0 [INFO] validating manifest of rsumner31/badtouch2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rsumner31/badtouch2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rsumner31/badtouch2 [INFO] finished frobbing rsumner31/badtouch2 [INFO] frobbed toml for rsumner31/badtouch2 written to work/ex/clippy-test-run/sources/stable/gh/rsumner31/badtouch2/Cargo.toml [INFO] started frobbing rsumner31/badtouch2 [INFO] finished frobbing rsumner31/badtouch2 [INFO] frobbed toml for rsumner31/badtouch2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rsumner31/badtouch2/Cargo.toml [INFO] crate rsumner31/badtouch2 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rsumner31/badtouch2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rsumner31/badtouch2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 065c3bb43f73925ac9c96000553eda1e77635282b85fc0ffa2f634c957ee92a2 [INFO] running `"docker" "start" "-a" "065c3bb43f73925ac9c96000553eda1e77635282b85fc0ffa2f634c957ee92a2"` [INFO] [stderr] Checking colored v1.6.0 [INFO] [stderr] Compiling openssl-sys v0.9.27 [INFO] [stderr] Checking atoi v0.2.3 [INFO] [stderr] Checking nix v0.9.0 [INFO] [stderr] Compiling lua52-sys v0.1.1 [INFO] [stderr] Checking serde_json v1.0.11 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking thread_local v0.3.5 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking twox-hash v1.1.0 [INFO] [stderr] Checking regex v0.2.9 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Compiling structopt-derive v0.2.5 [INFO] [stderr] Checking pbr v1.0.0 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking mysql_common v0.5.0 [INFO] [stderr] Checking structopt v0.2.5 [INFO] [stderr] Checking hlua v0.4.1 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking mysql v12.2.0 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Checking badtouch v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | #[macro_use] extern crate structopt; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | #[macro_use] extern crate structopt; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ctx.rs:29:53 [INFO] [stderr] | [INFO] [stderr] 29 | let descr: Result<_> = lua.get("descr").ok_or("descr undefined".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "descr undefined".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ctx.rs:35:55 [INFO] [stderr] | [INFO] [stderr] 35 | let verify: Result<_> = lua.get("verify").ok_or("verify undefined".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "verify undefined".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ctx.rs:72:51 [INFO] [stderr] | [INFO] [stderr] 72 | let verify: Result<_> = lua.get("verify").ok_or("verify undefined".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "verify undefined".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:92:40 [INFO] [stderr] | [INFO] [stderr] 92 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 93 | | descr = "verify_false" [INFO] [stderr] 94 | | [INFO] [stderr] 95 | | function verify(user, password) [INFO] [stderr] 96 | | return false [INFO] [stderr] 97 | | end [INFO] [stderr] 98 | | "#.as_bytes()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 92 | let script = Script::load_from(br#" [INFO] [stderr] 93 | descr = "verify_false" [INFO] [stderr] 94 | [INFO] [stderr] 95 | function verify(user, password) [INFO] [stderr] 96 | return false [INFO] [stderr] 97 | end [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:106:40 [INFO] [stderr] | [INFO] [stderr] 106 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 107 | | descr = "verify_false" [INFO] [stderr] 108 | | [INFO] [stderr] 109 | | function verify(user, password) [INFO] [stderr] 110 | | return true [INFO] [stderr] 111 | | end [INFO] [stderr] 112 | | "#.as_bytes()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 106 | let script = Script::load_from(br#" [INFO] [stderr] 107 | descr = "verify_false" [INFO] [stderr] 108 | [INFO] [stderr] 109 | function verify(user, password) [INFO] [stderr] 110 | return true [INFO] [stderr] 111 | end [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:120:40 [INFO] [stderr] | [INFO] [stderr] 120 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 121 | | descr = "slow script" [INFO] [stderr] 122 | | [INFO] [stderr] 123 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 126 | | end [INFO] [stderr] 127 | | "#.as_bytes()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 120 | let script = Script::load_from(br#" [INFO] [stderr] 121 | descr = "slow script" [INFO] [stderr] 122 | [INFO] [stderr] 123 | function verify(user, password) [INFO] [stderr] 124 | sleep(1) [INFO] [stderr] 125 | return true [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:135:40 [INFO] [stderr] | [INFO] [stderr] 135 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 136 | | descr = "basic auth httpbin.org" [INFO] [stderr] 137 | | [INFO] [stderr] 138 | | function verify(user, password) [INFO] [stderr] 139 | | return http_basic_auth("https://httpbin.org/basic-auth/foo/buzz", user, password) [INFO] [stderr] 140 | | end [INFO] [stderr] 141 | | "#.as_bytes()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 135 | let script = Script::load_from(br#" [INFO] [stderr] 136 | descr = "basic auth httpbin.org" [INFO] [stderr] 137 | [INFO] [stderr] 138 | function verify(user, password) [INFO] [stderr] 139 | return http_basic_auth("https://httpbin.org/basic-auth/foo/buzz", user, password) [INFO] [stderr] 140 | end [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:149:40 [INFO] [stderr] | [INFO] [stderr] 149 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 150 | | descr = "basic auth httpbin.org" [INFO] [stderr] 151 | | [INFO] [stderr] 152 | | function verify(user, password) [INFO] [stderr] 153 | | return http_basic_auth("https://httpbin.org/basic-auth/foo/buzz", user, password) [INFO] [stderr] 154 | | end [INFO] [stderr] 155 | | "#.as_bytes()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 149 | let script = Script::load_from(br#" [INFO] [stderr] 150 | descr = "basic auth httpbin.org" [INFO] [stderr] 151 | [INFO] [stderr] 152 | function verify(user, password) [INFO] [stderr] 153 | return http_basic_auth("https://httpbin.org/basic-auth/foo/buzz", user, password) [INFO] [stderr] 154 | end [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:48:28 [INFO] [stderr] | [INFO] [stderr] 48 | .map(|x| x.map(|x| Arc::new(x))) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `Arc::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ctx.rs:29:53 [INFO] [stderr] | [INFO] [stderr] 29 | let descr: Result<_> = lua.get("descr").ok_or("descr undefined".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "descr undefined".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ctx.rs:35:55 [INFO] [stderr] | [INFO] [stderr] 35 | let verify: Result<_> = lua.get("verify").ok_or("verify undefined".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "verify undefined".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ctx.rs:72:51 [INFO] [stderr] | [INFO] [stderr] 72 | let verify: Result<_> = lua.get("verify").ok_or("verify undefined".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "verify undefined".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:48:28 [INFO] [stderr] | [INFO] [stderr] 48 | .map(|x| x.map(|x| Arc::new(x))) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `Arc::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 34.10s [INFO] running `"docker" "inspect" "065c3bb43f73925ac9c96000553eda1e77635282b85fc0ffa2f634c957ee92a2"` [INFO] running `"docker" "rm" "-f" "065c3bb43f73925ac9c96000553eda1e77635282b85fc0ffa2f634c957ee92a2"` [INFO] [stdout] 065c3bb43f73925ac9c96000553eda1e77635282b85fc0ffa2f634c957ee92a2