[INFO] updating cached repository rroe/SR_ReverseProxy [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rroe/SR_ReverseProxy [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rroe/SR_ReverseProxy" "work/ex/clippy-test-run/sources/stable/gh/rroe/SR_ReverseProxy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rroe/SR_ReverseProxy'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rroe/SR_ReverseProxy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rroe/SR_ReverseProxy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rroe/SR_ReverseProxy'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] aa94e1df93d835a947179ce1d2142a506997d5eb [INFO] sha for GitHub repo rroe/SR_ReverseProxy: aa94e1df93d835a947179ce1d2142a506997d5eb [INFO] validating manifest of rroe/SR_ReverseProxy on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rroe/SR_ReverseProxy on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rroe/SR_ReverseProxy [INFO] finished frobbing rroe/SR_ReverseProxy [INFO] frobbed toml for rroe/SR_ReverseProxy written to work/ex/clippy-test-run/sources/stable/gh/rroe/SR_ReverseProxy/Cargo.toml [INFO] started frobbing rroe/SR_ReverseProxy [INFO] finished frobbing rroe/SR_ReverseProxy [INFO] frobbed toml for rroe/SR_ReverseProxy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rroe/SR_ReverseProxy/Cargo.toml [INFO] crate rroe/SR_ReverseProxy has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rroe/SR_ReverseProxy against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rroe/SR_ReverseProxy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4c8e3d5fdbc149de9732b3a94ae4d7ed7926053a9f27459db5912fd76f3f41d7 [INFO] running `"docker" "start" "-a" "4c8e3d5fdbc149de9732b3a94ae4d7ed7926053a9f27459db5912fd76f3f41d7"` [INFO] [stderr] Checking reverseproxy v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `rand::Rng` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use rand::Rng; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Shutdown`, `TcpStream` [INFO] [stderr] --> src/main.rs:5:29 [INFO] [stderr] | [INFO] [stderr] 5 | use std::net::{TcpListener, TcpStream, Shutdown}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `TcpListener` [INFO] [stderr] --> src/proxy/localproxy.rs:4:16 [INFO] [stderr] | [INFO] [stderr] 4 | use std::net::{TcpListener, TcpStream, Shutdown}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `rand::Rng` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use rand::Rng; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Shutdown`, `TcpStream` [INFO] [stderr] --> src/main.rs:5:29 [INFO] [stderr] | [INFO] [stderr] 5 | use std::net::{TcpListener, TcpStream, Shutdown}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `TcpListener` [INFO] [stderr] --> src/proxy/localproxy.rs:4:16 [INFO] [stderr] | [INFO] [stderr] 4 | use std::net::{TcpListener, TcpStream, Shutdown}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/proxy/localproxy.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | m [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `m` [INFO] [stderr] --> src/proxy/localproxy.rs:109:16 [INFO] [stderr] | [INFO] [stderr] 109 | Ok(m) => { [INFO] [stderr] | ^ help: consider using `_m` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/main.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | for y in 0..x { [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `vec_end_in_nl` [INFO] [stderr] --> src/proxy/buffer.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn vec_end_in_nl(input: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `print_chunk` [INFO] [stderr] --> src/main.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | fn print_chunk(title: &str, string: &String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/proxy/buffer.rs:1:29 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn vec_end_in_nl(input: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/proxy/buffer.rs:14:32 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn chunk_end_in_nl(string: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `last_four`. [INFO] [stderr] --> src/proxy/buffer.rs:16:14 [INFO] [stderr] | [INFO] [stderr] 16 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 16 | for in last_four.iter().take(4) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/proxy/localproxy.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / let _ = match stream.set_read_timeout(Option::Some(timeout_time)) { [INFO] [stderr] 22 | | Err(e) => panic!("[ERROR] setting timeout: {}", e), [INFO] [stderr] 23 | | Ok(m) => m [INFO] [stderr] 24 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/proxy/localproxy.rs:28:2 [INFO] [stderr] | [INFO] [stderr] 28 | 'outer: loop { [INFO] [stderr] | _____^ [INFO] [stderr] 29 | | 'inner: loop { [INFO] [stderr] 30 | | let mut buf_tmp = [0; 1024]; [INFO] [stderr] 31 | | let _ = match stream.read(&mut buf_tmp) { [INFO] [stderr] ... | [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/proxy/localproxy.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | / loop { [INFO] [stderr] 103 | | let mut buf = [0; 32768]; [INFO] [stderr] 104 | | let _ = match socket.read(&mut buf) { [INFO] [stderr] 105 | | Err(e) => { [INFO] [stderr] ... | [INFO] [stderr] 116 | | }; [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:9:37 [INFO] [stderr] | [INFO] [stderr] 9 | fn print_chunk(title: &str, string: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/proxy/localproxy.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | m [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `m` [INFO] [stderr] --> src/proxy/localproxy.rs:109:16 [INFO] [stderr] | [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] 109 | Ok(m) => { [INFO] [stderr] | ^ help: consider using `_m` instead [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/main.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | for y in 0..x { [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] error: Could not compile `reverseproxy`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: function is never used: `vec_end_in_nl` [INFO] [stderr] --> src/proxy/buffer.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn vec_end_in_nl(input: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `print_chunk` [INFO] [stderr] --> src/main.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | fn print_chunk(title: &str, string: &String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/proxy/buffer.rs:1:29 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn vec_end_in_nl(input: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/proxy/buffer.rs:14:32 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn chunk_end_in_nl(string: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `last_four`. [INFO] [stderr] --> src/proxy/buffer.rs:16:14 [INFO] [stderr] | [INFO] [stderr] 16 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 16 | for in last_four.iter().take(4) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/proxy/localproxy.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / let _ = match stream.set_read_timeout(Option::Some(timeout_time)) { [INFO] [stderr] 22 | | Err(e) => panic!("[ERROR] setting timeout: {}", e), [INFO] [stderr] 23 | | Ok(m) => m [INFO] [stderr] 24 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/proxy/localproxy.rs:28:2 [INFO] [stderr] | [INFO] [stderr] 28 | 'outer: loop { [INFO] [stderr] | _____^ [INFO] [stderr] 29 | | 'inner: loop { [INFO] [stderr] 30 | | let mut buf_tmp = [0; 1024]; [INFO] [stderr] 31 | | let _ = match stream.read(&mut buf_tmp) { [INFO] [stderr] ... | [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/proxy/localproxy.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | / loop { [INFO] [stderr] 103 | | let mut buf = [0; 32768]; [INFO] [stderr] 104 | | let _ = match socket.read(&mut buf) { [INFO] [stderr] 105 | | Err(e) => { [INFO] [stderr] ... | [INFO] [stderr] 116 | | }; [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:9:37 [INFO] [stderr] | [INFO] [stderr] 9 | fn print_chunk(title: &str, string: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `reverseproxy`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4c8e3d5fdbc149de9732b3a94ae4d7ed7926053a9f27459db5912fd76f3f41d7"` [INFO] running `"docker" "rm" "-f" "4c8e3d5fdbc149de9732b3a94ae4d7ed7926053a9f27459db5912fd76f3f41d7"` [INFO] [stdout] 4c8e3d5fdbc149de9732b3a94ae4d7ed7926053a9f27459db5912fd76f3f41d7