[INFO] updating cached repository rphmeier/shamir_sharing
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/rphmeier/shamir_sharing
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/rphmeier/shamir_sharing" "work/ex/clippy-test-run/sources/stable/gh/rphmeier/shamir_sharing"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rphmeier/shamir_sharing'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/rphmeier/shamir_sharing" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rphmeier/shamir_sharing"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rphmeier/shamir_sharing'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5714c399123ef015c225df1a978b36326addc937
[INFO] sha for GitHub repo rphmeier/shamir_sharing: 5714c399123ef015c225df1a978b36326addc937
[INFO] validating manifest of rphmeier/shamir_sharing on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rphmeier/shamir_sharing on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rphmeier/shamir_sharing
[INFO] finished frobbing rphmeier/shamir_sharing
[INFO] frobbed toml for rphmeier/shamir_sharing written to work/ex/clippy-test-run/sources/stable/gh/rphmeier/shamir_sharing/Cargo.toml
[INFO] started frobbing rphmeier/shamir_sharing
[INFO] finished frobbing rphmeier/shamir_sharing
[INFO] frobbed toml for rphmeier/shamir_sharing written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rphmeier/shamir_sharing/Cargo.toml
[INFO] crate rphmeier/shamir_sharing has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rphmeier/shamir_sharing against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rphmeier/shamir_sharing:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] fcf4934873621ad4de1274cee43759e8ce29a2b47dabdf181e66ca6dca8d755d
[INFO] running `"docker" "start" "-a" "fcf4934873621ad4de1274cee43759e8ce29a2b47dabdf181e66ca6dca8d755d"`
[INFO] [stderr]     Checking term_size v0.3.0
[INFO] [stderr]     Checking atty v0.2.3
[INFO] [stderr]     Checking serde_json v1.0.6
[INFO] [stderr]     Checking num-bigint v0.1.40
[INFO] [stderr]     Checking textwrap v0.8.0
[INFO] [stderr]     Checking clap v2.26.2
[INFO] [stderr]     Checking num-rational v0.1.40
[INFO] [stderr]     Checking num v0.1.40
[INFO] [stderr]     Checking shamir-sharing v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]   --> src/field.rs:45:20
[INFO] [stderr]    |
[INFO] [stderr] 45 |                 if &x < prime {
[INFO] [stderr]    |                    --^^^^^^^^
[INFO] [stderr]    |                    |
[INFO] [stderr]    |                    help: use the left value directly: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Div` impl
[INFO] [stderr]    --> src/field.rs:145:14
[INFO] [stderr]     |
[INFO] [stderr] 145 |         self * inv
[INFO] [stderr]     |              ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/main.rs:97:5
[INFO] [stderr]     |
[INFO] [stderr] 97  | /     points.iter().enumerate().fold(Value::one(), |accum, (i, point)| {
[INFO] [stderr] 98  | |         if i == j { return accum } // basis polynomials have no term for p[j].
[INFO] [stderr] 99  | |
[INFO] [stderr] 100 | |         // (0 - point.x) / (points[j].x - point.x) = m_i
[INFO] [stderr] ...   |
[INFO] [stderr] 104 | |         accum * (numerator / denominator)
[INFO] [stderr] 105 | |     }).into()
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into()`
[INFO] [stderr]     |
[INFO] [stderr] 97  |     points.iter().enumerate().fold(Value::one(), |accum, (i, point)| {
[INFO] [stderr] 98  |         if i == j { return accum } // basis polynomials have no term for p[j].
[INFO] [stderr] 99  | 
[INFO] [stderr] 100 |         // (0 - point.x) / (points[j].x - point.x) = m_i
[INFO] [stderr] 101 |         let numerator = Value::zero() - point.x.clone();
[INFO] [stderr] 102 |         let denominator = points[j].x.clone() - point.x.clone();
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/main.rs:144:12
[INFO] [stderr]     |
[INFO] [stderr] 144 |       if let Some(_) = matches.subcommand_matches("restore") {
[INFO] [stderr]     |  _____-      ^^^^^^^
[INFO] [stderr] 145 | |         use std::io::{self, Read};
[INFO] [stderr] 146 | |
[INFO] [stderr] 147 | |         let mut buffer = String::new();
[INFO] [stderr] ...   |
[INFO] [stderr] 160 | |         println!("{}", secret.to_hex_string());
[INFO] [stderr] 161 | |     }
[INFO] [stderr]     | |_____- help: try this: `if matches.subcommand_matches("restore").is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `shamir-sharing`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]   --> src/field.rs:45:20
[INFO] [stderr]    |
[INFO] [stderr] 45 |                 if &x < prime {
[INFO] [stderr]    |                    --^^^^^^^^
[INFO] [stderr]    |                    |
[INFO] [stderr]    |                    help: use the left value directly: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Div` impl
[INFO] [stderr]    --> src/field.rs:145:14
[INFO] [stderr]     |
[INFO] [stderr] 145 |         self * inv
[INFO] [stderr]     |              ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/main.rs:97:5
[INFO] [stderr]     |
[INFO] [stderr] 97  | /     points.iter().enumerate().fold(Value::one(), |accum, (i, point)| {
[INFO] [stderr] 98  | |         if i == j { return accum } // basis polynomials have no term for p[j].
[INFO] [stderr] 99  | |
[INFO] [stderr] 100 | |         // (0 - point.x) / (points[j].x - point.x) = m_i
[INFO] [stderr] ...   |
[INFO] [stderr] 104 | |         accum * (numerator / denominator)
[INFO] [stderr] 105 | |     }).into()
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into()`
[INFO] [stderr]     |
[INFO] [stderr] 97  |     points.iter().enumerate().fold(Value::one(), |accum, (i, point)| {
[INFO] [stderr] 98  |         if i == j { return accum } // basis polynomials have no term for p[j].
[INFO] [stderr] 99  | 
[INFO] [stderr] 100 |         // (0 - point.x) / (points[j].x - point.x) = m_i
[INFO] [stderr] 101 |         let numerator = Value::zero() - point.x.clone();
[INFO] [stderr] 102 |         let denominator = points[j].x.clone() - point.x.clone();
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/main.rs:144:12
[INFO] [stderr]     |
[INFO] [stderr] 144 |       if let Some(_) = matches.subcommand_matches("restore") {
[INFO] [stderr]     |  _____-      ^^^^^^^
[INFO] [stderr] 145 | |         use std::io::{self, Read};
[INFO] [stderr] 146 | |
[INFO] [stderr] 147 | |         let mut buffer = String::new();
[INFO] [stderr] ...   |
[INFO] [stderr] 160 | |         println!("{}", secret.to_hex_string());
[INFO] [stderr] 161 | |     }
[INFO] [stderr]     | |_____- help: try this: `if matches.subcommand_matches("restore").is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `shamir-sharing`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "fcf4934873621ad4de1274cee43759e8ce29a2b47dabdf181e66ca6dca8d755d"`
[INFO] running `"docker" "rm" "-f" "fcf4934873621ad4de1274cee43759e8ce29a2b47dabdf181e66ca6dca8d755d"`
[INFO] [stdout] fcf4934873621ad4de1274cee43759e8ce29a2b47dabdf181e66ca6dca8d755d