[INFO] updating cached repository royaltm/rust-fractx [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/royaltm/rust-fractx [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/royaltm/rust-fractx" "work/ex/clippy-test-run/sources/stable/gh/royaltm/rust-fractx"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/royaltm/rust-fractx'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/royaltm/rust-fractx" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/royaltm/rust-fractx"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/royaltm/rust-fractx'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b6c4dbb851de9f8a75cbcc7487dcf0400d016509 [INFO] sha for GitHub repo royaltm/rust-fractx: b6c4dbb851de9f8a75cbcc7487dcf0400d016509 [INFO] validating manifest of royaltm/rust-fractx on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of royaltm/rust-fractx on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing royaltm/rust-fractx [INFO] finished frobbing royaltm/rust-fractx [INFO] frobbed toml for royaltm/rust-fractx written to work/ex/clippy-test-run/sources/stable/gh/royaltm/rust-fractx/Cargo.toml [INFO] started frobbing royaltm/rust-fractx [INFO] finished frobbing royaltm/rust-fractx [INFO] frobbed toml for royaltm/rust-fractx written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/royaltm/rust-fractx/Cargo.toml [INFO] crate royaltm/rust-fractx has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting royaltm/rust-fractx against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/royaltm/rust-fractx:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ce809b2791932e7c89c11ea8100087a0d1b588e98c1d86ee2f786d3a0d78d05e [INFO] running `"docker" "start" "-a" "ce809b2791932e7c89c11ea8100087a0d1b588e98c1d86ee2f786d3a0d78d05e"` [INFO] [stderr] Checking num-integer v0.1.36 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking clap v2.30.0 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking num-iter v0.1.35 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking rayon v1.0.0 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking fractx v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/buffer.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return pixels; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `pixels` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parallel.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | return pixels; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `pixels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/buffer.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return pixels; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `pixels` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parallel.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | return pixels; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `pixels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/iter.rs:6:14 [INFO] [stderr] | [INFO] [stderr] 6 | for i in 1..maxi+1 { [INFO] [stderr] | ^^^^^^^^^ help: use: `1..=maxi` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:25:36 [INFO] [stderr] | [INFO] [stderr] 25 | let dx = (x1 - x0).abs() / (w as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(w)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:26:36 [INFO] [stderr] | [INFO] [stderr] 26 | let dy = (y1 - y0).abs() / (h as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | self.dx * (self.w as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:57:19 [INFO] [stderr] | [INFO] [stderr] 57 | self.dy * (self.h as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:66:30 [INFO] [stderr] | [INFO] [stderr] 66 | self.x0 + self.dx * (self.w as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:67:30 [INFO] [stderr] | [INFO] [stderr] 67 | self.y0 + self.dy * (self.h as f64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:71:18 [INFO] [stderr] | [INFO] [stderr] 71 | (self.x0+(x as f64)*self.dx, self.y0+(y as f64)*self.dy) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:71:46 [INFO] [stderr] | [INFO] [stderr] 71 | (self.x0+(x as f64)*self.dx, self.y0+(y as f64)*self.dy) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/fractal.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | self.x0 = self.dx * (offx as f64) + self.x0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.x0 += self.dx * (offx as f64)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:80:29 [INFO] [stderr] | [INFO] [stderr] 80 | self.x0 = self.dx * (offx as f64) + self.x0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(offx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/fractal.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | self.y0 = self.dy * (offy as f64) + self.y0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.y0 += self.dy * (offy as f64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:81:29 [INFO] [stderr] | [INFO] [stderr] 81 | self.y0 = self.dy * (offy as f64) + self.y0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(offy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:95:25 [INFO] [stderr] | [INFO] [stderr] 95 | self.dx = vbx / (self.w as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:96:25 [INFO] [stderr] | [INFO] [stderr] 96 | self.dy = vby / (self.h as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:103:29 [INFO] [stderr] | [INFO] [stderr] 103 | self.x0 = cx - dx * (x as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:104:29 [INFO] [stderr] | [INFO] [stderr] 104 | self.y0 = cy - dy * (y as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:112:23 [INFO] [stderr] | [INFO] [stderr] 112 | let x0 = dx * (offx as f64) + self.x0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(offx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:113:23 [INFO] [stderr] | [INFO] [stderr] 113 | let y0 = dy * (offy as f64) + self.y0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(offy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/buffer.rs:76:23 [INFO] [stderr] | [INFO] [stderr] 76 | *p = to_pixel(i as f64 / iters as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/buffer.rs:76:34 [INFO] [stderr] | [INFO] [stderr] 76 | *p = to_pixel(i as f64 / iters as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(iters)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/img.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | Color::gray(1.0 - i as f64 / iters as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/img.rs:41:38 [INFO] [stderr] | [INFO] [stderr] 41 | Color::gray(1.0 - i as f64 / iters as f64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(iters)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/iter.rs:6:14 [INFO] [stderr] | [INFO] [stderr] 6 | for i in 1..maxi+1 { [INFO] [stderr] | ^^^^^^^^^ help: use: `1..=maxi` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:25:36 [INFO] [stderr] | [INFO] [stderr] 25 | let dx = (x1 - x0).abs() / (w as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(w)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:26:36 [INFO] [stderr] | [INFO] [stderr] 26 | let dy = (y1 - y0).abs() / (h as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | self.dx * (self.w as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:57:19 [INFO] [stderr] | [INFO] [stderr] 57 | self.dy * (self.h as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:66:30 [INFO] [stderr] | [INFO] [stderr] 66 | self.x0 + self.dx * (self.w as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:67:30 [INFO] [stderr] | [INFO] [stderr] 67 | self.y0 + self.dy * (self.h as f64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:71:18 [INFO] [stderr] | [INFO] [stderr] 71 | (self.x0+(x as f64)*self.dx, self.y0+(y as f64)*self.dy) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:71:46 [INFO] [stderr] | [INFO] [stderr] 71 | (self.x0+(x as f64)*self.dx, self.y0+(y as f64)*self.dy) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/fractal.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | self.x0 = self.dx * (offx as f64) + self.x0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.x0 += self.dx * (offx as f64)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:80:29 [INFO] [stderr] | [INFO] [stderr] 80 | self.x0 = self.dx * (offx as f64) + self.x0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(offx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/fractal.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | self.y0 = self.dy * (offy as f64) + self.y0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.y0 += self.dy * (offy as f64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:81:29 [INFO] [stderr] | [INFO] [stderr] 81 | self.y0 = self.dy * (offy as f64) + self.y0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(offy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:95:25 [INFO] [stderr] | [INFO] [stderr] 95 | self.dx = vbx / (self.w as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:96:25 [INFO] [stderr] | [INFO] [stderr] 96 | self.dy = vby / (self.h as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:103:29 [INFO] [stderr] | [INFO] [stderr] 103 | self.x0 = cx - dx * (x as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:104:29 [INFO] [stderr] | [INFO] [stderr] 104 | self.y0 = cy - dy * (y as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:112:23 [INFO] [stderr] | [INFO] [stderr] 112 | let x0 = dx * (offx as f64) + self.x0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(offx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:113:23 [INFO] [stderr] | [INFO] [stderr] 113 | let y0 = dy * (offy as f64) + self.y0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(offy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/buffer.rs:76:23 [INFO] [stderr] | [INFO] [stderr] 76 | *p = to_pixel(i as f64 / iters as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/buffer.rs:76:34 [INFO] [stderr] | [INFO] [stderr] 76 | *p = to_pixel(i as f64 / iters as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(iters)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/img.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | Color::gray(1.0 - i as f64 / iters as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/img.rs:41:38 [INFO] [stderr] | [INFO] [stderr] 41 | Color::gray(1.0 - i as f64 / iters as f64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(iters)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/fractal_test.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `fractx`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/buffer.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return pixels; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `pixels` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parallel.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | return pixels; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `pixels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/buffer.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return pixels; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `pixels` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parallel.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | return pixels; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `pixels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/iter.rs:6:14 [INFO] [stderr] | [INFO] [stderr] 6 | for i in 1..maxi+1 { [INFO] [stderr] | ^^^^^^^^^ help: use: `1..=maxi` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:25:36 [INFO] [stderr] | [INFO] [stderr] 25 | let dx = (x1 - x0).abs() / (w as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(w)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:26:36 [INFO] [stderr] | [INFO] [stderr] 26 | let dy = (y1 - y0).abs() / (h as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | self.dx * (self.w as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:57:19 [INFO] [stderr] | [INFO] [stderr] 57 | self.dy * (self.h as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:66:30 [INFO] [stderr] | [INFO] [stderr] 66 | self.x0 + self.dx * (self.w as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:67:30 [INFO] [stderr] | [INFO] [stderr] 67 | self.y0 + self.dy * (self.h as f64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:71:18 [INFO] [stderr] | [INFO] [stderr] 71 | (self.x0+(x as f64)*self.dx, self.y0+(y as f64)*self.dy) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:71:46 [INFO] [stderr] | [INFO] [stderr] 71 | (self.x0+(x as f64)*self.dx, self.y0+(y as f64)*self.dy) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/fractal.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | self.x0 = self.dx * (offx as f64) + self.x0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.x0 += self.dx * (offx as f64)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:80:29 [INFO] [stderr] | [INFO] [stderr] 80 | self.x0 = self.dx * (offx as f64) + self.x0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(offx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/fractal.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | self.y0 = self.dy * (offy as f64) + self.y0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.y0 += self.dy * (offy as f64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:81:29 [INFO] [stderr] | [INFO] [stderr] 81 | self.y0 = self.dy * (offy as f64) + self.y0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(offy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:95:25 [INFO] [stderr] | [INFO] [stderr] 95 | self.dx = vbx / (self.w as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:96:25 [INFO] [stderr] | [INFO] [stderr] 96 | self.dy = vby / (self.h as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:103:29 [INFO] [stderr] | [INFO] [stderr] 103 | self.x0 = cx - dx * (x as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:104:29 [INFO] [stderr] | [INFO] [stderr] 104 | self.y0 = cy - dy * (y as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:112:23 [INFO] [stderr] | [INFO] [stderr] 112 | let x0 = dx * (offx as f64) + self.x0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(offx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:113:23 [INFO] [stderr] | [INFO] [stderr] 113 | let y0 = dy * (offy as f64) + self.y0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(offy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/img.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | Color::gray(1.0 - i as f64 / iters as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/img.rs:41:38 [INFO] [stderr] | [INFO] [stderr] 41 | Color::gray(1.0 - i as f64 / iters as f64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(iters)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/buffer.rs:76:23 [INFO] [stderr] | [INFO] [stderr] 76 | *p = to_pixel(i as f64 / iters as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/buffer.rs:76:34 [INFO] [stderr] | [INFO] [stderr] 76 | *p = to_pixel(i as f64 / iters as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(iters)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:107:25 [INFO] [stderr] | [INFO] [stderr] 107 | let ref buffer = vec_u32_as_vec_u8(Parallel::::to_img_buffer(&img, iters, mono, threads)); [INFO] [stderr] | ----^^^^^^^^^^--------------------------------------------------------------------------------- help: try: `let buffer = &vec_u32_as_vec_u8(Parallel::::to_img_buffer(&img, iters, mono, threads));` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:111:25 [INFO] [stderr] | [INFO] [stderr] 111 | let ref buffer = Parallel::::to_img_buffer(&img, iters, mono, threads); [INFO] [stderr] | ----^^^^^^^^^^------------------------------------------------------------- help: try: `let buffer = &Parallel::::to_img_buffer(&img, iters, mono, threads);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/iter.rs:6:14 [INFO] [stderr] | [INFO] [stderr] 6 | for i in 1..maxi+1 { [INFO] [stderr] | ^^^^^^^^^ help: use: `1..=maxi` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:25:36 [INFO] [stderr] | [INFO] [stderr] 25 | let dx = (x1 - x0).abs() / (w as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(w)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:26:36 [INFO] [stderr] | [INFO] [stderr] 26 | let dy = (y1 - y0).abs() / (h as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | self.dx * (self.w as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:57:19 [INFO] [stderr] | [INFO] [stderr] 57 | self.dy * (self.h as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:66:30 [INFO] [stderr] | [INFO] [stderr] 66 | self.x0 + self.dx * (self.w as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:67:30 [INFO] [stderr] | [INFO] [stderr] 67 | self.y0 + self.dy * (self.h as f64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:71:18 [INFO] [stderr] | [INFO] [stderr] 71 | (self.x0+(x as f64)*self.dx, self.y0+(y as f64)*self.dy) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:71:46 [INFO] [stderr] | [INFO] [stderr] 71 | (self.x0+(x as f64)*self.dx, self.y0+(y as f64)*self.dy) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/fractal.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | self.x0 = self.dx * (offx as f64) + self.x0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.x0 += self.dx * (offx as f64)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:80:29 [INFO] [stderr] | [INFO] [stderr] 80 | self.x0 = self.dx * (offx as f64) + self.x0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(offx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/fractal.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | self.y0 = self.dy * (offy as f64) + self.y0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.y0 += self.dy * (offy as f64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:81:29 [INFO] [stderr] | [INFO] [stderr] 81 | self.y0 = self.dy * (offy as f64) + self.y0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(offy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:95:25 [INFO] [stderr] | [INFO] [stderr] 95 | self.dx = vbx / (self.w as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:96:25 [INFO] [stderr] | [INFO] [stderr] 96 | self.dy = vby / (self.h as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:103:29 [INFO] [stderr] | [INFO] [stderr] 103 | self.x0 = cx - dx * (x as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:104:29 [INFO] [stderr] | [INFO] [stderr] 104 | self.y0 = cy - dy * (y as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:112:23 [INFO] [stderr] | [INFO] [stderr] 112 | let x0 = dx * (offx as f64) + self.x0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(offx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:113:23 [INFO] [stderr] | [INFO] [stderr] 113 | let y0 = dy * (offy as f64) + self.y0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(offy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/img.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | Color::gray(1.0 - i as f64 / iters as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/img.rs:41:38 [INFO] [stderr] | [INFO] [stderr] 41 | Color::gray(1.0 - i as f64 / iters as f64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(iters)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/buffer.rs:76:23 [INFO] [stderr] | [INFO] [stderr] 76 | *p = to_pixel(i as f64 / iters as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/buffer.rs:76:34 [INFO] [stderr] | [INFO] [stderr] 76 | *p = to_pixel(i as f64 / iters as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(iters)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:107:25 [INFO] [stderr] | [INFO] [stderr] 107 | let ref buffer = vec_u32_as_vec_u8(Parallel::::to_img_buffer(&img, iters, mono, threads)); [INFO] [stderr] | ----^^^^^^^^^^--------------------------------------------------------------------------------- help: try: `let buffer = &vec_u32_as_vec_u8(Parallel::::to_img_buffer(&img, iters, mono, threads));` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:111:25 [INFO] [stderr] | [INFO] [stderr] 111 | let ref buffer = Parallel::::to_img_buffer(&img, iters, mono, threads); [INFO] [stderr] | ----^^^^^^^^^^------------------------------------------------------------- help: try: `let buffer = &Parallel::::to_img_buffer(&img, iters, mono, threads);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "ce809b2791932e7c89c11ea8100087a0d1b588e98c1d86ee2f786d3a0d78d05e"` [INFO] running `"docker" "rm" "-f" "ce809b2791932e7c89c11ea8100087a0d1b588e98c1d86ee2f786d3a0d78d05e"` [INFO] [stdout] ce809b2791932e7c89c11ea8100087a0d1b588e98c1d86ee2f786d3a0d78d05e