[INFO] updating cached repository royaltm/example_mockup_internal [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/royaltm/example_mockup_internal [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/royaltm/example_mockup_internal" "work/ex/clippy-test-run/sources/stable/gh/royaltm/example_mockup_internal"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/royaltm/example_mockup_internal'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/royaltm/example_mockup_internal" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/royaltm/example_mockup_internal"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/royaltm/example_mockup_internal'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9ea04df1d1df096dcd85b50136033130d8976c61 [INFO] sha for GitHub repo royaltm/example_mockup_internal: 9ea04df1d1df096dcd85b50136033130d8976c61 [INFO] validating manifest of royaltm/example_mockup_internal on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of royaltm/example_mockup_internal on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing royaltm/example_mockup_internal [INFO] finished frobbing royaltm/example_mockup_internal [INFO] frobbed toml for royaltm/example_mockup_internal written to work/ex/clippy-test-run/sources/stable/gh/royaltm/example_mockup_internal/Cargo.toml [INFO] started frobbing royaltm/example_mockup_internal [INFO] finished frobbing royaltm/example_mockup_internal [INFO] frobbed toml for royaltm/example_mockup_internal written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/royaltm/example_mockup_internal/Cargo.toml [INFO] crate royaltm/example_mockup_internal has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting royaltm/example_mockup_internal against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/royaltm/example_mockup_internal:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bd0c4fdcdc7716771f370fa776facd188de85d9bd80613b5cab590da891e7d80 [INFO] running `"docker" "start" "-a" "bd0c4fdcdc7716771f370fa776facd188de85d9bd80613b5cab590da891e7d80"` [INFO] [stderr] Checking bincode v1.0.1 [INFO] [stderr] Compiling syn v0.15.8 [INFO] [stderr] Compiling serde_derive v1.0.79 [INFO] [stderr] Checking mhc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:22:30 [INFO] [stderr] | [INFO] [stderr] 22 | const DEFAULT_BIND_ADDRESS: &'static str = "0.0.0.0:5000"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/main.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | preset : _, // any preset will do [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `MHCPacket { protocol_id : 0x15, size : MHC_PACKET_SIZE_U8, command_type: 0x01, head : 0x00, signature : 0x66, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:22:30 [INFO] [stderr] | [INFO] [stderr] 22 | const DEFAULT_BIND_ADDRESS: &'static str = "0.0.0.0:5000"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/main.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | preset : _, // any preset will do [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `MHCPacket { protocol_id : 0x15, size : MHC_PACKET_SIZE_U8, command_type: 0x01, head : 0x00, signature : 0x66, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: The function/method `send_to` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:79:40 [INFO] [stderr] | [INFO] [stderr] 79 | socket.send_to(&mut buf, &src)?; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `send_to` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:79:40 [INFO] [stderr] | [INFO] [stderr] 79 | socket.send_to(&mut buf, &src)?; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.49s [INFO] running `"docker" "inspect" "bd0c4fdcdc7716771f370fa776facd188de85d9bd80613b5cab590da891e7d80"` [INFO] running `"docker" "rm" "-f" "bd0c4fdcdc7716771f370fa776facd188de85d9bd80613b5cab590da891e7d80"` [INFO] [stdout] bd0c4fdcdc7716771f370fa776facd188de85d9bd80613b5cab590da891e7d80