[INFO] updating cached repository royaldark/rust-ls [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/royaldark/rust-ls [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/royaldark/rust-ls" "work/ex/clippy-test-run/sources/stable/gh/royaldark/rust-ls"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/royaldark/rust-ls'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/royaldark/rust-ls" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/royaldark/rust-ls"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/royaldark/rust-ls'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2956c7e05ad15ffd6f6eb2e89667e536c9d1b9a8 [INFO] sha for GitHub repo royaldark/rust-ls: 2956c7e05ad15ffd6f6eb2e89667e536c9d1b9a8 [INFO] validating manifest of royaldark/rust-ls on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of royaldark/rust-ls on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing royaldark/rust-ls [INFO] finished frobbing royaldark/rust-ls [INFO] frobbed toml for royaldark/rust-ls written to work/ex/clippy-test-run/sources/stable/gh/royaldark/rust-ls/Cargo.toml [INFO] started frobbing royaldark/rust-ls [INFO] finished frobbing royaldark/rust-ls [INFO] frobbed toml for royaldark/rust-ls written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/royaldark/rust-ls/Cargo.toml [INFO] crate royaldark/rust-ls has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting royaldark/rust-ls against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/royaldark/rust-ls:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4532937d6536b842512c76a5b2a9821ccd859a8ae5c18e3506851d218c528c0c [INFO] running `"docker" "start" "-a" "4532937d6536b842512c76a5b2a9821ccd859a8ae5c18e3506851d218c528c0c"` [INFO] [stderr] Checking atty v0.2.6 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking users v0.6.0 [INFO] [stderr] Checking clap v2.29.0 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking ls v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | paths: paths, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `paths` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fs.rs:82:21 [INFO] [stderr] | [INFO] [stderr] 82 | meta: meta [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | paths: paths, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `paths` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fs.rs:82:21 [INFO] [stderr] | [INFO] [stderr] 82 | meta: meta [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/format.rs:287:77 [INFO] [stderr] | [INFO] [stderr] 287 | fn print_dir_header_if_needed(root: Option, opts: &cli::LsOptions) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/format.rs:294:84 [INFO] [stderr] | [INFO] [stderr] 294 | fn long_form(root: Option, entries: &Vec, opts: &cli::LsOptions) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/format.rs:321:90 [INFO] [stderr] | [INFO] [stderr] 321 | fn group_long_form(root: Option, entries: &Vec, opts: &cli::LsOptions) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/format.rs:345:85 [INFO] [stderr] | [INFO] [stderr] 345 | fn short_form(root: Option, entries: &Vec, opts: &cli::LsOptions) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/fs.rs:14:63 [INFO] [stderr] | [INFO] [stderr] 14 | fn add_implied_dirs(dir: &str, fs_entries: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/format.rs:287:77 [INFO] [stderr] | [INFO] [stderr] 287 | fn print_dir_header_if_needed(root: Option, opts: &cli::LsOptions) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/format.rs:294:84 [INFO] [stderr] | [INFO] [stderr] 294 | fn long_form(root: Option, entries: &Vec, opts: &cli::LsOptions) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/format.rs:321:90 [INFO] [stderr] | [INFO] [stderr] 321 | fn group_long_form(root: Option, entries: &Vec, opts: &cli::LsOptions) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/format.rs:345:85 [INFO] [stderr] | [INFO] [stderr] 345 | fn short_form(root: Option, entries: &Vec, opts: &cli::LsOptions) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/fs.rs:14:63 [INFO] [stderr] | [INFO] [stderr] 14 | fn add_implied_dirs(dir: &str, fs_entries: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused variable: `dir` [INFO] [stderr] --> src/fs.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | fn to_fs_entries(dir: &FsEntry, dir_entries: &Vec, opts: &LsOptions) -> Vec { [INFO] [stderr] | ^^^ help: consider using `_dir` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `add_implied_dirs` [INFO] [stderr] --> src/fs.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | fn add_implied_dirs(dir: &str, fs_entries: &mut Vec) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: Clike enum variant discriminant is not portable to 32-bit targets [INFO] [stderr] --> src/format.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | T = 1024 * 1024 * 1024 * 1024, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::enum_clike_unportable_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_clike_unportable_variant [INFO] [stderr] [INFO] [stderr] error: Clike enum variant discriminant is not portable to 32-bit targets [INFO] [stderr] --> src/format.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | P = 1024 * 1024 * 1024 * 1024 * 1024, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_clike_unportable_variant [INFO] [stderr] [INFO] [stderr] error: Clike enum variant discriminant is not portable to 32-bit targets [INFO] [stderr] --> src/format.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | t = 1000 * 1000 * 1000 * 1000, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_clike_unportable_variant [INFO] [stderr] [INFO] [stderr] error: Clike enum variant discriminant is not portable to 32-bit targets [INFO] [stderr] --> src/format.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | p = 1000 * 1000 * 1000 * 1000 * 1000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_clike_unportable_variant [INFO] [stderr] [INFO] [stderr] warning: unused variable: `dir` [INFO] [stderr] --> src/fs.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | fn to_fs_entries(dir: &FsEntry, dir_entries: &Vec, opts: &LsOptions) -> Vec { [INFO] [stderr] | ^^^ help: consider using `_dir` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format.rs:239:31 [INFO] [stderr] | [INFO] [stderr] 239 | fn to_format_entries(entries: &Vec, opts: &cli::LsOptions) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[FsEntry]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format.rs:249:24 [INFO] [stderr] | [INFO] [stderr] 249 | fn max_len(entries: &Vec, f: F) -> usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[FormatEntry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/format.rs:268:5 [INFO] [stderr] | [INFO] [stderr] 268 | / match color { [INFO] [stderr] 269 | | &ColorOption::Always => true, [INFO] [stderr] 270 | | &ColorOption::Never => false, [INFO] [stderr] 271 | | &ColorOption::Auto => is_tty() [INFO] [stderr] 272 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 268 | match *color { [INFO] [stderr] 269 | ColorOption::Always => true, [INFO] [stderr] 270 | ColorOption::Never => false, [INFO] [stderr] 271 | ColorOption::Auto => is_tty() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format.rs:294:46 [INFO] [stderr] | [INFO] [stderr] 294 | fn long_form(root: Option, entries: &Vec, opts: &cli::LsOptions) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[FsEntry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format.rs:321:52 [INFO] [stderr] | [INFO] [stderr] 321 | fn group_long_form(root: Option, entries: &Vec, opts: &cli::LsOptions) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[FsEntry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format.rs:345:47 [INFO] [stderr] | [INFO] [stderr] 345 | fn short_form(root: Option, entries: &Vec, opts: &cli::LsOptions) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[FsEntry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format.rs:353:54 [INFO] [stderr] | [INFO] [stderr] 353 | pub fn print_entries(root: Option, entries: &Vec, opts: &cli::LsOptions) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[FsEntry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/fs.rs:11:67 [INFO] [stderr] | [INFO] [stderr] 11 | entry.path.file_name().unwrap().to_str().unwrap().starts_with(".") [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/fs.rs:31:46 [INFO] [stderr] | [INFO] [stderr] 31 | fn to_fs_entries(dir: &FsEntry, dir_entries: &Vec, opts: &LsOptions) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[fs::DirEntry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/fs.rs:56:53 [INFO] [stderr] | [INFO] [stderr] 56 | fn ls_print_entries(root: Option, entries: &Vec, opts: &LsOptions) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[FsEntry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/fs.rs:74:27 [INFO] [stderr] | [INFO] [stderr] 74 | fn get_input_meta(inputs: &Vec) -> io::Result> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ls`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: function is never used: `add_implied_dirs` [INFO] [stderr] --> src/fs.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | fn add_implied_dirs(dir: &str, fs_entries: &mut Vec) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: Clike enum variant discriminant is not portable to 32-bit targets [INFO] [stderr] --> src/format.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | T = 1024 * 1024 * 1024 * 1024, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::enum_clike_unportable_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_clike_unportable_variant [INFO] [stderr] [INFO] [stderr] error: Clike enum variant discriminant is not portable to 32-bit targets [INFO] [stderr] --> src/format.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | P = 1024 * 1024 * 1024 * 1024 * 1024, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_clike_unportable_variant [INFO] [stderr] [INFO] [stderr] error: Clike enum variant discriminant is not portable to 32-bit targets [INFO] [stderr] --> src/format.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | t = 1000 * 1000 * 1000 * 1000, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_clike_unportable_variant [INFO] [stderr] [INFO] [stderr] error: Clike enum variant discriminant is not portable to 32-bit targets [INFO] [stderr] --> src/format.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | p = 1000 * 1000 * 1000 * 1000 * 1000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_clike_unportable_variant [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format.rs:239:31 [INFO] [stderr] | [INFO] [stderr] 239 | fn to_format_entries(entries: &Vec, opts: &cli::LsOptions) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[FsEntry]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format.rs:249:24 [INFO] [stderr] | [INFO] [stderr] 249 | fn max_len(entries: &Vec, f: F) -> usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[FormatEntry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/format.rs:268:5 [INFO] [stderr] | [INFO] [stderr] 268 | / match color { [INFO] [stderr] 269 | | &ColorOption::Always => true, [INFO] [stderr] 270 | | &ColorOption::Never => false, [INFO] [stderr] 271 | | &ColorOption::Auto => is_tty() [INFO] [stderr] 272 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 268 | match *color { [INFO] [stderr] 269 | ColorOption::Always => true, [INFO] [stderr] 270 | ColorOption::Never => false, [INFO] [stderr] 271 | ColorOption::Auto => is_tty() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format.rs:294:46 [INFO] [stderr] | [INFO] [stderr] 294 | fn long_form(root: Option, entries: &Vec, opts: &cli::LsOptions) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[FsEntry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format.rs:321:52 [INFO] [stderr] | [INFO] [stderr] 321 | fn group_long_form(root: Option, entries: &Vec, opts: &cli::LsOptions) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[FsEntry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format.rs:345:47 [INFO] [stderr] | [INFO] [stderr] 345 | fn short_form(root: Option, entries: &Vec, opts: &cli::LsOptions) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[FsEntry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format.rs:353:54 [INFO] [stderr] | [INFO] [stderr] 353 | pub fn print_entries(root: Option, entries: &Vec, opts: &cli::LsOptions) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[FsEntry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/fs.rs:11:67 [INFO] [stderr] | [INFO] [stderr] 11 | entry.path.file_name().unwrap().to_str().unwrap().starts_with(".") [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/fs.rs:31:46 [INFO] [stderr] | [INFO] [stderr] 31 | fn to_fs_entries(dir: &FsEntry, dir_entries: &Vec, opts: &LsOptions) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[fs::DirEntry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/fs.rs:56:53 [INFO] [stderr] | [INFO] [stderr] 56 | fn ls_print_entries(root: Option, entries: &Vec, opts: &LsOptions) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[FsEntry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/fs.rs:74:27 [INFO] [stderr] | [INFO] [stderr] 74 | fn get_input_meta(inputs: &Vec) -> io::Result> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ls`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4532937d6536b842512c76a5b2a9821ccd859a8ae5c18e3506851d218c528c0c"` [INFO] running `"docker" "rm" "-f" "4532937d6536b842512c76a5b2a9821ccd859a8ae5c18e3506851d218c528c0c"` [INFO] [stdout] 4532937d6536b842512c76a5b2a9821ccd859a8ae5c18e3506851d218c528c0c