[INFO] updating cached repository rossng/real-engine [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rossng/real-engine [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rossng/real-engine" "work/ex/clippy-test-run/sources/stable/gh/rossng/real-engine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rossng/real-engine'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rossng/real-engine" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rossng/real-engine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rossng/real-engine'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] de1356bc410185780e28bc748f35a1d4faffd28c [INFO] sha for GitHub repo rossng/real-engine: de1356bc410185780e28bc748f35a1d4faffd28c [INFO] validating manifest of rossng/real-engine on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rossng/real-engine on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rossng/real-engine [INFO] finished frobbing rossng/real-engine [INFO] frobbed toml for rossng/real-engine written to work/ex/clippy-test-run/sources/stable/gh/rossng/real-engine/Cargo.toml [INFO] started frobbing rossng/real-engine [INFO] finished frobbing rossng/real-engine [INFO] frobbed toml for rossng/real-engine written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rossng/real-engine/Cargo.toml [INFO] crate rossng/real-engine has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rossng/real-engine against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rossng/real-engine:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bb60b20d0837e243cf87f1bfb3513a72c280dd47f7e92cc40def517507bc84b6 [INFO] running `"docker" "start" "-a" "bb60b20d0837e243cf87f1bfb3513a72c280dd47f7e92cc40def517507bc84b6"` [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Compiling log v0.4.1 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking shared_library v0.1.8 [INFO] [stderr] Compiling x11-dl v2.17.5 [INFO] [stderr] Checking tempfile v3.0.2 [INFO] [stderr] Compiling gfx_macros v0.2.1 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking cgmath v0.16.1 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Compiling glutin v0.14.0 [INFO] [stderr] Compiling glutin v0.15.0 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking winit v0.13.1 [INFO] [stderr] Checking gfx_device_gl v0.15.2 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_window_glutin v0.22.0 [INFO] [stderr] Checking gfx_window_glutin v0.23.0 [INFO] [stderr] Checking gfx_app v0.7.0 [INFO] [stderr] Checking real-engine v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: unused import: `Deg` [INFO] [stderr] --> src/scene.rs:3:14 [INFO] [stderr] | [INFO] [stderr] 3 | use cgmath::{Deg, Matrix4, Point3, Vector3}; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/scene.rs:34:31 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn get_key(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/scene.rs:55:30 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn update(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/main.rs:127:44 [INFO] [stderr] | [INFO] [stderr] 127 | WindowEvent::KeyboardInput{device_id: _, input} => println!("Got key! {}", input.scancode), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `KeyboardInput { input, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unused import: `Deg` [INFO] [stderr] --> src/scene.rs:3:14 [INFO] [stderr] | [INFO] [stderr] 3 | use cgmath::{Deg, Matrix4, Point3, Vector3}; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/scene.rs:34:31 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn get_key(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/scene.rs:55:30 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn update(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/main.rs:127:44 [INFO] [stderr] | [INFO] [stderr] 127 | WindowEvent::KeyboardInput{device_id: _, input} => println!("Got key! {}", input.scancode), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `KeyboardInput { input, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unused variable: `device_id` [INFO] [stderr] --> src/scene.rs:38:64 [INFO] [stderr] | [INFO] [stderr] 38 | glutin::WindowEvent::KeyboardInput{device_id, input} => println!("Got key! {}", input.scancode), [INFO] [stderr] | ^^^^^^^^^ help: try ignoring the field: `device_id: _` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/pipeline.rs:38:23 [INFO] [stderr] | [INFO] [stderr] 38 | pos: [p[0] as f32, p[1] as f32, p[2] as f32, 1.0], [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(p[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/pipeline.rs:38:36 [INFO] [stderr] | [INFO] [stderr] 38 | pos: [p[0] as f32, p[1] as f32, p[2] as f32, 1.0], [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(p[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/pipeline.rs:38:49 [INFO] [stderr] | [INFO] [stderr] 38 | pos: [p[0] as f32, p[1] as f32, p[2] as f32, 1.0], [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(p[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/pipeline.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | tex_coord: [t[0] as f32, t[1] as f32], [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(t[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/pipeline.rs:39:42 [INFO] [stderr] | [INFO] [stderr] 39 | tex_coord: [t[0] as f32, t[1] as f32], [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(t[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scene.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | / match event { [INFO] [stderr] 37 | | glutin::Event::WindowEvent{ event, .. } => match event { [INFO] [stderr] 38 | | glutin::WindowEvent::KeyboardInput{device_id, input} => println!("Got key! {}", input.scancode), [INFO] [stderr] 39 | | _ => () [INFO] [stderr] 40 | | }, [INFO] [stderr] 41 | | _ => () [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 36 | if let glutin::Event::WindowEvent{ event, .. } = event { match event { [INFO] [stderr] 37 | glutin::WindowEvent::KeyboardInput{device_id, input} => println!("Got key! {}", input.scancode), [INFO] [stderr] 38 | _ => () [INFO] [stderr] 39 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scene.rs:37:68 [INFO] [stderr] | [INFO] [stderr] 37 | glutin::Event::WindowEvent{ event, .. } => match event { [INFO] [stderr] | ____________________________________________________________________^ [INFO] [stderr] 38 | | glutin::WindowEvent::KeyboardInput{device_id, input} => println!("Got key! {}", input.scancode), [INFO] [stderr] 39 | | _ => () [INFO] [stderr] 40 | | }, [INFO] [stderr] | |_________________________^ help: try this: `if let glutin::WindowEvent::KeyboardInput{device_id, input} = event { println!("Got key! {}", input.scancode) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused variable: `device_id` [INFO] [stderr] --> src/scene.rs:38:64 [INFO] [stderr] | [INFO] [stderr] 38 | glutin::WindowEvent::KeyboardInput{device_id, input} => println!("Got key! {}", input.scancode), [INFO] [stderr] | ^^^^^^^^^ help: try ignoring the field: `device_id: _` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/pipeline.rs:38:23 [INFO] [stderr] | [INFO] [stderr] 38 | pos: [p[0] as f32, p[1] as f32, p[2] as f32, 1.0], [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(p[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/pipeline.rs:38:36 [INFO] [stderr] | [INFO] [stderr] 38 | pos: [p[0] as f32, p[1] as f32, p[2] as f32, 1.0], [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(p[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/pipeline.rs:38:49 [INFO] [stderr] | [INFO] [stderr] 38 | pos: [p[0] as f32, p[1] as f32, p[2] as f32, 1.0], [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(p[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/pipeline.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | tex_coord: [t[0] as f32, t[1] as f32], [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(t[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/pipeline.rs:39:42 [INFO] [stderr] | [INFO] [stderr] 39 | tex_coord: [t[0] as f32, t[1] as f32], [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(t[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scene.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | / match event { [INFO] [stderr] 37 | | glutin::Event::WindowEvent{ event, .. } => match event { [INFO] [stderr] 38 | | glutin::WindowEvent::KeyboardInput{device_id, input} => println!("Got key! {}", input.scancode), [INFO] [stderr] 39 | | _ => () [INFO] [stderr] 40 | | }, [INFO] [stderr] 41 | | _ => () [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 36 | if let glutin::Event::WindowEvent{ event, .. } = event { match event { [INFO] [stderr] 37 | glutin::WindowEvent::KeyboardInput{device_id, input} => println!("Got key! {}", input.scancode), [INFO] [stderr] 38 | _ => () [INFO] [stderr] 39 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scene.rs:37:68 [INFO] [stderr] | [INFO] [stderr] 37 | glutin::Event::WindowEvent{ event, .. } => match event { [INFO] [stderr] | ____________________________________________________________________^ [INFO] [stderr] 38 | | glutin::WindowEvent::KeyboardInput{device_id, input} => println!("Got key! {}", input.scancode), [INFO] [stderr] 39 | | _ => () [INFO] [stderr] 40 | | }, [INFO] [stderr] | |_________________________^ help: try this: `if let glutin::WindowEvent::KeyboardInput{device_id, input} = event { println!("Got key! {}", input.scancode) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 07s [INFO] running `"docker" "inspect" "bb60b20d0837e243cf87f1bfb3513a72c280dd47f7e92cc40def517507bc84b6"` [INFO] running `"docker" "rm" "-f" "bb60b20d0837e243cf87f1bfb3513a72c280dd47f7e92cc40def517507bc84b6"` [INFO] [stdout] bb60b20d0837e243cf87f1bfb3513a72c280dd47f7e92cc40def517507bc84b6