[INFO] updating cached repository rossmacarthur/halite3-rust-starter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rossmacarthur/halite3-rust-starter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rossmacarthur/halite3-rust-starter" "work/ex/clippy-test-run/sources/stable/gh/rossmacarthur/halite3-rust-starter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rossmacarthur/halite3-rust-starter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rossmacarthur/halite3-rust-starter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rossmacarthur/halite3-rust-starter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rossmacarthur/halite3-rust-starter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 605bdca6f6ef8ae567d871c37161a0bd3ae96f4d [INFO] sha for GitHub repo rossmacarthur/halite3-rust-starter: 605bdca6f6ef8ae567d871c37161a0bd3ae96f4d [INFO] validating manifest of rossmacarthur/halite3-rust-starter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rossmacarthur/halite3-rust-starter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rossmacarthur/halite3-rust-starter [INFO] finished frobbing rossmacarthur/halite3-rust-starter [INFO] frobbed toml for rossmacarthur/halite3-rust-starter written to work/ex/clippy-test-run/sources/stable/gh/rossmacarthur/halite3-rust-starter/Cargo.toml [INFO] started frobbing rossmacarthur/halite3-rust-starter [INFO] finished frobbing rossmacarthur/halite3-rust-starter [INFO] frobbed toml for rossmacarthur/halite3-rust-starter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rossmacarthur/halite3-rust-starter/Cargo.toml [INFO] crate rossmacarthur/halite3-rust-starter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rossmacarthur/halite3-rust-starter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rossmacarthur/halite3-rust-starter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 94b8bb9aaecb4db19e310cdf6e5e3aa018990ca4da7857ed7c3b44419f1891a6 [INFO] running `"docker" "start" "-a" "94b8bb9aaecb4db19e310cdf6e5e3aa018990ca4da7857ed7c3b44419f1891a6"` [INFO] [stderr] Checking term v0.5.1 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking simplelog v0.5.3 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling derive_more v0.12.0 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking my_bot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: function is never used: `invert` [INFO] [stderr] --> src/hlt/board.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | fn invert(value: isize, dimension: isize) -> isize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `len` [INFO] [stderr] --> src/hlt/board.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn len(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `signum` [INFO] [stderr] --> src/hlt/board.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn signum(self) -> Offset { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dx` [INFO] [stderr] --> src/hlt/board.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn dx(self) -> Offset { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dy` [INFO] [stderr] --> src/hlt/board.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn dy(self) -> Offset { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `mirrored_dx` [INFO] [stderr] --> src/hlt/board.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn mirrored_dx(self) -> Offset { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `mirrored_dy` [INFO] [stderr] --> src/hlt/board.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn mirrored_dy(self) -> Offset { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `inverted_dx` [INFO] [stderr] --> src/hlt/board.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn inverted_dx(self, width: isize) -> Offset { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reduce` [INFO] [stderr] --> src/hlt/board.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn reduce(self, width: isize, height: isize) -> Offset { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `into_direction` [INFO] [stderr] --> src/hlt/board.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | fn into_direction(self) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `inverted_dy` [INFO] [stderr] --> src/hlt/board.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | pub fn inverted_dy(self, height: isize) -> Offset { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `inverted` [INFO] [stderr] --> src/hlt/board.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn inverted(self, width: isize, height: isize) -> Offset { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `surrounding` [INFO] [stderr] --> src/hlt/board.rs:176:5 [INFO] [stderr] | [INFO] [stderr] 176 | pub fn surrounding(&self) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `has_structure` [INFO] [stderr] --> src/hlt/board.rs:222:5 [INFO] [stderr] | [INFO] [stderr] 222 | pub fn has_structure(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_empty` [INFO] [stderr] --> src/hlt/board.rs:227:5 [INFO] [stderr] | [INFO] [stderr] 227 | pub fn is_empty(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ConvertToDropoff` [INFO] [stderr] --> src/hlt/mod.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | ConvertToDropoff(ShipId), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_player` [INFO] [stderr] --> src/hlt/mod.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | pub fn get_player(&self, player_id: PlayerId) -> Option<&Player> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_ship` [INFO] [stderr] --> src/hlt/mod.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | pub fn get_ship(&self, ship_id: ShipId) -> Option<&Ship> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_dropoff` [INFO] [stderr] --> src/hlt/mod.rs:205:5 [INFO] [stderr] | [INFO] [stderr] 205 | pub fn get_dropoff(&self, dropoff_id: DropoffId) -> Option<&Dropoff> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `navigate_to_halite` [INFO] [stderr] --> src/hlt/mod.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | pub fn navigate_to_halite(&self, ship_id: ShipId) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/hlt/engine/send.rs:28:35 [INFO] [stderr] | [INFO] [stderr] 28 | Command::Spawn => format!("g"), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"g".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/hlt/engine/mod.rs:53:15 [INFO] [stderr] | [INFO] [stderr] 53 | while self.tokens.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/hlt/mod.rs:296:14 [INFO] [stderr] | [INFO] [stderr] 296 | .expect(&format!("ship {} does not exist", ship_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("ship {} does not exist", ship_id))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: method is never used: `signum` [INFO] [stderr] --> src/hlt/board.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn signum(self) -> Offset { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dx` [INFO] [stderr] --> src/hlt/board.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn dx(self) -> Offset { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dy` [INFO] [stderr] --> src/hlt/board.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn dy(self) -> Offset { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `into_direction` [INFO] [stderr] --> src/hlt/board.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | fn into_direction(self) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `surrounding` [INFO] [stderr] --> src/hlt/board.rs:176:5 [INFO] [stderr] | [INFO] [stderr] 176 | pub fn surrounding(&self) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `has_structure` [INFO] [stderr] --> src/hlt/board.rs:222:5 [INFO] [stderr] | [INFO] [stderr] 222 | pub fn has_structure(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_empty` [INFO] [stderr] --> src/hlt/board.rs:227:5 [INFO] [stderr] | [INFO] [stderr] 227 | pub fn is_empty(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ConvertToDropoff` [INFO] [stderr] --> src/hlt/mod.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | ConvertToDropoff(ShipId), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_player` [INFO] [stderr] --> src/hlt/mod.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | pub fn get_player(&self, player_id: PlayerId) -> Option<&Player> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_ship` [INFO] [stderr] --> src/hlt/mod.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | pub fn get_ship(&self, ship_id: ShipId) -> Option<&Ship> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_dropoff` [INFO] [stderr] --> src/hlt/mod.rs:205:5 [INFO] [stderr] | [INFO] [stderr] 205 | pub fn get_dropoff(&self, dropoff_id: DropoffId) -> Option<&Dropoff> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `navigate_to_halite` [INFO] [stderr] --> src/hlt/mod.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | pub fn navigate_to_halite(&self, ship_id: ShipId) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/hlt/constants.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | assert_eq!(constants.inspired_bonus_multiplier, 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/hlt/constants.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | assert_eq!(constants.inspired_bonus_multiplier, 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/hlt/engine/send.rs:28:35 [INFO] [stderr] | [INFO] [stderr] 28 | Command::Spawn => format!("g"), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"g".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/hlt/engine/mod.rs:53:15 [INFO] [stderr] | [INFO] [stderr] 53 | while self.tokens.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/hlt/mod.rs:296:14 [INFO] [stderr] | [INFO] [stderr] 296 | .expect(&format!("ship {} does not exist", ship_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("ship {} does not exist", ship_id))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `my_bot`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "94b8bb9aaecb4db19e310cdf6e5e3aa018990ca4da7857ed7c3b44419f1891a6"` [INFO] running `"docker" "rm" "-f" "94b8bb9aaecb4db19e310cdf6e5e3aa018990ca4da7857ed7c3b44419f1891a6"` [INFO] [stdout] 94b8bb9aaecb4db19e310cdf6e5e3aa018990ca4da7857ed7c3b44419f1891a6