[INFO] updating cached repository rosarinjroy/rust_anagram_solver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rosarinjroy/rust_anagram_solver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rosarinjroy/rust_anagram_solver" "work/ex/clippy-test-run/sources/stable/gh/rosarinjroy/rust_anagram_solver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rosarinjroy/rust_anagram_solver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rosarinjroy/rust_anagram_solver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rosarinjroy/rust_anagram_solver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rosarinjroy/rust_anagram_solver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4074d8221095ed844a9a01a79d1c65a8e439df6b [INFO] sha for GitHub repo rosarinjroy/rust_anagram_solver: 4074d8221095ed844a9a01a79d1c65a8e439df6b [INFO] validating manifest of rosarinjroy/rust_anagram_solver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rosarinjroy/rust_anagram_solver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rosarinjroy/rust_anagram_solver [INFO] finished frobbing rosarinjroy/rust_anagram_solver [INFO] frobbed toml for rosarinjroy/rust_anagram_solver written to work/ex/clippy-test-run/sources/stable/gh/rosarinjroy/rust_anagram_solver/Cargo.toml [INFO] started frobbing rosarinjroy/rust_anagram_solver [INFO] finished frobbing rosarinjroy/rust_anagram_solver [INFO] frobbed toml for rosarinjroy/rust_anagram_solver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rosarinjroy/rust_anagram_solver/Cargo.toml [INFO] crate rosarinjroy/rust_anagram_solver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rosarinjroy/rust_anagram_solver against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rosarinjroy/rust_anagram_solver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 41dd9f06f9e9996c34e4613bc02758d857fa18fbea08de0efd43d57da38b73b0 [INFO] running `"docker" "start" "-a" "41dd9f06f9e9996c34e4613bc02758d857fa18fbea08de0efd43d57da38b73b0"` [INFO] [stderr] Checking rust_anagram_solver v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | return Some(anagram_key); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(anagram_key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:10:29 [INFO] [stderr] | [INFO] [stderr] 10 | fn get_anagram_key(trimmed: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:11:28 [INFO] [stderr] | [INFO] [stderr] 11 | if trimmed.starts_with("#") || trimmed.len() == 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:11:36 [INFO] [stderr] | [INFO] [stderr] 11 | if trimmed.starts_with("#") || trimmed.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `trimmed.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:62:24 [INFO] [stderr] | [INFO] [stderr] 62 | r.push(String::from(trimmed)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `trimmed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | return Some(anagram_key); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(anagram_key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:10:29 [INFO] [stderr] | [INFO] [stderr] 10 | fn get_anagram_key(trimmed: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:11:28 [INFO] [stderr] | [INFO] [stderr] 11 | if trimmed.starts_with("#") || trimmed.len() == 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:11:36 [INFO] [stderr] | [INFO] [stderr] 11 | if trimmed.starts_with("#") || trimmed.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `trimmed.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:62:24 [INFO] [stderr] | [INFO] [stderr] 62 | r.push(String::from(trimmed)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `trimmed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.77s [INFO] running `"docker" "inspect" "41dd9f06f9e9996c34e4613bc02758d857fa18fbea08de0efd43d57da38b73b0"` [INFO] running `"docker" "rm" "-f" "41dd9f06f9e9996c34e4613bc02758d857fa18fbea08de0efd43d57da38b73b0"` [INFO] [stdout] 41dd9f06f9e9996c34e4613bc02758d857fa18fbea08de0efd43d57da38b73b0