[INFO] updating cached repository rookie1024/Alas [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rookie1024/Alas [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rookie1024/Alas" "work/ex/clippy-test-run/sources/stable/gh/rookie1024/Alas"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rookie1024/Alas'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rookie1024/Alas" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rookie1024/Alas"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rookie1024/Alas'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 60bfe1d0d21461f8180c8a43b8fcfb6cd3e056db [INFO] sha for GitHub repo rookie1024/Alas: 60bfe1d0d21461f8180c8a43b8fcfb6cd3e056db [INFO] validating manifest of rookie1024/Alas on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rookie1024/Alas on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rookie1024/Alas [INFO] finished frobbing rookie1024/Alas [INFO] frobbed toml for rookie1024/Alas written to work/ex/clippy-test-run/sources/stable/gh/rookie1024/Alas/Cargo.toml [INFO] started frobbing rookie1024/Alas [INFO] finished frobbing rookie1024/Alas [INFO] frobbed toml for rookie1024/Alas written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rookie1024/Alas/Cargo.toml [INFO] crate rookie1024/Alas has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rookie1024/Alas against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rookie1024/Alas:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 69f65e197d3666cc56b56874c7da3cc97da0f78365eddc9803846c89f1dfcbe4 [INFO] running `"docker" "start" "-a" "69f65e197d3666cc56b56874c7da3cc97da0f78365eddc9803846c89f1dfcbe4"` [INFO] [stderr] Checking alas v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/reg/nfa/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | mod nfa; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/reg/nfa/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | mod nfa; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: field is never used: `start` [INFO] [stderr] --> src/reg/dfa.rs:14:3 [INFO] [stderr] | [INFO] [stderr] 14 | start: S, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/reg/dfa.rs:62:23 [INFO] [stderr] | [INFO] [stderr] 62 | fn collect_states<'a, T: Hash + Eq, S: Hash + Clone + Ord>( [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/reg/dfa.rs:71:7 [INFO] [stderr] | [INFO] [stderr] 71 | / loop { [INFO] [stderr] 72 | | let curr = match q.pop_front() { [INFO] [stderr] 73 | | Some(c) => c, [INFO] [stderr] 74 | | None => break, [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_______^ help: try: `while let Some(c) = q.pop_front() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/reg/dfa.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | / loop { [INFO] [stderr] 101 | | let curr = match q.pop_front() { [INFO] [stderr] 102 | | Some(c) => c, [INFO] [stderr] 103 | | None => break, [INFO] [stderr] ... | [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(c) = q.pop_front() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/reg/dfa.rs:116:48 [INFO] [stderr] | [INFO] [stderr] 116 | let new_tos = outs.entry(by.clone()).or_insert(BTreeSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(BTreeSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `reg::nfa::builder::NfaBuilder` [INFO] [stderr] --> src/reg/nfa/builder.rs:34:3 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Self { [INFO] [stderr] 35 | | let head = NfaNode::new_rc(); [INFO] [stderr] 36 | | let tail = NfaNode::new_rc(); [INFO] [stderr] 37 | | [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | impl Default for reg::nfa::builder::NfaBuilder { [INFO] [stderr] 34 | fn default() -> Self { [INFO] [stderr] 35 | Self::new() [INFO] [stderr] 36 | } [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/reg/nfa/builder.rs:190:8 [INFO] [stderr] | [INFO] [stderr] 190 | .or_insert(HashSet::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/reg/nfa/nfa.rs:97:12 [INFO] [stderr] | [INFO] [stderr] 97 | .or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reg/re.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | Re::cat_all((0..n).into_iter().map(|_| self.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: field is never used: `start` [INFO] [stderr] --> src/reg/dfa.rs:14:3 [INFO] [stderr] | [INFO] [stderr] 14 | start: S, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/reg/dfa.rs:62:23 [INFO] [stderr] | [INFO] [stderr] 62 | fn collect_states<'a, T: Hash + Eq, S: Hash + Clone + Ord>( [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/reg/dfa.rs:71:7 [INFO] [stderr] | [INFO] [stderr] 71 | / loop { [INFO] [stderr] 72 | | let curr = match q.pop_front() { [INFO] [stderr] 73 | | Some(c) => c, [INFO] [stderr] 74 | | None => break, [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_______^ help: try: `while let Some(c) = q.pop_front() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/reg/dfa.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | / loop { [INFO] [stderr] 101 | | let curr = match q.pop_front() { [INFO] [stderr] 102 | | Some(c) => c, [INFO] [stderr] 103 | | None => break, [INFO] [stderr] ... | [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(c) = q.pop_front() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/reg/dfa.rs:116:48 [INFO] [stderr] | [INFO] [stderr] 116 | let new_tos = outs.entry(by.clone()).or_insert(BTreeSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(BTreeSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `reg::nfa::builder::NfaBuilder` [INFO] [stderr] --> src/reg/nfa/builder.rs:34:3 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Self { [INFO] [stderr] 35 | | let head = NfaNode::new_rc(); [INFO] [stderr] 36 | | let tail = NfaNode::new_rc(); [INFO] [stderr] 37 | | [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | impl Default for reg::nfa::builder::NfaBuilder { [INFO] [stderr] 34 | fn default() -> Self { [INFO] [stderr] 35 | Self::new() [INFO] [stderr] 36 | } [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/reg/nfa/builder.rs:190:8 [INFO] [stderr] | [INFO] [stderr] 190 | .or_insert(HashSet::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/reg/nfa/nfa.rs:97:12 [INFO] [stderr] | [INFO] [stderr] 97 | .or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reg/re.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | Re::cat_all((0..n).into_iter().map(|_| self.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.91s [INFO] running `"docker" "inspect" "69f65e197d3666cc56b56874c7da3cc97da0f78365eddc9803846c89f1dfcbe4"` [INFO] running `"docker" "rm" "-f" "69f65e197d3666cc56b56874c7da3cc97da0f78365eddc9803846c89f1dfcbe4"` [INFO] [stdout] 69f65e197d3666cc56b56874c7da3cc97da0f78365eddc9803846c89f1dfcbe4