[INFO] updating cached repository romanlevin/mandelbrot-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/romanlevin/mandelbrot-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/romanlevin/mandelbrot-rs" "work/ex/clippy-test-run/sources/stable/gh/romanlevin/mandelbrot-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/romanlevin/mandelbrot-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/romanlevin/mandelbrot-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/romanlevin/mandelbrot-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/romanlevin/mandelbrot-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 40daa7166ad170fbe053776fbe3a5e155966fd65 [INFO] sha for GitHub repo romanlevin/mandelbrot-rs: 40daa7166ad170fbe053776fbe3a5e155966fd65 [INFO] validating manifest of romanlevin/mandelbrot-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of romanlevin/mandelbrot-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing romanlevin/mandelbrot-rs [INFO] finished frobbing romanlevin/mandelbrot-rs [INFO] frobbed toml for romanlevin/mandelbrot-rs written to work/ex/clippy-test-run/sources/stable/gh/romanlevin/mandelbrot-rs/Cargo.toml [INFO] started frobbing romanlevin/mandelbrot-rs [INFO] finished frobbing romanlevin/mandelbrot-rs [INFO] frobbed toml for romanlevin/mandelbrot-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/romanlevin/mandelbrot-rs/Cargo.toml [INFO] crate romanlevin/mandelbrot-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting romanlevin/mandelbrot-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/romanlevin/mandelbrot-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ecc48635e5bca39b318945c616f8c4a11dcd8051a3c14e1b56c9fa0fc0856d2c [INFO] running `"docker" "start" "-a" "ecc48635e5bca39b318945c616f8c4a11dcd8051a3c14e1b56c9fa0fc0856d2c"` [INFO] [stderr] Compiling serde v1.0.62 [INFO] [stderr] Compiling num-integer v0.1.38 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking log v0.4.1 [INFO] [stderr] Checking shared_library v0.1.8 [INFO] [stderr] Compiling x11-dl v2.17.5 [INFO] [stderr] Checking tempfile v3.0.2 [INFO] [stderr] Checking resolv-conf v0.6.1 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking tokio-threadpool v0.1.3 [INFO] [stderr] Compiling serde_derive v1.0.62 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking h2 v0.1.8 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Checking mio-uds v0.6.6 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking tokio-fs v0.1.0 [INFO] [stderr] Compiling glutin v0.14.0 [INFO] [stderr] Compiling glium v0.21.0 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking tokio v0.1.6 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking serde_json v1.0.18 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking trust-dns-proto v0.3.3 [INFO] [stderr] Checking tokio-signal v0.1.5 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Compiling cargo_metadata v0.5.4 [INFO] [stderr] Checking trust-dns-resolver v0.8.2 [INFO] [stderr] Compiling skeptic v0.13.3 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Compiling actix v0.5.7 [INFO] [stderr] Checking actix-web v0.6.10 [INFO] [stderr] Checking mandelbrot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/bin/gl.rs:74:37 [INFO] [stderr] | [INFO] [stderr] 74 | max_iterations: max_iterations as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(max_iterations)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/gl.rs:83:41 [INFO] [stderr] | [INFO] [stderr] 83 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 84 | | glutin::Event::WindowEvent { event: window_event, .. } => match window_event { [INFO] [stderr] 85 | | glutin::WindowEvent::Closed => closed = true, [INFO] [stderr] 86 | | glutin::WindowEvent::KeyboardInput{input: keyboard_input, ..} => match keyboard_input { [INFO] [stderr] ... | [INFO] [stderr] 111 | | _ => (), [INFO] [stderr] 112 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 83 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event: window_event, .. } = event { match window_event { [INFO] [stderr] 84 | glutin::WindowEvent::Closed => closed = true, [INFO] [stderr] 85 | glutin::WindowEvent::KeyboardInput{input: keyboard_input, ..} => match keyboard_input { [INFO] [stderr] 86 | glutin::KeyboardInput {virtual_keycode, state, .. } => if state == glutin::ElementState::Pressed { [INFO] [stderr] 87 | match virtual_keycode { [INFO] [stderr] 88 | Some(glutin::VirtualKeyCode::Z) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/gl.rs:90:33 [INFO] [stderr] | [INFO] [stderr] 90 | zoom = zoom * (1.0 + zoom_step); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `zoom *= (1.0 + zoom_step)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/gl.rs:94:33 [INFO] [stderr] | [INFO] [stderr] 94 | zoom = zoom / (1.0 + zoom_step); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `zoom /= (1.0 + zoom_step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/gl.rs:101:69 [INFO] [stderr] | [INFO] [stderr] 101 | Some(glutin::VirtualKeyCode::Equals) => max_iterations = max_iterations + 10, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_iterations += 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/gl.rs:102:68 [INFO] [stderr] | [INFO] [stderr] 102 | Some(glutin::VirtualKeyCode::Minus) => max_iterations = max_iterations - 10, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_iterations -= 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/bin/gl.rs:74:37 [INFO] [stderr] | [INFO] [stderr] 74 | max_iterations: max_iterations as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(max_iterations)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/gl.rs:83:41 [INFO] [stderr] | [INFO] [stderr] 83 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 84 | | glutin::Event::WindowEvent { event: window_event, .. } => match window_event { [INFO] [stderr] 85 | | glutin::WindowEvent::Closed => closed = true, [INFO] [stderr] 86 | | glutin::WindowEvent::KeyboardInput{input: keyboard_input, ..} => match keyboard_input { [INFO] [stderr] ... | [INFO] [stderr] 111 | | _ => (), [INFO] [stderr] 112 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 83 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event: window_event, .. } = event { match window_event { [INFO] [stderr] 84 | glutin::WindowEvent::Closed => closed = true, [INFO] [stderr] 85 | glutin::WindowEvent::KeyboardInput{input: keyboard_input, ..} => match keyboard_input { [INFO] [stderr] 86 | glutin::KeyboardInput {virtual_keycode, state, .. } => if state == glutin::ElementState::Pressed { [INFO] [stderr] 87 | match virtual_keycode { [INFO] [stderr] 88 | Some(glutin::VirtualKeyCode::Z) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/gl.rs:90:33 [INFO] [stderr] | [INFO] [stderr] 90 | zoom = zoom * (1.0 + zoom_step); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `zoom *= (1.0 + zoom_step)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/gl.rs:94:33 [INFO] [stderr] | [INFO] [stderr] 94 | zoom = zoom / (1.0 + zoom_step); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `zoom /= (1.0 + zoom_step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/gl.rs:101:69 [INFO] [stderr] | [INFO] [stderr] 101 | Some(glutin::VirtualKeyCode::Equals) => max_iterations = max_iterations + 10, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_iterations += 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/gl.rs:102:68 [INFO] [stderr] | [INFO] [stderr] 102 | Some(glutin::VirtualKeyCode::Minus) => max_iterations = max_iterations - 10, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_iterations -= 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 48s [INFO] running `"docker" "inspect" "ecc48635e5bca39b318945c616f8c4a11dcd8051a3c14e1b56c9fa0fc0856d2c"` [INFO] running `"docker" "rm" "-f" "ecc48635e5bca39b318945c616f8c4a11dcd8051a3c14e1b56c9fa0fc0856d2c"` [INFO] [stdout] ecc48635e5bca39b318945c616f8c4a11dcd8051a3c14e1b56c9fa0fc0856d2c