[INFO] updating cached repository roller/bazbot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/roller/bazbot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/roller/bazbot" "work/ex/clippy-test-run/sources/stable/gh/roller/bazbot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/roller/bazbot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/roller/bazbot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/roller/bazbot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/roller/bazbot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 685858410f72c354bf72dd01480ab47ce9c0cdf3 [INFO] sha for GitHub repo roller/bazbot: 685858410f72c354bf72dd01480ab47ce9c0cdf3 [INFO] validating manifest of roller/bazbot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of roller/bazbot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing roller/bazbot [INFO] finished frobbing roller/bazbot [INFO] frobbed toml for roller/bazbot written to work/ex/clippy-test-run/sources/stable/gh/roller/bazbot/Cargo.toml [INFO] started frobbing roller/bazbot [INFO] finished frobbing roller/bazbot [INFO] frobbed toml for roller/bazbot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/roller/bazbot/Cargo.toml [INFO] crate roller/bazbot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting roller/bazbot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/roller/bazbot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f1f0fc1c3faca80ecdb5dfe5c3afe2baf69fcd79bb55a8dc8f95366c4442a4df [INFO] running `"docker" "start" "-a" "f1f0fc1c3faca80ecdb5dfe5c3afe2baf69fcd79bb55a8dc8f95366c4442a4df"` [INFO] [stderr] Compiling openssl v0.9.21 [INFO] [stderr] Compiling libsqlite3-sys v0.9.0 [INFO] [stderr] Compiling openssl-sys v0.9.21 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking tokio-timer v0.1.2 [INFO] [stderr] Checking toml v0.4.5 [INFO] [stderr] Compiling serde_derive_internals v0.17.0 [INFO] [stderr] Compiling derive-error-chain v0.10.1 [INFO] [stderr] Checking tokio-mockstream v1.1.0 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Compiling serde_derive v1.0.21 [INFO] [stderr] Checking rusqlite v0.13.0 [INFO] [stderr] Checking dotenv v0.10.1 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking tokio-tls v0.1.3 [INFO] [stderr] Checking irc v0.12.5 [INFO] [stderr] Checking bazbot v0.2.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/markov_words.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/markov_words.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | filter_values: filter_values, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `filter_values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ircconn.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | server: server [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ircconn.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | server: server [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ircconn.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | host: host [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/migration.rs:66:20 [INFO] [stderr] | [INFO] [stderr] 66 | Migrator { db: db } [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/markov_words.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/markov_words.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | filter_values: filter_values, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `filter_values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ircconn.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | server: server [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ircconn.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | server: server [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ircconn.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | host: host [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/migration.rs:66:20 [INFO] [stderr] | [INFO] [stderr] 66 | Migrator { db: db } [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/markov_words.rs:155:20 [INFO] [stderr] | [INFO] [stderr] 155 | .chain(haystack.iter().map(|x| *x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `haystack.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/markov_words.rs:193:35 [INFO] [stderr] | [INFO] [stderr] 193 | pub fn from_config(optconfig: &Option<&Config>) -> WordsDb { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<&Config>` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/markov_words.rs:155:20 [INFO] [stderr] | [INFO] [stderr] 155 | .chain(haystack.iter().map(|x| *x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `haystack.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/markov_words.rs:193:35 [INFO] [stderr] | [INFO] [stderr] 193 | pub fn from_config(optconfig: &Option<&Config>) -> WordsDb { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<&Config>` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/markov_words.rs:603:40 [INFO] [stderr] | [INFO] [stderr] 603 | let filter = w.complete_id_vec(&vec![""]); [INFO] [stderr] | ^^^^^^^^^ help: you can use a slice directly: `&[""]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/markov_words.rs:611:40 [INFO] [stderr] | [INFO] [stderr] 611 | let filter = w.complete_id_vec(&vec!["","a"]); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&["","a"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/markov_words.rs:619:40 [INFO] [stderr] | [INFO] [stderr] 619 | let filter = w.complete_id_vec(&vec!["","e"]); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&["","e"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/markov_words.rs:627:40 [INFO] [stderr] | [INFO] [stderr] 627 | let filter = w.complete_id_vec(&vec!["","b"]); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&["","b"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/markov_words.rs:634:40 [INFO] [stderr] | [INFO] [stderr] 634 | let filter = w.complete_id_vec(&vec!["b","d"]); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&["b","d"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:98:48 [INFO] [stderr] | [INFO] [stderr] 98 | ("irc", Some(_)) => cmd_irc(words, cfg.expect(&format!("Couldn't load config file {}", &cfg_file))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Couldn't load config file {}", &cfg_file))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:98:48 [INFO] [stderr] | [INFO] [stderr] 98 | ("irc", Some(_)) => cmd_irc(words, cfg.expect(&format!("Couldn't load config file {}", &cfg_file))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Couldn't load config file {}", &cfg_file))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 35.56s [INFO] running `"docker" "inspect" "f1f0fc1c3faca80ecdb5dfe5c3afe2baf69fcd79bb55a8dc8f95366c4442a4df"` [INFO] running `"docker" "rm" "-f" "f1f0fc1c3faca80ecdb5dfe5c3afe2baf69fcd79bb55a8dc8f95366c4442a4df"` [INFO] [stdout] f1f0fc1c3faca80ecdb5dfe5c3afe2baf69fcd79bb55a8dc8f95366c4442a4df