[INFO] updating cached repository rogerallen/rustrt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rogerallen/rustrt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rogerallen/rustrt" "work/ex/clippy-test-run/sources/stable/gh/rogerallen/rustrt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rogerallen/rustrt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rogerallen/rustrt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rogerallen/rustrt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rogerallen/rustrt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 32dc024d6d6f22a7d15e3df1edb978f1f1052d4f [INFO] sha for GitHub repo rogerallen/rustrt: 32dc024d6d6f22a7d15e3df1edb978f1f1052d4f [INFO] validating manifest of rogerallen/rustrt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rogerallen/rustrt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rogerallen/rustrt [INFO] finished frobbing rogerallen/rustrt [INFO] frobbed toml for rogerallen/rustrt written to work/ex/clippy-test-run/sources/stable/gh/rogerallen/rustrt/Cargo.toml [INFO] started frobbing rogerallen/rustrt [INFO] finished frobbing rogerallen/rustrt [INFO] frobbed toml for rogerallen/rustrt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rogerallen/rustrt/Cargo.toml [INFO] crate rogerallen/rustrt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rogerallen/rustrt against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rogerallen/rustrt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 535e86362ff73e5131051e4bef2006db809b9d90f77f61747608124dde33f9e2 [INFO] running `"docker" "start" "-a" "535e86362ff73e5131051e4bef2006db809b9d90f77f61747608124dde33f9e2"` [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking rustrt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vec3.rs:318:5 [INFO] [stderr] | [INFO] [stderr] 318 | / assert_eq!( [INFO] [stderr] 319 | | dot(&Vec3::new(1.0, 2.0, 3.0), &Vec3::new(1.0, 2.0, 3.0)), [INFO] [stderr] 320 | | 1.0 * 1.0 + 2.0 * 2.0 + 3.0 * 3.0 [INFO] [stderr] 321 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vec3.rs:318:5 [INFO] [stderr] | [INFO] [stderr] 318 | / assert_eq!( [INFO] [stderr] 319 | | dot(&Vec3::new(1.0, 2.0, 3.0), &Vec3::new(1.0, 2.0, 3.0)), [INFO] [stderr] 320 | | 1.0 * 1.0 + 2.0 * 2.0 + 3.0 * 3.0 [INFO] [stderr] 321 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `-` [INFO] [stderr] --> src/vec3.rs:328:13 [INFO] [stderr] | [INFO] [stderr] 328 | 1.0 * 2.0 - 2.0 * 1.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `-` [INFO] [stderr] --> src/vec3.rs:329:14 [INFO] [stderr] | [INFO] [stderr] 329 | -(1.0 * 2.0 - 2.0 * 1.0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `-` [INFO] [stderr] --> src/vec3.rs:330:13 [INFO] [stderr] | [INFO] [stderr] 330 | 1.0 * 2.0 - 2.0 * 1.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:250:60 [INFO] [stderr] | [INFO] [stderr] 250 | let render_secs = render_dur.as_secs() as f64 + 1e-9 * (render_dur.subsec_nanos() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(render_dur.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:251:25 [INFO] [stderr] | [INFO] [stderr] 251 | let safe_num_rays = *num_rays.lock().unwrap() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(*num_rays.lock().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustrt`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:250:60 [INFO] [stderr] | [INFO] [stderr] 250 | let render_secs = render_dur.as_secs() as f64 + 1e-9 * (render_dur.subsec_nanos() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(render_dur.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:251:25 [INFO] [stderr] | [INFO] [stderr] 251 | let safe_num_rays = *num_rays.lock().unwrap() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(*num_rays.lock().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "535e86362ff73e5131051e4bef2006db809b9d90f77f61747608124dde33f9e2"` [INFO] running `"docker" "rm" "-f" "535e86362ff73e5131051e4bef2006db809b9d90f77f61747608124dde33f9e2"` [INFO] [stdout] 535e86362ff73e5131051e4bef2006db809b9d90f77f61747608124dde33f9e2