[INFO] updating cached repository rofrol/rust-juniper-example [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rofrol/rust-juniper-example [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rofrol/rust-juniper-example" "work/ex/clippy-test-run/sources/stable/gh/rofrol/rust-juniper-example"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rofrol/rust-juniper-example'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rofrol/rust-juniper-example" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rofrol/rust-juniper-example"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rofrol/rust-juniper-example'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 833cff255603e3597232db45b971fc2f2ad309f1 [INFO] sha for GitHub repo rofrol/rust-juniper-example: 833cff255603e3597232db45b971fc2f2ad309f1 [INFO] validating manifest of rofrol/rust-juniper-example on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rofrol/rust-juniper-example on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rofrol/rust-juniper-example [INFO] finished frobbing rofrol/rust-juniper-example [INFO] frobbed toml for rofrol/rust-juniper-example written to work/ex/clippy-test-run/sources/stable/gh/rofrol/rust-juniper-example/Cargo.toml [INFO] started frobbing rofrol/rust-juniper-example [INFO] finished frobbing rofrol/rust-juniper-example [INFO] frobbed toml for rofrol/rust-juniper-example written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rofrol/rust-juniper-example/Cargo.toml [INFO] crate rofrol/rust-juniper-example has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rofrol/rust-juniper-example against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rofrol/rust-juniper-example:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d5df61c94f4bf7d23705ad742643766249bd32a5ff66fa9ef9cddf2b07f2bef0 [INFO] running `"docker" "start" "-a" "d5df61c94f4bf7d23705ad742643766249bd32a5ff66fa9ef9cddf2b07f2bef0"` [INFO] [stderr] Checking ordermap v0.2.13 [INFO] [stderr] Checking serde_json v1.0.9 [INFO] [stderr] Compiling juniper_codegen v0.9.2 [INFO] [stderr] Checking juniper v0.9.2 [INFO] [stderr] Checking rust-juniper-example v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:275:13 [INFO] [stderr] | [INFO] [stderr] 275 | humans: humans, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `humans` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:276:13 [INFO] [stderr] | [INFO] [stderr] 276 | droids: droids, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `droids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:275:13 [INFO] [stderr] | [INFO] [stderr] 275 | humans: humans, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `humans` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:276:13 [INFO] [stderr] | [INFO] [stderr] 276 | droids: droids, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `droids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/model.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | appears_in: appears_in.iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/model.rs:178:25 [INFO] [stderr] | [INFO] [stderr] 178 | appears_in: appears_in.iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `model::Database` [INFO] [stderr] --> src/model.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | / pub fn new() -> Database { [INFO] [stderr] 187 | | let mut humans = HashMap::new(); [INFO] [stderr] 188 | | let mut droids = HashMap::new(); [INFO] [stderr] 189 | | [INFO] [stderr] ... | [INFO] [stderr] 277 | | } [INFO] [stderr] 278 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 132 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/model.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | appears_in: appears_in.iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/model.rs:178:25 [INFO] [stderr] | [INFO] [stderr] 178 | appears_in: appears_in.iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `model::Database` [INFO] [stderr] --> src/model.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | / pub fn new() -> Database { [INFO] [stderr] 187 | | let mut humans = HashMap::new(); [INFO] [stderr] 188 | | let mut droids = HashMap::new(); [INFO] [stderr] 189 | | [INFO] [stderr] ... | [INFO] [stderr] 277 | | } [INFO] [stderr] 278 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 132 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.55s [INFO] running `"docker" "inspect" "d5df61c94f4bf7d23705ad742643766249bd32a5ff66fa9ef9cddf2b07f2bef0"` [INFO] running `"docker" "rm" "-f" "d5df61c94f4bf7d23705ad742643766249bd32a5ff66fa9ef9cddf2b07f2bef0"` [INFO] [stdout] d5df61c94f4bf7d23705ad742643766249bd32a5ff66fa9ef9cddf2b07f2bef0