[INFO] updating cached repository rocketwagon/replace [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rocketwagon/replace [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rocketwagon/replace" "work/ex/clippy-test-run/sources/stable/gh/rocketwagon/replace"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rocketwagon/replace'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rocketwagon/replace" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rocketwagon/replace"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rocketwagon/replace'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4ca2c5e1ebbaa9789eae8ba0f8e454f5f10424dd [INFO] sha for GitHub repo rocketwagon/replace: 4ca2c5e1ebbaa9789eae8ba0f8e454f5f10424dd [INFO] validating manifest of rocketwagon/replace on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rocketwagon/replace on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rocketwagon/replace [INFO] finished frobbing rocketwagon/replace [INFO] frobbed toml for rocketwagon/replace written to work/ex/clippy-test-run/sources/stable/gh/rocketwagon/replace/Cargo.toml [INFO] started frobbing rocketwagon/replace [INFO] finished frobbing rocketwagon/replace [INFO] frobbed toml for rocketwagon/replace written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rocketwagon/replace/Cargo.toml [INFO] crate rocketwagon/replace has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rocketwagon/replace against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rocketwagon/replace:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e74c21048592dfc22c03c8dff69c880a57e63987911ca613303839c508fabb1c [INFO] running `"docker" "start" "-a" "e74c21048592dfc22c03c8dff69c880a57e63987911ca613303839c508fabb1c"` [INFO] [stderr] Checking replace v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / match file.read_to_string(&mut contents) { [INFO] [stderr] 62 | | Err(reason) => { [INFO] [stderr] 63 | | eprintln!("Unable to read file: {}", reason.to_string()); [INFO] [stderr] 64 | | process::exit(1); [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | Ok(_) => {} [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | if let Err(reason) = file.read_to_string(&mut contents) { [INFO] [stderr] 62 | eprintln!("Unable to read file: {}", reason.to_string()); [INFO] [stderr] 63 | process::exit(1); [INFO] [stderr] 64 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:96:59 [INFO] [stderr] | [INFO] [stderr] 96 | let kv: Vec<&str> = replacement.splitn(2, "=").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | if missing_values.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!missing_values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / match file.read_to_string(&mut contents) { [INFO] [stderr] 62 | | Err(reason) => { [INFO] [stderr] 63 | | eprintln!("Unable to read file: {}", reason.to_string()); [INFO] [stderr] 64 | | process::exit(1); [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | Ok(_) => {} [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:118:35 [INFO] [stderr] | [INFO] [stderr] 118 | let replacement = values.get(substitution.as_str()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&values[substitution.as_str()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | if let Err(reason) = file.read_to_string(&mut contents) { [INFO] [stderr] 62 | eprintln!("Unable to read file: {}", reason.to_string()); [INFO] [stderr] 63 | process::exit(1); [INFO] [stderr] 64 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:96:59 [INFO] [stderr] | [INFO] [stderr] 96 | let kv: Vec<&str> = replacement.splitn(2, "=").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | if missing_values.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!missing_values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:118:35 [INFO] [stderr] | [INFO] [stderr] 118 | let replacement = values.get(substitution.as_str()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&values[substitution.as_str()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.32s [INFO] running `"docker" "inspect" "e74c21048592dfc22c03c8dff69c880a57e63987911ca613303839c508fabb1c"` [INFO] running `"docker" "rm" "-f" "e74c21048592dfc22c03c8dff69c880a57e63987911ca613303839c508fabb1c"` [INFO] [stdout] e74c21048592dfc22c03c8dff69c880a57e63987911ca613303839c508fabb1c