[INFO] updating cached repository robtaussig/rustolution [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/robtaussig/rustolution [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/robtaussig/rustolution" "work/ex/clippy-test-run/sources/stable/gh/robtaussig/rustolution"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/robtaussig/rustolution'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/robtaussig/rustolution" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robtaussig/rustolution"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robtaussig/rustolution'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 87a5a74de5bc6c943fae6a6a752ef225bc64a856 [INFO] sha for GitHub repo robtaussig/rustolution: 87a5a74de5bc6c943fae6a6a752ef225bc64a856 [INFO] validating manifest of robtaussig/rustolution on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of robtaussig/rustolution on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing robtaussig/rustolution [INFO] finished frobbing robtaussig/rustolution [INFO] frobbed toml for robtaussig/rustolution written to work/ex/clippy-test-run/sources/stable/gh/robtaussig/rustolution/Cargo.toml [INFO] started frobbing robtaussig/rustolution [INFO] finished frobbing robtaussig/rustolution [INFO] frobbed toml for robtaussig/rustolution written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robtaussig/rustolution/Cargo.toml [INFO] crate robtaussig/rustolution has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting robtaussig/rustolution against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/robtaussig/rustolution:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] da328846c67088da520f2243a501a5123f8d466b72a7a80cb6934fb2388411a2 [INFO] running `"docker" "start" "-a" "da328846c67088da520f2243a501a5123f8d466b72a7a80cb6934fb2388411a2"` [INFO] [stderr] Checking names v0.10.0 [INFO] [stderr] Checking shapes_of_war v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/country/mod.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | country: country [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `country` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village/mod.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | country: country, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `country` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village/mod.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | village: village [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `village` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/country/mod.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | country: country [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `country` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village/mod.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | country: country, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `country` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village/mod.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | village: village [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `village` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/country/mod.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | created_environment [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/country/mod.rs:36:31 [INFO] [stderr] | [INFO] [stderr] 36 | let created_environment = Environment { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 37 | | weather: generate_weather(), [INFO] [stderr] 38 | | land: generate_land() [INFO] [stderr] 39 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/environment/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | created_weather [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/environment/mod.rs:17:27 [INFO] [stderr] | [INFO] [stderr] 17 | let created_weather = Weather { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 18 | | precipitation: generate_precipitation(), [INFO] [stderr] 19 | | temperature: generate_temperature() [INFO] [stderr] 20 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/environment/mod.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | created_land [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/environment/mod.rs:25:24 [INFO] [stderr] | [INFO] [stderr] 25 | let created_land = Land { [INFO] [stderr] | ________________________^ [INFO] [stderr] 26 | | land_size: generate_size(), [INFO] [stderr] 27 | | land_type: generate_type() [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/person/genetics.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Country` [INFO] [stderr] --> src/person/mod.rs:5:15 [INFO] [stderr] | [INFO] [stderr] 5 | use country::{Country}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `World` [INFO] [stderr] --> src/person/mod.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | use world::{World}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::error::Error` [INFO] [stderr] --> src/person/mod.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::error::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/country/mod.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | created_environment [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/country/mod.rs:36:31 [INFO] [stderr] | [INFO] [stderr] 36 | let created_environment = Environment { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 37 | | weather: generate_weather(), [INFO] [stderr] 38 | | land: generate_land() [INFO] [stderr] 39 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/environment/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | created_weather [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/environment/mod.rs:17:27 [INFO] [stderr] | [INFO] [stderr] 17 | let created_weather = Weather { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 18 | | precipitation: generate_precipitation(), [INFO] [stderr] 19 | | temperature: generate_temperature() [INFO] [stderr] 20 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/environment/mod.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | created_land [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/environment/mod.rs:25:24 [INFO] [stderr] | [INFO] [stderr] 25 | let created_land = Land { [INFO] [stderr] | ________________________^ [INFO] [stderr] 26 | | land_size: generate_size(), [INFO] [stderr] 27 | | land_type: generate_type() [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/person/genetics.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Country` [INFO] [stderr] --> src/person/mod.rs:5:15 [INFO] [stderr] | [INFO] [stderr] 5 | use country::{Country}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `World` [INFO] [stderr] --> src/person/mod.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | use world::{World}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::error::Error` [INFO] [stderr] --> src/person/mod.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::error::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `village_location` [INFO] [stderr] warning: unused variable: `village_location` [INFO] [stderr] --> src/world/mod.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | let village_location = person.village_location; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using `_village_location` instead [INFO] [stderr] --> src/world/mod.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | let village_location = person.village_location; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using `_village_location` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | let mut created_world = World { [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | let mut created_world = World { [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/world/mod.rs:49:14 [INFO] [stderr] | [INFO] [stderr] 49 | for i in 1..number_of_countries + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=number_of_countries` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/country/mod.rs:23:14 [INFO] [stderr] | [INFO] [stderr] 23 | for i in 1..number_of_villages + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=number_of_villages` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/village/mod.rs:22:14 [INFO] [stderr] | [INFO] [stderr] 22 | for i in 1..number_of_villagers + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=number_of_villagers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/world/mod.rs:49:14 [INFO] [stderr] | [INFO] [stderr] 49 | for i in 1..number_of_countries + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=number_of_countries` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/country/mod.rs:23:14 [INFO] [stderr] | [INFO] [stderr] 23 | for i in 1..number_of_villages + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=number_of_villages` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/village/mod.rs:22:14 [INFO] [stderr] | [INFO] [stderr] 22 | for i in 1..number_of_villagers + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=number_of_villagers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.14s [INFO] running `"docker" "inspect" "da328846c67088da520f2243a501a5123f8d466b72a7a80cb6934fb2388411a2"` [INFO] running `"docker" "rm" "-f" "da328846c67088da520f2243a501a5123f8d466b72a7a80cb6934fb2388411a2"` [INFO] [stdout] da328846c67088da520f2243a501a5123f8d466b72a7a80cb6934fb2388411a2