[INFO] updating cached repository robo-hamburger/recents [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/robo-hamburger/recents [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/robo-hamburger/recents" "work/ex/clippy-test-run/sources/stable/gh/robo-hamburger/recents"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/robo-hamburger/recents'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/robo-hamburger/recents" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robo-hamburger/recents"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robo-hamburger/recents'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 52ca03f7745986d1df0c51f5a5e973b614f4447f [INFO] sha for GitHub repo robo-hamburger/recents: 52ca03f7745986d1df0c51f5a5e973b614f4447f [INFO] validating manifest of robo-hamburger/recents on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of robo-hamburger/recents on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing robo-hamburger/recents [INFO] finished frobbing robo-hamburger/recents [INFO] frobbed toml for robo-hamburger/recents written to work/ex/clippy-test-run/sources/stable/gh/robo-hamburger/recents/Cargo.toml [INFO] started frobbing robo-hamburger/recents [INFO] finished frobbing robo-hamburger/recents [INFO] frobbed toml for robo-hamburger/recents written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robo-hamburger/recents/Cargo.toml [INFO] crate robo-hamburger/recents has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting robo-hamburger/recents against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/robo-hamburger/recents:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 28061f39e601c740e3dbc2861a63b3a47a1107f56b5c7316e138c49d04c31c8b [INFO] running `"docker" "start" "-a" "28061f39e601c740e3dbc2861a63b3a47a1107f56b5c7316e138c49d04c31c8b"` [INFO] [stderr] Checking recents v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / return entries.filter_map(|entry| entry.ok()).filter_map( [INFO] [stderr] 18 | | |entry| entry.metadata().ok().map_or(None, |metadata| Some((entry.path(), metadata))) [INFO] [stderr] 19 | | ).collect(); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 17 | entries.filter_map(|entry| entry.ok()).filter_map( [INFO] [stderr] 18 | |entry| entry.metadata().ok().map_or(None, |metadata| Some((entry.path(), metadata))) [INFO] [stderr] 19 | ).collect() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / return paths_with_subdir_mtime.iter().map(|&(_, _, mtime)| mtime).fold( [INFO] [stderr] 50 | | metadata.modified().ok(), [INFO] [stderr] 51 | | |mtime_a, mtime_b| std::cmp::max(mtime_a, mtime_b) [INFO] [stderr] 52 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 49 | paths_with_subdir_mtime.iter().map(|&(_, _, mtime)| mtime).fold( [INFO] [stderr] 50 | metadata.modified().ok(), [INFO] [stderr] 51 | |mtime_a, mtime_b| std::cmp::max(mtime_a, mtime_b) [INFO] [stderr] 52 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / return entries.filter_map(|entry| entry.ok()).filter_map( [INFO] [stderr] 18 | | |entry| entry.metadata().ok().map_or(None, |metadata| Some((entry.path(), metadata))) [INFO] [stderr] 19 | | ).collect(); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 17 | entries.filter_map(|entry| entry.ok()).filter_map( [INFO] [stderr] 18 | |entry| entry.metadata().ok().map_or(None, |metadata| Some((entry.path(), metadata))) [INFO] [stderr] 19 | ).collect() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / return paths_with_subdir_mtime.iter().map(|&(_, _, mtime)| mtime).fold( [INFO] [stderr] 50 | | metadata.modified().ok(), [INFO] [stderr] 51 | | |mtime_a, mtime_b| std::cmp::max(mtime_a, mtime_b) [INFO] [stderr] 52 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 49 | paths_with_subdir_mtime.iter().map(|&(_, _, mtime)| mtime).fold( [INFO] [stderr] 50 | metadata.modified().ok(), [INFO] [stderr] 51 | |mtime_a, mtime_b| std::cmp::max(mtime_a, mtime_b) [INFO] [stderr] 52 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:11:8 [INFO] [stderr] | [INFO] [stderr] 11 | if !result.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/main.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | |entry| entry.metadata().ok().map_or(None, |metadata| Some((entry.path(), metadata))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `entry.metadata().ok().and_then(|metadata| Some((entry.path(), metadata)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | |mtime_a, mtime_b| std::cmp::max(mtime_a, mtime_b) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `std::cmp::max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:56:40 [INFO] [stderr] | [INFO] [stderr] 56 | let root_path = env::args().nth(1).unwrap_or(".".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ".".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:11:8 [INFO] [stderr] | [INFO] [stderr] 11 | if !result.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/main.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | |entry| entry.metadata().ok().map_or(None, |metadata| Some((entry.path(), metadata))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `entry.metadata().ok().and_then(|metadata| Some((entry.path(), metadata)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | |mtime_a, mtime_b| std::cmp::max(mtime_a, mtime_b) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `std::cmp::max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:56:40 [INFO] [stderr] | [INFO] [stderr] 56 | let root_path = env::args().nth(1).unwrap_or(".".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ".".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.90s [INFO] running `"docker" "inspect" "28061f39e601c740e3dbc2861a63b3a47a1107f56b5c7316e138c49d04c31c8b"` [INFO] running `"docker" "rm" "-f" "28061f39e601c740e3dbc2861a63b3a47a1107f56b5c7316e138c49d04c31c8b"` [INFO] [stdout] 28061f39e601c740e3dbc2861a63b3a47a1107f56b5c7316e138c49d04c31c8b