[INFO] updating cached repository robmerrell/adventofcode2018
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/robmerrell/adventofcode2018
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/robmerrell/adventofcode2018" "work/ex/clippy-test-run/sources/stable/gh/robmerrell/adventofcode2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/robmerrell/adventofcode2018'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/robmerrell/adventofcode2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robmerrell/adventofcode2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robmerrell/adventofcode2018'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c92ca14b25a801a317d7d4a967eb1b0f5253331d
[INFO] sha for GitHub repo robmerrell/adventofcode2018: c92ca14b25a801a317d7d4a967eb1b0f5253331d
[INFO] validating manifest of robmerrell/adventofcode2018 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of robmerrell/adventofcode2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing robmerrell/adventofcode2018
[INFO] finished frobbing robmerrell/adventofcode2018
[INFO] frobbed toml for robmerrell/adventofcode2018 written to work/ex/clippy-test-run/sources/stable/gh/robmerrell/adventofcode2018/Cargo.toml
[INFO] started frobbing robmerrell/adventofcode2018
[INFO] finished frobbing robmerrell/adventofcode2018
[INFO] frobbed toml for robmerrell/adventofcode2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robmerrell/adventofcode2018/Cargo.toml
[INFO] crate robmerrell/adventofcode2018 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting robmerrell/adventofcode2018 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/robmerrell/adventofcode2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5580ac2ea4f8b55ccd0af850f5ba632124279945b3fb6df30a683e8a518f2adc
[INFO] running `"docker" "start" "-a" "5580ac2ea4f8b55ccd0af850f5ba632124279945b3fb6df30a683e8a518f2adc"`
[INFO] [stderr]     Checking edit-distance v2.0.1
[INFO] [stderr]     Checking regex v1.1.0
[INFO] [stderr]     Checking adventofcode2018 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day02.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 |     return counts.0 * counts.1;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `counts.0 * counts.1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day02.rs:65:5
[INFO] [stderr]    |
[INFO] [stderr] 65 |     return ("", "");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `("", "")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day03.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 |         return squares_used;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `squares_used`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day03.rs:67:5
[INFO] [stderr]    |
[INFO] [stderr] 67 | /     return Claim {
[INFO] [stderr] 68 | |         id: cap_as_i32(1),
[INFO] [stderr] 69 | |         x: cap_as_i32(2),
[INFO] [stderr] 70 | |         y: cap_as_i32(3),
[INFO] [stderr] 71 | |         width: cap_as_i32(4),
[INFO] [stderr] 72 | |         height: cap_as_i32(5),
[INFO] [stderr] 73 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 67 |     Claim {
[INFO] [stderr] 68 |         id: cap_as_i32(1),
[INFO] [stderr] 69 |         x: cap_as_i32(2),
[INFO] [stderr] 70 |         y: cap_as_i32(3),
[INFO] [stderr] 71 |         width: cap_as_i32(4),
[INFO] [stderr] 72 |         height: cap_as_i32(5),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day03.rs:86:5
[INFO] [stderr]    |
[INFO] [stderr] 86 |     return overlap;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `overlap`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day02.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 |     return counts.0 * counts.1;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `counts.0 * counts.1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day02.rs:65:5
[INFO] [stderr]    |
[INFO] [stderr] 65 |     return ("", "");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `("", "")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day03.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 |         return squares_used;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `squares_used`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day03.rs:67:5
[INFO] [stderr]    |
[INFO] [stderr] 67 | /     return Claim {
[INFO] [stderr] 68 | |         id: cap_as_i32(1),
[INFO] [stderr] 69 | |         x: cap_as_i32(2),
[INFO] [stderr] 70 | |         y: cap_as_i32(3),
[INFO] [stderr] 71 | |         width: cap_as_i32(4),
[INFO] [stderr] 72 | |         height: cap_as_i32(5),
[INFO] [stderr] 73 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 67 |     Claim {
[INFO] [stderr] 68 |         id: cap_as_i32(1),
[INFO] [stderr] 69 |         x: cap_as_i32(2),
[INFO] [stderr] 70 |         y: cap_as_i32(3),
[INFO] [stderr] 71 |         width: cap_as_i32(4),
[INFO] [stderr] 72 |         height: cap_as_i32(5),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day03.rs:86:5
[INFO] [stderr]    |
[INFO] [stderr] 86 |     return overlap;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `overlap`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/day02.rs:16:20
[INFO] [stderr]    |
[INFO] [stderr] 16 |       let matching = ids
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 17 | |         .0
[INFO] [stderr] 18 | |         .chars()
[INFO] [stderr] 19 | |         .into_iter()
[INFO] [stderr]    | |____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into_iter()`
[INFO] [stderr]    |
[INFO] [stderr] 16 |     let matching = ids
[INFO] [stderr] 17 |         .0
[INFO] [stderr] 18 |         .chars()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/day02.rs:20:14
[INFO] [stderr]    |
[INFO] [stderr] 20 |         .zip(ids.1.chars().into_iter())
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `ids.1.chars()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/day03.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 | /     claim1
[INFO] [stderr] 81 | |         .squares_used()
[INFO] [stderr] 82 | |         .intersection(&claim2.squares_used())
[INFO] [stderr] 83 | |         .into_iter()
[INFO] [stderr]    | |____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into_iter()`
[INFO] [stderr]    |
[INFO] [stderr] 80 |     claim1
[INFO] [stderr] 81 |         .squares_used()
[INFO] [stderr] 82 |         .intersection(&claim2.squares_used())
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/day02.rs:16:20
[INFO] [stderr]    |
[INFO] [stderr] 16 |       let matching = ids
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 17 | |         .0
[INFO] [stderr] 18 | |         .chars()
[INFO] [stderr] 19 | |         .into_iter()
[INFO] [stderr]    | |____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into_iter()`
[INFO] [stderr]    |
[INFO] [stderr] 16 |     let matching = ids
[INFO] [stderr] 17 |         .0
[INFO] [stderr] 18 |         .chars()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/day02.rs:20:14
[INFO] [stderr]    |
[INFO] [stderr] 20 |         .zip(ids.1.chars().into_iter())
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `ids.1.chars()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/day03.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 | /     claim1
[INFO] [stderr] 81 | |         .squares_used()
[INFO] [stderr] 82 | |         .intersection(&claim2.squares_used())
[INFO] [stderr] 83 | |         .into_iter()
[INFO] [stderr]    | |____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into_iter()`
[INFO] [stderr]    |
[INFO] [stderr] 80 |     claim1
[INFO] [stderr] 81 |         .squares_used()
[INFO] [stderr] 82 |         .intersection(&claim2.squares_used())
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.65s
[INFO] running `"docker" "inspect" "5580ac2ea4f8b55ccd0af850f5ba632124279945b3fb6df30a683e8a518f2adc"`
[INFO] running `"docker" "rm" "-f" "5580ac2ea4f8b55ccd0af850f5ba632124279945b3fb6df30a683e8a518f2adc"`
[INFO] [stdout] 5580ac2ea4f8b55ccd0af850f5ba632124279945b3fb6df30a683e8a518f2adc