[INFO] updating cached repository robinsonj/project_euler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/robinsonj/project_euler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/robinsonj/project_euler" "work/ex/clippy-test-run/sources/stable/gh/robinsonj/project_euler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/robinsonj/project_euler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/robinsonj/project_euler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robinsonj/project_euler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robinsonj/project_euler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ba494a87e0c8f114cd0c9654564a56559da8d47d [INFO] sha for GitHub repo robinsonj/project_euler: ba494a87e0c8f114cd0c9654564a56559da8d47d [INFO] validating manifest of robinsonj/project_euler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of robinsonj/project_euler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing robinsonj/project_euler [INFO] finished frobbing robinsonj/project_euler [INFO] frobbed toml for robinsonj/project_euler written to work/ex/clippy-test-run/sources/stable/gh/robinsonj/project_euler/Cargo.toml [INFO] started frobbing robinsonj/project_euler [INFO] finished frobbing robinsonj/project_euler [INFO] frobbed toml for robinsonj/project_euler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robinsonj/project_euler/Cargo.toml [INFO] crate robinsonj/project_euler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting robinsonj/project_euler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/robinsonj/project_euler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0df0a525d3d16ceea5f8c6a220764586074179a07f8f9e5657b754d789847008 [INFO] running `"docker" "start" "-a" "0df0a525d3d16ceea5f8c6a220764586074179a07f8f9e5657b754d789847008"` [INFO] [stderr] Checking euler_lib v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/problems/set_one.rs:164:15 [INFO] [stderr] | [INFO] [stderr] 164 | let b = 2 * d * m * n; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/problems/set_one.rs:165:15 [INFO] [stderr] | [INFO] [stderr] 165 | let c = d * (m * m + n * n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/solver/mod.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | answer: answer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `answer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/problems/set_one.rs:164:15 [INFO] [stderr] | [INFO] [stderr] 164 | let b = 2 * d * m * n; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/problems/set_one.rs:165:15 [INFO] [stderr] | [INFO] [stderr] 165 | let c = d * (m * m + n * n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/solver/mod.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | answer: answer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `answer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/problems/input.rs:1:18 [INFO] [stderr] | [INFO] [stderr] 1 | pub const P008: &'static str = r" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/problems/set_one.rs:19:3 [INFO] [stderr] | [INFO] [stderr] 19 | return sum [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `sum` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/problems/set_one.rs:40:3 [INFO] [stderr] | [INFO] [stderr] 40 | return sum [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/problems/set_one.rs:54:3 [INFO] [stderr] | [INFO] [stderr] 54 | return factor [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `factor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math/primes/mod.rs:176:32 [INFO] [stderr] | [INFO] [stderr] 176 | assert_eq!(super::is_prime(894119), true); [INFO] [stderr] | ^^^^^^ help: consider: `894_119` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math/primes/mod.rs:177:32 [INFO] [stderr] | [INFO] [stderr] 177 | assert_eq!(super::is_prime(894120), false); [INFO] [stderr] | ^^^^^^ help: consider: `894_120` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math/primes/mod.rs:182:33 [INFO] [stderr] | [INFO] [stderr] 182 | assert_eq!(super::is_prime2(894119), true); [INFO] [stderr] | ^^^^^^ help: consider: `894_119` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math/primes/mod.rs:183:33 [INFO] [stderr] | [INFO] [stderr] 183 | assert_eq!(super::is_prime2(894120), false); [INFO] [stderr] | ^^^^^^ help: consider: `894_120` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math/palindromes.rs:22:44 [INFO] [stderr] | [INFO] [stderr] 22 | assert_eq!(true, super::is_palindrome(1000000001)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/math/palindromes.rs:24:44 [INFO] [stderr] | [INFO] [stderr] 24 | assert_eq!(false, super::is_palindrome(010)); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 24 | assert_eq!(false, super::is_palindrome(10)); [INFO] [stderr] | ^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 24 | assert_eq!(false, super::is_palindrome(0o10)); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math/palindromes.rs:26:44 [INFO] [stderr] | [INFO] [stderr] 26 | assert_eq!(false, super::is_palindrome(123456789)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math/palindromes.rs:32:16 [INFO] [stderr] | [INFO] [stderr] 32 | assert_eq!(987654321, super::reverse(123456789)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `987_654_321` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math/palindromes.rs:32:42 [INFO] [stderr] | [INFO] [stderr] 32 | assert_eq!(987654321, super::reverse(123456789)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/problems/input.rs:1:18 [INFO] [stderr] | [INFO] [stderr] 1 | pub const P008: &'static str = r" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/problems/set_one.rs:19:3 [INFO] [stderr] | [INFO] [stderr] 19 | return sum [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `sum` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/problems/set_one.rs:40:3 [INFO] [stderr] | [INFO] [stderr] 40 | return sum [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/problems/set_one.rs:54:3 [INFO] [stderr] | [INFO] [stderr] 54 | return factor [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `factor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file_name` [INFO] [stderr] --> src/solver/mod.rs:39:40 [INFO] [stderr] | [INFO] [stderr] 39 | SolverFunction::FunctionWithFile(file_name, solve) => { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_file_name` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FunctionWithFile` [INFO] [stderr] --> src/solver/mod.rs:3:3 [INFO] [stderr] | [INFO] [stderr] 3 | FunctionWithFile(&'a str, fn() -> String) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/math/compute/mod.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | for factor in 1..((n as f64).sqrt()).floor() as u64 + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=((n as f64).sqrt()).floor() as u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/math/compute/mod.rs:63:7 [INFO] [stderr] | [INFO] [stderr] 63 | n = n / 2; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `n /= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/math/primes/sieve.rs:2:31 [INFO] [stderr] | [INFO] [stderr] 2 | let mut primes: Vec = (0..bound + 1).map( |n| n == 2 || n & 1 != 0).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `(0..=bound)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `math::primes::Set` [INFO] [stderr] --> src/math/primes/mod.rs:12:3 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Set { [INFO] [stderr] 13 | | Set { [INFO] [stderr] 14 | | factors: HashMap::new() [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math/primes/mod.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | set.factorize(&mut f.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `f` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/math/primes/mod.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | num_divisors *= (c + 1) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(c + 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/math/primes/mod.rs:85:32 [INFO] [stderr] | [INFO] [stderr] 85 | Occupied(ref entry) if entry.get() >= &c => {}, [INFO] [stderr] | ^^^^^^^^^^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/math/primes/mod.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | pub fn to_int(&mut self) -> u64 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/math/primes/mod.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | pub fn to_vec(&mut self) -> Vec { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/math/palindromes.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | n = n / 10; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `n /= 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/problems/set_one.rs:114:14 [INFO] [stderr] | [INFO] [stderr] 114 | .map(|n| n as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/problems/set_one.rs:127:22 [INFO] [stderr] | [INFO] [stderr] 127 | .map(|w| w.iter().fold(1u64, |acc, &next| acc * next)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/problems/set_one.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | sm = sm / 2 [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `sm /= 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> src/bin/p012.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `euler_lib`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `file_name` [INFO] [stderr] --> src/solver/mod.rs:39:40 [INFO] [stderr] | [INFO] [stderr] 39 | SolverFunction::FunctionWithFile(file_name, solve) => { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_file_name` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FunctionWithFile` [INFO] [stderr] --> src/solver/mod.rs:3:3 [INFO] [stderr] | [INFO] [stderr] 3 | FunctionWithFile(&'a str, fn() -> String) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/math/compute/mod.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | for factor in 1..((n as f64).sqrt()).floor() as u64 + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=((n as f64).sqrt()).floor() as u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/math/compute/mod.rs:63:7 [INFO] [stderr] | [INFO] [stderr] 63 | n = n / 2; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `n /= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/math/primes/sieve.rs:2:31 [INFO] [stderr] | [INFO] [stderr] 2 | let mut primes: Vec = (0..bound + 1).map( |n| n == 2 || n & 1 != 0).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `(0..=bound)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `math::primes::Set` [INFO] [stderr] --> src/math/primes/mod.rs:12:3 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Set { [INFO] [stderr] 13 | | Set { [INFO] [stderr] 14 | | factors: HashMap::new() [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math/primes/mod.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | set.factorize(&mut f.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `f` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/math/primes/mod.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | num_divisors *= (c + 1) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(c + 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/math/primes/mod.rs:85:32 [INFO] [stderr] | [INFO] [stderr] 85 | Occupied(ref entry) if entry.get() >= &c => {}, [INFO] [stderr] | ^^^^^^^^^^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/math/primes/mod.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | pub fn to_int(&mut self) -> u64 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/math/primes/mod.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | pub fn to_vec(&mut self) -> Vec { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/math/palindromes.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | n = n / 10; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `n /= 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/problems/set_one.rs:114:14 [INFO] [stderr] | [INFO] [stderr] 114 | .map(|n| n as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/problems/set_one.rs:127:22 [INFO] [stderr] | [INFO] [stderr] 127 | .map(|w| w.iter().fold(1u64, |acc, &next| acc * next)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/problems/set_one.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | sm = sm / 2 [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `sm /= 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "0df0a525d3d16ceea5f8c6a220764586074179a07f8f9e5657b754d789847008"` [INFO] running `"docker" "rm" "-f" "0df0a525d3d16ceea5f8c6a220764586074179a07f8f9e5657b754d789847008"` [INFO] [stdout] 0df0a525d3d16ceea5f8c6a220764586074179a07f8f9e5657b754d789847008