[INFO] updating cached repository robertohuertasm/aws-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/robertohuertasm/aws-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/robertohuertasm/aws-rust" "work/ex/clippy-test-run/sources/stable/gh/robertohuertasm/aws-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/robertohuertasm/aws-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/robertohuertasm/aws-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robertohuertasm/aws-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robertohuertasm/aws-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5c613698e428918ea9f6718a388c2828fe1e812d [INFO] sha for GitHub repo robertohuertasm/aws-rust: 5c613698e428918ea9f6718a388c2828fe1e812d [INFO] validating manifest of robertohuertasm/aws-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of robertohuertasm/aws-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing robertohuertasm/aws-rust [INFO] finished frobbing robertohuertasm/aws-rust [INFO] frobbed toml for robertohuertasm/aws-rust written to work/ex/clippy-test-run/sources/stable/gh/robertohuertasm/aws-rust/Cargo.toml [INFO] started frobbing robertohuertasm/aws-rust [INFO] finished frobbing robertohuertasm/aws-rust [INFO] frobbed toml for robertohuertasm/aws-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robertohuertasm/aws-rust/Cargo.toml [INFO] crate robertohuertasm/aws-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting robertohuertasm/aws-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/robertohuertasm/aws-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3dfd57589acec8c9780cec52fa76e8bf3f3485ab979e658828d8acbaac8071f8 [INFO] running `"docker" "start" "-a" "3dfd57589acec8c9780cec52fa76e8bf3f3485ab979e658828d8acbaac8071f8"` [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking simple_logger v1.0.1 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking hyper v0.12.16 [INFO] [stderr] Checking lambda_runtime_client v0.1.0 [INFO] [stderr] Checking lambda_runtime v0.1.0 [INFO] [stderr] Checking aws-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:78:44 [INFO] [stderr] | [INFO] [stderr] 78 | "" => Ok(CustomOutput::new(format!( [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 79 | | "Hello from Rust, my dear default user with empty parameter! (qs)" [INFO] [stderr] 80 | | ))), [INFO] [stderr] | |_________________^ help: consider using .to_string(): `"Hello from Rust, my dear default user with empty parameter! (qs)".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:95:50 [INFO] [stderr] | [INFO] [stderr] 95 | Some("") => Ok(CustomOutput::new(format!( [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 96 | | "Hello from Rust, my dear default user with empty parameter! (body)" [INFO] [stderr] 97 | | ))), [INFO] [stderr] | |_________________^ help: consider using .to_string(): `"Hello from Rust, my dear default user with empty parameter! (body)".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:101:39 [INFO] [stderr] | [INFO] [stderr] 101 | result.first_name.unwrap_or("".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:110:15 [INFO] [stderr] | [INFO] [stderr] 110 | body: format!("Hello from Rust, my dear default user! No parameters"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Hello from Rust, my dear default user! No parameters".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:78:44 [INFO] [stderr] | [INFO] [stderr] 78 | "" => Ok(CustomOutput::new(format!( [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 79 | | "Hello from Rust, my dear default user with empty parameter! (qs)" [INFO] [stderr] 80 | | ))), [INFO] [stderr] | |_________________^ help: consider using .to_string(): `"Hello from Rust, my dear default user with empty parameter! (qs)".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:95:50 [INFO] [stderr] | [INFO] [stderr] 95 | Some("") => Ok(CustomOutput::new(format!( [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 96 | | "Hello from Rust, my dear default user with empty parameter! (body)" [INFO] [stderr] 97 | | ))), [INFO] [stderr] | |_________________^ help: consider using .to_string(): `"Hello from Rust, my dear default user with empty parameter! (body)".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:101:39 [INFO] [stderr] | [INFO] [stderr] 101 | result.first_name.unwrap_or("".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:110:15 [INFO] [stderr] | [INFO] [stderr] 110 | body: format!("Hello from Rust, my dear default user! No parameters"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Hello from Rust, my dear default user! No parameters".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.91s [INFO] running `"docker" "inspect" "3dfd57589acec8c9780cec52fa76e8bf3f3485ab979e658828d8acbaac8071f8"` [INFO] running `"docker" "rm" "-f" "3dfd57589acec8c9780cec52fa76e8bf3f3485ab979e658828d8acbaac8071f8"` [INFO] [stdout] 3dfd57589acec8c9780cec52fa76e8bf3f3485ab979e658828d8acbaac8071f8