[INFO] updating cached repository robertmaloney/advent2017 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/robertmaloney/advent2017 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/robertmaloney/advent2017" "work/ex/clippy-test-run/sources/stable/gh/robertmaloney/advent2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/robertmaloney/advent2017'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/robertmaloney/advent2017" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robertmaloney/advent2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robertmaloney/advent2017'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 180761b70ebc080de44760d929554b0056d36220 [INFO] sha for GitHub repo robertmaloney/advent2017: 180761b70ebc080de44760d929554b0056d36220 [INFO] validating manifest of robertmaloney/advent2017 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of robertmaloney/advent2017 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing robertmaloney/advent2017 [INFO] finished frobbing robertmaloney/advent2017 [INFO] frobbed toml for robertmaloney/advent2017 written to work/ex/clippy-test-run/sources/stable/gh/robertmaloney/advent2017/Cargo.toml [INFO] started frobbing robertmaloney/advent2017 [INFO] finished frobbing robertmaloney/advent2017 [INFO] frobbed toml for robertmaloney/advent2017 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robertmaloney/advent2017/Cargo.toml [INFO] crate robertmaloney/advent2017 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting robertmaloney/advent2017 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/robertmaloney/advent2017:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ae08b90384e0fbf4ee2047428a5b70ea70461d48137e9bddd489a6c6e4489d99 [INFO] running `"docker" "start" "-a" "ae08b90384e0fbf4ee2047428a5b70ea70461d48137e9bddd489a6c6e4489d99"` [INFO] [stderr] Checking advent2017 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: function is never used: `max_min_difference` [INFO] [stderr] --> src/day_two/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | fn max_min_difference>(iter: T) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `value` [INFO] [stderr] --> src/day_three/mod.rs:6:3 [INFO] [stderr] | [INFO] [stderr] 6 | value: i32, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day_one/mod.rs:3:24 [INFO] [stderr] | [INFO] [stderr] 3 | fn parse_digits(input: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_three/mod.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | self.ring_index = self.ring_index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.ring_index += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/util/mod.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | reader.read_to_string(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: function is never used: `max_min_difference` [INFO] [stderr] --> src/day_two/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | fn max_min_difference>(iter: T) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `value` [INFO] [stderr] --> src/day_three/mod.rs:6:3 [INFO] [stderr] | [INFO] [stderr] 6 | value: i32, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day_one/mod.rs:3:24 [INFO] [stderr] | [INFO] [stderr] 3 | fn parse_digits(input: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_three/mod.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | self.ring_index = self.ring_index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.ring_index += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/util/mod.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | reader.read_to_string(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.76s [INFO] running `"docker" "inspect" "ae08b90384e0fbf4ee2047428a5b70ea70461d48137e9bddd489a6c6e4489d99"` [INFO] running `"docker" "rm" "-f" "ae08b90384e0fbf4ee2047428a5b70ea70461d48137e9bddd489a6c6e4489d99"` [INFO] [stdout] ae08b90384e0fbf4ee2047428a5b70ea70461d48137e9bddd489a6c6e4489d99