[INFO] updating cached repository robeirne/deltae [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/robeirne/deltae [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/robeirne/deltae" "work/ex/clippy-test-run/sources/stable/gh/robeirne/deltae"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/robeirne/deltae'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/robeirne/deltae" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robeirne/deltae"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robeirne/deltae'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f2f1f2aad2380545a4e01aac09f2074eafd8be40 [INFO] sha for GitHub repo robeirne/deltae: f2f1f2aad2380545a4e01aac09f2074eafd8be40 [INFO] validating manifest of robeirne/deltae on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of robeirne/deltae on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing robeirne/deltae [INFO] finished frobbing robeirne/deltae [INFO] frobbed toml for robeirne/deltae written to work/ex/clippy-test-run/sources/stable/gh/robeirne/deltae/Cargo.toml [INFO] started frobbing robeirne/deltae [INFO] finished frobbing robeirne/deltae [INFO] frobbed toml for robeirne/deltae written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robeirne/deltae/Cargo.toml [INFO] crate robeirne/deltae has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting robeirne/deltae against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/robeirne/deltae:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ae0e2290c75d38dcbdba8d2fd792e539de0d931beb2a2666e546fbd87c94f457 [INFO] running `"docker" "start" "-a" "ae0e2290c75d38dcbdba8d2fd792e539de0d931beb2a2666e546fbd87c94f457"` [INFO] [stderr] Checking deltae v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:324:27 [INFO] [stderr] | [INFO] [stderr] 324 | const CBRT_EPSILON: f64 = 0.20689655172413796; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.206_896_551_724_137_96` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:258:5 [INFO] [stderr] | [INFO] [stderr] 258 | de2000 [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:251:18 [INFO] [stderr] | [INFO] [stderr] 251 | let de2000 = ( [INFO] [stderr] | __________________^ [INFO] [stderr] 252 | | (delta_l_prime/(k_l*s_l)).powi(2) [INFO] [stderr] 253 | | + (delta_c_prime/(k_c*s_c)).powi(2) [INFO] [stderr] 254 | | + (delta_h_prime/(k_h*s_h)).powi(2) [INFO] [stderr] 255 | | + (r_t * (delta_c_prime/(k_c*s_c)) * (delta_h_prime/(k_h*s_h))) [INFO] [stderr] 256 | | ).sqrt(); [INFO] [stderr] | |____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:304:5 [INFO] [stderr] | [INFO] [stderr] 304 | decmc [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:298:17 [INFO] [stderr] | [INFO] [stderr] 298 | let decmc = ( [INFO] [stderr] | _________________^ [INFO] [stderr] 299 | | (delta_l / (tolerance_l * s_l)).powi(2) + [INFO] [stderr] 300 | | (delta_c / (tolerance_c * s_c)).powi(2) + [INFO] [stderr] 301 | | (delta_h / s_h).powi(2) [INFO] [stderr] 302 | | ).sqrt(); [INFO] [stderr] | |____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:275:10 [INFO] [stderr] | [INFO] [stderr] 275 | (0.040975 * lab0.l) / (1.0 + (0.01765 * lab0.l)) [INFO] [stderr] | ^^^^^^^^ help: consider: `0.040_975` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:324:27 [INFO] [stderr] | [INFO] [stderr] 324 | const CBRT_EPSILON: f64 = 0.20689655172413796; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.206_896_551_724_137_96` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | let val = 1.234567890; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `1.234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:258:5 [INFO] [stderr] | [INFO] [stderr] 258 | de2000 [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:251:18 [INFO] [stderr] | [INFO] [stderr] 251 | let de2000 = ( [INFO] [stderr] | __________________^ [INFO] [stderr] 252 | | (delta_l_prime/(k_l*s_l)).powi(2) [INFO] [stderr] 253 | | + (delta_c_prime/(k_c*s_c)).powi(2) [INFO] [stderr] 254 | | + (delta_h_prime/(k_h*s_h)).powi(2) [INFO] [stderr] 255 | | + (r_t * (delta_c_prime/(k_c*s_c)) * (delta_h_prime/(k_h*s_h))) [INFO] [stderr] 256 | | ).sqrt(); [INFO] [stderr] | |____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:304:5 [INFO] [stderr] | [INFO] [stderr] 304 | decmc [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:298:17 [INFO] [stderr] | [INFO] [stderr] 298 | let decmc = ( [INFO] [stderr] | _________________^ [INFO] [stderr] 299 | | (delta_l / (tolerance_l * s_l)).powi(2) + [INFO] [stderr] 300 | | (delta_c / (tolerance_c * s_c)).powi(2) + [INFO] [stderr] 301 | | (delta_h / s_h).powi(2) [INFO] [stderr] 302 | | ).sqrt(); [INFO] [stderr] | |____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:275:10 [INFO] [stderr] | [INFO] [stderr] 275 | (0.040975 * lab0.l) / (1.0 + (0.01765 * lab0.l)) [INFO] [stderr] | ^^^^^^^^ help: consider: `0.040_975` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/color.rs:266:41 [INFO] [stderr] | [INFO] [stderr] 266 | let collection: Vec<&str> = s.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/color.rs:266:41 [INFO] [stderr] | [INFO] [stderr] 266 | let collection: Vec<&str> = s.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/tests.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | assert_eq!(rnd, 1.2346); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/tests.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | assert_eq!(rnd, 1.2346); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/tests.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | assert_ne!(rnd, val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/tests.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | assert_ne!(rnd, val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/tests.rs:156:5 [INFO] [stderr] | [INFO] [stderr] 156 | assert_eq!(expected, de); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/tests.rs:156:5 [INFO] [stderr] | [INFO] [stderr] 156 | assert_eq!(expected, de); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `deltae`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "ae0e2290c75d38dcbdba8d2fd792e539de0d931beb2a2666e546fbd87c94f457"` [INFO] running `"docker" "rm" "-f" "ae0e2290c75d38dcbdba8d2fd792e539de0d931beb2a2666e546fbd87c94f457"` [INFO] [stdout] ae0e2290c75d38dcbdba8d2fd792e539de0d931beb2a2666e546fbd87c94f457