[INFO] updating cached repository roSievers/kabo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/roSievers/kabo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/roSievers/kabo" "work/ex/clippy-test-run/sources/stable/gh/roSievers/kabo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/roSievers/kabo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/roSievers/kabo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/roSievers/kabo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/roSievers/kabo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 82fc3a79ff7124989ec53c09ba02097283bc90bd [INFO] sha for GitHub repo roSievers/kabo: 82fc3a79ff7124989ec53c09ba02097283bc90bd [INFO] validating manifest of roSievers/kabo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of roSievers/kabo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing roSievers/kabo [INFO] finished frobbing roSievers/kabo [INFO] frobbed toml for roSievers/kabo written to work/ex/clippy-test-run/sources/stable/gh/roSievers/kabo/Cargo.toml [INFO] started frobbing roSievers/kabo [INFO] finished frobbing roSievers/kabo [INFO] frobbed toml for roSievers/kabo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/roSievers/kabo/Cargo.toml [INFO] crate roSievers/kabo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting roSievers/kabo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/roSievers/kabo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7a107cec5dce0cde2f84f25a3a78b2d23747a404d722e3743ad1e6ba3b362634 [INFO] running `"docker" "start" "-a" "7a107cec5dce0cde2f84f25a3a78b2d23747a404d722e3743ad1e6ba3b362634"` [INFO] [stderr] Checking kabo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | players: players, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `players` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | players: players, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `players` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `player_index` [INFO] [stderr] --> src/game.rs:260:37 [INFO] [stderr] | [INFO] [stderr] 260 | pub fn multi_replace(&mut self, player_index: u8, card_indices: Vec) -> Status { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_player_index` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `player_index` [INFO] [stderr] --> src/game.rs:266:28 [INFO] [stderr] | [INFO] [stderr] 266 | pub fn peek(&mut self, player_index: u8, card_index: u8) -> Status { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_player_index` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `card_index` [INFO] [stderr] --> src/game.rs:266:46 [INFO] [stderr] | [INFO] [stderr] 266 | pub fn peek(&mut self, player_index: u8, card_index: u8) -> Status { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_card_index` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Seen` [INFO] [stderr] --> src/game.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | / Seen { [INFO] [stderr] 172 | | player_index: u8, [INFO] [stderr] 173 | | card_index: u8, [INFO] [stderr] 174 | | card: Card, [INFO] [stderr] 175 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/game.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | let ref mut player_tuple = self.players [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 101 | let player_tuple = &mut self.players [INFO] [stderr] 102 | .get_mut(player_index as usize) [INFO] [stderr] 103 | .expect("Invalid player index."); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/game.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | let ref player = player_tuple.0; [INFO] [stderr] | ----^^^^^^^^^^------------------ help: try: `let player = &player_tuple.0;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/game.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | let ref mut peeks_left = player_tuple.1; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^------------------ help: try: `let peeks_left = &mut player_tuple.1;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/game.rs:111:20 [INFO] [stderr] | [INFO] [stderr] 111 | Ok(card.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*card` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/game.rs:119:20 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn to_game(mut self) -> Game { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/game.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | for ref player in &self.players { [INFO] [stderr] | ^^^^^^^^^^ ------------- help: try: `let player = &&self.players;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/game.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | for ref player in &self.players { [INFO] [stderr] | ^^^^^^^^^^ ------------- help: try: `let player = &&self.players;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `player_index` [INFO] [stderr] --> src/game.rs:260:37 [INFO] [stderr] | [INFO] [stderr] 260 | pub fn multi_replace(&mut self, player_index: u8, card_indices: Vec) -> Status { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_player_index` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `player_index` [INFO] [stderr] --> src/game.rs:266:28 [INFO] [stderr] | [INFO] [stderr] 266 | pub fn peek(&mut self, player_index: u8, card_index: u8) -> Status { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_player_index` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `card_index` [INFO] [stderr] --> src/game.rs:266:46 [INFO] [stderr] | [INFO] [stderr] 266 | pub fn peek(&mut self, player_index: u8, card_index: u8) -> Status { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_card_index` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Seen` [INFO] [stderr] --> src/game.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | / Seen { [INFO] [stderr] 172 | | player_index: u8, [INFO] [stderr] 173 | | card_index: u8, [INFO] [stderr] 174 | | card: Card, [INFO] [stderr] 175 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/game.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | let ref mut player_tuple = self.players [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 101 | let player_tuple = &mut self.players [INFO] [stderr] 102 | .get_mut(player_index as usize) [INFO] [stderr] 103 | .expect("Invalid player index."); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/game.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | let ref player = player_tuple.0; [INFO] [stderr] | ----^^^^^^^^^^------------------ help: try: `let player = &player_tuple.0;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/game.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | let ref mut peeks_left = player_tuple.1; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^------------------ help: try: `let peeks_left = &mut player_tuple.1;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/game.rs:111:20 [INFO] [stderr] | [INFO] [stderr] 111 | Ok(card.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*card` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/game.rs:119:20 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn to_game(mut self) -> Game { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/game.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | for ref player in &self.players { [INFO] [stderr] | ^^^^^^^^^^ ------------- help: try: `let player = &&self.players;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/game.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | for ref player in &self.players { [INFO] [stderr] | ^^^^^^^^^^ ------------- help: try: `let player = &&self.players;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.93s [INFO] running `"docker" "inspect" "7a107cec5dce0cde2f84f25a3a78b2d23747a404d722e3743ad1e6ba3b362634"` [INFO] running `"docker" "rm" "-f" "7a107cec5dce0cde2f84f25a3a78b2d23747a404d722e3743ad1e6ba3b362634"` [INFO] [stdout] 7a107cec5dce0cde2f84f25a3a78b2d23747a404d722e3743ad1e6ba3b362634