[INFO] updating cached repository rmbreak/wolserver
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/rmbreak/wolserver
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/rmbreak/wolserver" "work/ex/clippy-test-run/sources/stable/gh/rmbreak/wolserver"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rmbreak/wolserver'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/rmbreak/wolserver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rmbreak/wolserver"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rmbreak/wolserver'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5be81399112b99a6a0801471a5ad9a6d0e738365
[INFO] sha for GitHub repo rmbreak/wolserver: 5be81399112b99a6a0801471a5ad9a6d0e738365
[INFO] validating manifest of rmbreak/wolserver on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rmbreak/wolserver on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rmbreak/wolserver
[INFO] finished frobbing rmbreak/wolserver
[INFO] frobbed toml for rmbreak/wolserver written to work/ex/clippy-test-run/sources/stable/gh/rmbreak/wolserver/Cargo.toml
[INFO] started frobbing rmbreak/wolserver
[INFO] finished frobbing rmbreak/wolserver
[INFO] frobbed toml for rmbreak/wolserver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rmbreak/wolserver/Cargo.toml
[INFO] crate rmbreak/wolserver has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rmbreak/wolserver against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rmbreak/wolserver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e76828cef49ed71ff7a482f9db8f088f5409b1fcadc166338bdd2a6e87ba77d7
[INFO] running `"docker" "start" "-a" "e76828cef49ed71ff7a482f9db8f088f5409b1fcadc166338bdd2a6e87ba77d7"`
[INFO] [stderr]    Compiling redis v0.8.0
[INFO] [stderr]     Checking colored v1.6.0
[INFO] [stderr]     Checking tokio-io v0.1.6
[INFO] [stderr]     Checking toml v0.4.6
[INFO] [stderr]     Checking tokio-threadpool v0.1.4
[INFO] [stderr]     Checking chrono v0.4.2
[INFO] [stderr]     Checking fern v0.5.5
[INFO] [stderr]     Checking tokio-reactor v0.1.1
[INFO] [stderr]     Checking tokio-fs v0.1.0
[INFO] [stderr]     Checking tokio-udp v0.1.0
[INFO] [stderr]     Checking tokio-tcp v0.1.0
[INFO] [stderr]     Checking tokio v0.1.7
[INFO] [stderr]     Checking wolserver v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/servserv/mod.rs:129:13
[INFO] [stderr]     |
[INFO] [stderr] 129 |             requests: requests,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `requests`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/servserv/mod.rs:129:13
[INFO] [stderr]     |
[INFO] [stderr] 129 |             requests: requests,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `requests`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/servserv/mod.rs:77:9
[INFO] [stderr]    |
[INFO] [stderr] 77 |         return Err(format!("Invalid Request: {}", s));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Invalid Request: {}", s))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/servserv/mod.rs:104:33
[INFO] [stderr]     |
[INFO] [stderr] 104 |                                 return Ok(Async::Ready(Some(req)));
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::Ready(Some(req)))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/servserv/mod.rs:107:33
[INFO] [stderr]     |
[INFO] [stderr] 107 |                                 return Err(io::Error::new(io::ErrorKind::InvalidData, e));
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::Error::new(io::ErrorKind::InvalidData, e))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/servserv/mod.rs:112:25
[INFO] [stderr]     |
[INFO] [stderr] 112 |                         return Err(io::Error::new(io::ErrorKind::InvalidData, e));
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::Error::new(io::ErrorKind::InvalidData, e))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/servserv/mod.rs:222:13
[INFO] [stderr]     |
[INFO] [stderr] 222 |             return Ok(Async::Ready(()));
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::Ready(()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/servserv/mod.rs:224:13
[INFO] [stderr]     |
[INFO] [stderr] 224 |             return Ok(Async::NotReady);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::NotReady)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/servserv/mod.rs:77:9
[INFO] [stderr]    |
[INFO] [stderr] 77 |         return Err(format!("Invalid Request: {}", s));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Invalid Request: {}", s))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/servserv/mod.rs:104:33
[INFO] [stderr]     |
[INFO] [stderr] 104 |                                 return Ok(Async::Ready(Some(req)));
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::Ready(Some(req)))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/servserv/mod.rs:107:33
[INFO] [stderr]     |
[INFO] [stderr] 107 |                                 return Err(io::Error::new(io::ErrorKind::InvalidData, e));
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::Error::new(io::ErrorKind::InvalidData, e))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/servserv/mod.rs:112:25
[INFO] [stderr]     |
[INFO] [stderr] 112 |                         return Err(io::Error::new(io::ErrorKind::InvalidData, e));
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::Error::new(io::ErrorKind::InvalidData, e))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/servserv/mod.rs:222:13
[INFO] [stderr]     |
[INFO] [stderr] 222 |             return Ok(Async::Ready(()));
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::Ready(()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/servserv/mod.rs:224:13
[INFO] [stderr]     |
[INFO] [stderr] 224 |             return Ok(Async::NotReady);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::NotReady)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `check_connection`
[INFO] [stderr]   --> src/database/mod.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 |     pub fn check_connection(&self) -> bool {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `rate_limit`
[INFO] [stderr]   --> src/database/mod.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 |     pub fn rate_limit(&self, ip: &str, rate: usize) -> bool {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/database/mod.rs:47:33
[INFO] [stderr]    |
[INFO] [stderr] 47 |         let keys: Vec<String> = self.client.smembers("wolservers").unwrap_or(Vec::new());
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.client.smembers("wolservers").unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/servserv/mod.rs:42:12
[INFO] [stderr]    |
[INFO] [stderr] 42 |         if split_req.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!split_req.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/servserv/mod.rs:165:16
[INFO] [stderr]     |
[INFO] [stderr] 165 |             if servers.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!servers.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/servserv/mod.rs:176:12
[INFO] [stderr]     |
[INFO] [stderr] 176 |         if response.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `response.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `poll_write` doesn't need a mutable reference
[INFO] [stderr]    --> src/servserv/mod.rs:215:70
[INFO] [stderr]     |
[INFO] [stderr] 215 |             let n = try_ready!(self.requests.lines.socket.poll_write(&mut self.write_buffer));
[INFO] [stderr]     |                                                                      ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `check_connection`
[INFO] [stderr]   --> src/database/mod.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 |     pub fn check_connection(&self) -> bool {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `rate_limit`
[INFO] [stderr]   --> src/database/mod.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 |     pub fn rate_limit(&self, ip: &str, rate: usize) -> bool {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/database/mod.rs:47:33
[INFO] [stderr]    |
[INFO] [stderr] 47 |         let keys: Vec<String> = self.client.smembers("wolservers").unwrap_or(Vec::new());
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.client.smembers("wolservers").unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/servserv/mod.rs:42:12
[INFO] [stderr]    |
[INFO] [stderr] 42 |         if split_req.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!split_req.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/servserv/mod.rs:165:16
[INFO] [stderr]     |
[INFO] [stderr] 165 |             if servers.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!servers.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/servserv/mod.rs:176:12
[INFO] [stderr]     |
[INFO] [stderr] 176 |         if response.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `response.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `poll_write` doesn't need a mutable reference
[INFO] [stderr]    --> src/servserv/mod.rs:215:70
[INFO] [stderr]     |
[INFO] [stderr] 215 |             let n = try_ready!(self.requests.lines.socket.poll_write(&mut self.write_buffer));
[INFO] [stderr]     |                                                                      ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.94s
[INFO] running `"docker" "inspect" "e76828cef49ed71ff7a482f9db8f088f5409b1fcadc166338bdd2a6e87ba77d7"`
[INFO] running `"docker" "rm" "-f" "e76828cef49ed71ff7a482f9db8f088f5409b1fcadc166338bdd2a6e87ba77d7"`
[INFO] [stdout] e76828cef49ed71ff7a482f9db8f088f5409b1fcadc166338bdd2a6e87ba77d7