[INFO] updating cached repository rlupton20/yars-raytracer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rlupton20/yars-raytracer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rlupton20/yars-raytracer" "work/ex/clippy-test-run/sources/stable/gh/rlupton20/yars-raytracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rlupton20/yars-raytracer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rlupton20/yars-raytracer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rlupton20/yars-raytracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rlupton20/yars-raytracer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 88d606611dd91b24ffed565271196d0d48193d47 [INFO] sha for GitHub repo rlupton20/yars-raytracer: 88d606611dd91b24ffed565271196d0d48193d47 [INFO] validating manifest of rlupton20/yars-raytracer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rlupton20/yars-raytracer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rlupton20/yars-raytracer [INFO] finished frobbing rlupton20/yars-raytracer [INFO] frobbed toml for rlupton20/yars-raytracer written to work/ex/clippy-test-run/sources/stable/gh/rlupton20/yars-raytracer/Cargo.toml [INFO] started frobbing rlupton20/yars-raytracer [INFO] finished frobbing rlupton20/yars-raytracer [INFO] frobbed toml for rlupton20/yars-raytracer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rlupton20/yars-raytracer/Cargo.toml [INFO] crate rlupton20/yars-raytracer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rlupton20/yars-raytracer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rlupton20/yars-raytracer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0567aab5ee9fd565d311ab57cc202f3ba8626ea95402dc79cb68240e0ae44bb4 [INFO] running `"docker" "start" "-a" "0567aab5ee9fd565d311ab57cc202f3ba8626ea95402dc79cb68240e0ae44bb4"` [INFO] [stderr] Checking rustc-serialize v0.3.20 [INFO] [stderr] Compiling miniz-sys v0.1.7 [INFO] [stderr] Checking num_cpus v1.1.0 [INFO] [stderr] Checking deque v0.3.1 [INFO] [stderr] Checking enum_primitive v0.1.0 [INFO] [stderr] Checking rayon v0.5.0 [INFO] [stderr] Checking flate2 v0.2.14 [INFO] [stderr] Checking jpeg-decoder v0.1.8 [INFO] [stderr] Checking png v0.5.2 [INFO] [stderr] Checking num-bigint v0.1.35 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Checking image v0.10.3 [INFO] [stderr] Checking yars-raytracer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/vector3d/mod.rs:112:18 [INFO] [stderr] | [INFO] [stderr] 112 | let Vec3(b, _, _) = y; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/vector3d/mod.rs:113:18 [INFO] [stderr] | [INFO] [stderr] 113 | let Vec3(c, _, _) = z; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/vector3d/mod.rs:121:21 [INFO] [stderr] | [INFO] [stderr] 121 | let Vec3(_, b, _) = y; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/vector3d/mod.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | let Vec3(_, c, _) = z; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/vector3d/mod.rs:130:24 [INFO] [stderr] | [INFO] [stderr] 130 | let Vec3(_, _, b) = y; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/vector3d/mod.rs:131:24 [INFO] [stderr] | [INFO] [stderr] 131 | let Vec3(_, _, c) = z; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/vector3d/mod.rs:148:24 [INFO] [stderr] | [INFO] [stderr] 148 | let Matrix3(r, s, t) = m2; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/vector3d/mod.rs:148:27 [INFO] [stderr] | [INFO] [stderr] 148 | let Matrix3(r, s, t) = m2; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/vector3d/mod.rs:112:18 [INFO] [stderr] | [INFO] [stderr] 112 | let Vec3(b, _, _) = y; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/vector3d/mod.rs:113:18 [INFO] [stderr] | [INFO] [stderr] 113 | let Vec3(c, _, _) = z; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/vector3d/mod.rs:121:21 [INFO] [stderr] | [INFO] [stderr] 121 | let Vec3(_, b, _) = y; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/vector3d/mod.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | let Vec3(_, c, _) = z; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/vector3d/mod.rs:130:24 [INFO] [stderr] | [INFO] [stderr] 130 | let Vec3(_, _, b) = y; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/vector3d/mod.rs:131:24 [INFO] [stderr] | [INFO] [stderr] 131 | let Vec3(_, _, c) = z; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/vector3d/mod.rs:148:24 [INFO] [stderr] | [INFO] [stderr] 148 | let Matrix3(r, s, t) = m2; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/vector3d/mod.rs:148:27 [INFO] [stderr] | [INFO] [stderr] 148 | let Matrix3(r, s, t) = m2; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::vec::Vec` [INFO] [stderr] --> src/space_algebra/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::vec::Vec; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Rotation` [INFO] [stderr] --> src/space_algebra/mod.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / enum SO3Gen { [INFO] [stderr] 14 | | RotationX(f64), [INFO] [stderr] 15 | | RotationY(f64), [INFO] [stderr] 16 | | RotationZ(f64), [INFO] [stderr] 17 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `InnerProductSpace` [INFO] [stderr] --> src/ray/mod.rs:4:15 [INFO] [stderr] | [INFO] [stderr] 4 | use algebra::{InnerProductSpace, Real}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `algebra::InnerProductSpace` [INFO] [stderr] --> src/camera/mod.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use algebra::InnerProductSpace; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::f64::consts::PI` [INFO] [stderr] --> src/camera/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::f64::consts::PI; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `image::Rgb` [INFO] [stderr] --> src/materials/mod.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use image::Rgb; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `image::Rgb` [INFO] [stderr] --> src/shapes/mod.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use image::Rgb; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `shapes::Sphere` [INFO] [stderr] --> src/shade/mod.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use shapes::Sphere; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Ray`, `Shadable` [INFO] [stderr] --> src/shade/mod.rs:7:11 [INFO] [stderr] | [INFO] [stderr] 7 | use ray::{Ray, ShadeCell, Shadable}; [INFO] [stderr] | ^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Add`, `Mul` [INFO] [stderr] --> src/shade/mod.rs:8:16 [INFO] [stderr] | [INFO] [stderr] 8 | use std::ops::{Add, Mul}; [INFO] [stderr] | ^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/shade/mod.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | return PhongShader {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PhongShader {}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vector3d/mod.rs:301:21 [INFO] [stderr] | [INFO] [stderr] 301 | let tolerance = 0.00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.000_000_01` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::vec::Vec` [INFO] [stderr] --> src/space_algebra/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::vec::Vec; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Rotation` [INFO] [stderr] --> src/space_algebra/mod.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / enum SO3Gen { [INFO] [stderr] 14 | | RotationX(f64), [INFO] [stderr] 15 | | RotationY(f64), [INFO] [stderr] 16 | | RotationZ(f64), [INFO] [stderr] 17 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/space_algebra/mod.rs:95:21 [INFO] [stderr] | [INFO] [stderr] 95 | let tolerance = 0.0000001; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `InnerProductSpace` [INFO] [stderr] --> src/ray/mod.rs:4:15 [INFO] [stderr] | [INFO] [stderr] 4 | use algebra::{InnerProductSpace, Real}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/camera/mod.rs:133:21 [INFO] [stderr] | [INFO] [stderr] 133 | let tolerance = 0.00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.000_000_01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `image::Rgb` [INFO] [stderr] --> src/materials/mod.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use image::Rgb; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `image::Rgb` [INFO] [stderr] --> src/shapes/mod.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use image::Rgb; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Add`, `Mul` [INFO] [stderr] --> src/shade/mod.rs:8:16 [INFO] [stderr] | [INFO] [stderr] 8 | use std::ops::{Add, Mul}; [INFO] [stderr] | ^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/shade/mod.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | return PhongShader {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PhongShader {}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/shade/mod.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `image::Rgb` [INFO] [stderr] --> src/shade/mod.rs:187:9 [INFO] [stderr] | [INFO] [stderr] 187 | use image::Rgb; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `vector3d::Vec3` [INFO] [stderr] --> src/shade/mod.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | use vector3d::Vec3; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `algebra::Group` [INFO] [stderr] --> src/space_algebra/mod.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use algebra::Group; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/raytrace/mod.rs:21:28 [INFO] [stderr] | [INFO] [stderr] 21 | .filter(|&(i,op_col)| op_col.is_some()) [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/vector3d/mod.rs:91:14 [INFO] [stderr] | [INFO] [stderr] 91 | self + rhs [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ray/mod.rs:45:38 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn trace<'a>(&self, objects: &'a Vec>) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Box]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/ray/mod.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | objects.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/ray/mod.rs:49:26 [INFO] [stderr] | [INFO] [stderr] 49 | .zip(objects.into_iter()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera/mod.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | (self.canvas_x as f64) / (self.canvas_y as f64) * self._get_world_height() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.canvas_x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera/mod.rs:50:34 [INFO] [stderr] | [INFO] [stderr] 50 | (self.canvas_x as f64) / (self.canvas_y as f64) * self._get_world_height() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.canvas_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: comparison is useless due to type limits [INFO] [stderr] --> src/camera/mod.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | assert!(x >= 0); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_comparisons)] on by default [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/camera/mod.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | assert!(x >= 0); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, this comparison is always true [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: comparison is useless due to type limits [INFO] [stderr] --> src/camera/mod.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | assert!(y >= 0); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/camera/mod.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | assert!(y >= 0); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, this comparison is always true [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera/mod.rs:76:35 [INFO] [stderr] | [INFO] [stderr] 76 | let x_step = self.width / (self.canvas_x as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.canvas_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera/mod.rs:77:36 [INFO] [stderr] | [INFO] [stderr] 77 | let y_step = self.height / (self.canvas_y as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.canvas_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera/mod.rs:79:24 [INFO] [stderr] | [INFO] [stderr] 79 | Vec3(x_step * ((x as f64) - (self.canvas_x as f64) / 2.0), [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera/mod.rs:79:37 [INFO] [stderr] | [INFO] [stderr] 79 | Vec3(x_step * ((x as f64) - (self.canvas_x as f64) / 2.0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.canvas_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera/mod.rs:80:24 [INFO] [stderr] | [INFO] [stderr] 80 | y_step * ((y as f64) - (self.canvas_y as f64) / 2.0), [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera/mod.rs:80:37 [INFO] [stderr] | [INFO] [stderr] 80 | y_step * ((y as f64) - (self.canvas_y as f64) / 2.0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.canvas_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/shade/mod.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / fn ambient_light<'a>(s: &'a Scene) -> &'a AmbientLight { [INFO] [stderr] 40 | | &s.ambient_light [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/shade/mod.rs:93:66 [INFO] [stderr] | [INFO] [stderr] 93 | let adjust = |f: &Fn(Rgb) -> u8, a : f64| approx(a * (f(c) as f64)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(f(c))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scene/mod.rs:23:51 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn illuminates(&self, p : Vec3, objects : &Vec>) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Box]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/scene/mod.rs:26:41 [INFO] [stderr] | [INFO] [stderr] 26 | Some(ShadeCell(x,_,_,_)) => if (x - p).norm() < (p - self.position).norm() { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 27 | | false [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | else { [INFO] [stderr] 30 | | true [INFO] [stderr] 31 | | }, [INFO] [stderr] | |_____________^ help: you can reduce it to: `!((x - p).norm() < (p - self.position).norm())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/raytrace/mod.rs:46:66 [INFO] [stderr] | [INFO] [stderr] 46 | let adjust = |f: &Fn(Rgb) -> u8, a : f64| approx(a * (f(c) as f64)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(f(c))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `yars-raytracer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `algebra::Group` [INFO] [stderr] --> src/space_algebra/mod.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use algebra::Group; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/raytrace/mod.rs:21:28 [INFO] [stderr] | [INFO] [stderr] 21 | .filter(|&(i,op_col)| op_col.is_some()) [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/algebra/mod.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | assert!(x==x); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/vector3d/mod.rs:91:14 [INFO] [stderr] | [INFO] [stderr] 91 | self + rhs [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vector3d/mod.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | assert!(v.i() == 1.0); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(v.i() - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vector3d/mod.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | assert!(v.i() == 1.0); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vector3d/mod.rs:184:13 [INFO] [stderr] | [INFO] [stderr] 184 | assert!(v.j() == 2.0); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(v.j() - 2.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vector3d/mod.rs:184:13 [INFO] [stderr] | [INFO] [stderr] 184 | assert!(v.j() == 2.0); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vector3d/mod.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | assert!(v.k() == 3.0); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(v.k() - 3.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vector3d/mod.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | assert!(v.k() == 3.0); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vector3d/mod.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | assert!(v.dot(w) == expected); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(v.dot(w) - expected).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vector3d/mod.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | assert!(v.dot(w) == expected); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vector3d/mod.rs:211:13 [INFO] [stderr] | [INFO] [stderr] 211 | assert!(w.dot(v) == expected); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(w.dot(v) - expected).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vector3d/mod.rs:211:13 [INFO] [stderr] | [INFO] [stderr] 211 | assert!(w.dot(v) == expected); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vector3d/mod.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | assert!(v.norm() == expected); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(v.norm() - expected).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vector3d/mod.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | assert!(v.norm() == expected); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vector3d/mod.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | assert!(Matrix3::dist(m1, m2) == 3.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(Matrix3::dist(m1, m2) - 3.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vector3d/mod.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | assert!(Matrix3::dist(m1, m2) == 3.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: function `test_SO3_multiplication` should have a snake case name such as `test_so3_multiplication` [INFO] [stderr] --> src/space_algebra/mod.rs:94:1 [INFO] [stderr] | [INFO] [stderr] 94 | / fn test_SO3_multiplication() { [INFO] [stderr] 95 | | let tolerance = 0.0000001; [INFO] [stderr] 96 | | let SO3(m1) = SO3::rotation_x(3.0) * SO3::rotation_x(-3.0); [INFO] [stderr] 97 | | assert!(Matrix3::dist(m1, Matrix3::identity()) < tolerance); [INFO] [stderr] 98 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: function `test_SO3_multiply_vector` should have a snake case name such as `test_so3_multiply_vector` [INFO] [stderr] --> src/space_algebra/mod.rs:101:1 [INFO] [stderr] | [INFO] [stderr] 101 | / fn test_SO3_multiply_vector() { [INFO] [stderr] 102 | | let s = SO3::rotation_x(1.0); [INFO] [stderr] 103 | | let v = Vec3(1.0, 0.0, 0.0); [INFO] [stderr] 104 | | let expected = Vec3(1.0, 0.0, 0.0); [INFO] [stderr] 105 | | [INFO] [stderr] 106 | | assert!(s * v == expected); [INFO] [stderr] 107 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ray/mod.rs:45:38 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn trace<'a>(&self, objects: &'a Vec>) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Box]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/ray/mod.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | objects.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/ray/mod.rs:49:26 [INFO] [stderr] | [INFO] [stderr] 49 | .zip(objects.into_iter()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera/mod.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | (self.canvas_x as f64) / (self.canvas_y as f64) * self._get_world_height() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.canvas_x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera/mod.rs:50:34 [INFO] [stderr] | [INFO] [stderr] 50 | (self.canvas_x as f64) / (self.canvas_y as f64) * self._get_world_height() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.canvas_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: comparison is useless due to type limits [INFO] [stderr] --> src/camera/mod.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | assert!(x >= 0); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_comparisons)] on by default [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/camera/mod.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | assert!(x >= 0); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, this comparison is always true [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: comparison is useless due to type limits [INFO] [stderr] --> src/camera/mod.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | assert!(y >= 0); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/camera/mod.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | assert!(y >= 0); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, this comparison is always true [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera/mod.rs:76:35 [INFO] [stderr] | [INFO] [stderr] 76 | let x_step = self.width / (self.canvas_x as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.canvas_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera/mod.rs:77:36 [INFO] [stderr] | [INFO] [stderr] 77 | let y_step = self.height / (self.canvas_y as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.canvas_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera/mod.rs:79:24 [INFO] [stderr] | [INFO] [stderr] 79 | Vec3(x_step * ((x as f64) - (self.canvas_x as f64) / 2.0), [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera/mod.rs:79:37 [INFO] [stderr] | [INFO] [stderr] 79 | Vec3(x_step * ((x as f64) - (self.canvas_x as f64) / 2.0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.canvas_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera/mod.rs:80:24 [INFO] [stderr] | [INFO] [stderr] 80 | y_step * ((y as f64) - (self.canvas_y as f64) / 2.0), [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera/mod.rs:80:37 [INFO] [stderr] | [INFO] [stderr] 80 | y_step * ((y as f64) - (self.canvas_y as f64) / 2.0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.canvas_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/shade/mod.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / fn ambient_light<'a>(s: &'a Scene) -> &'a AmbientLight { [INFO] [stderr] 40 | | &s.ambient_light [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/shade/mod.rs:93:66 [INFO] [stderr] | [INFO] [stderr] 93 | let adjust = |f: &Fn(Rgb) -> u8, a : f64| approx(a * (f(c) as f64)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(f(c))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scene/mod.rs:23:51 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn illuminates(&self, p : Vec3, objects : &Vec>) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Box]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/scene/mod.rs:26:41 [INFO] [stderr] | [INFO] [stderr] 26 | Some(ShadeCell(x,_,_,_)) => if (x - p).norm() < (p - self.position).norm() { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 27 | | false [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | else { [INFO] [stderr] 30 | | true [INFO] [stderr] 31 | | }, [INFO] [stderr] | |_____________^ help: you can reduce it to: `!((x - p).norm() < (p - self.position).norm())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/raytrace/mod.rs:46:66 [INFO] [stderr] | [INFO] [stderr] 46 | let adjust = |f: &Fn(Rgb) -> u8, a : f64| approx(a * (f(c) as f64)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(f(c))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 11 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `yars-raytracer`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0567aab5ee9fd565d311ab57cc202f3ba8626ea95402dc79cb68240e0ae44bb4"` [INFO] running `"docker" "rm" "-f" "0567aab5ee9fd565d311ab57cc202f3ba8626ea95402dc79cb68240e0ae44bb4"` [INFO] [stdout] 0567aab5ee9fd565d311ab57cc202f3ba8626ea95402dc79cb68240e0ae44bb4