[INFO] updating cached repository rlupton20/retry [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rlupton20/retry [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rlupton20/retry" "work/ex/clippy-test-run/sources/stable/gh/rlupton20/retry"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rlupton20/retry'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rlupton20/retry" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rlupton20/retry"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rlupton20/retry'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8f3b85576fb328ab8cc88a60526d0212e911b721 [INFO] sha for GitHub repo rlupton20/retry: 8f3b85576fb328ab8cc88a60526d0212e911b721 [INFO] validating manifest of rlupton20/retry on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rlupton20/retry on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rlupton20/retry [INFO] finished frobbing rlupton20/retry [INFO] frobbed toml for rlupton20/retry written to work/ex/clippy-test-run/sources/stable/gh/rlupton20/retry/Cargo.toml [INFO] started frobbing rlupton20/retry [INFO] finished frobbing rlupton20/retry [INFO] frobbed toml for rlupton20/retry written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rlupton20/retry/Cargo.toml [INFO] crate rlupton20/retry has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rlupton20/retry against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rlupton20/retry:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 39c02060d9a3c8ab3525542546608b25b44adb9a2ab9d32732bf1ad4c10212f4 [INFO] running `"docker" "start" "-a" "39c02060d9a3c8ab3525542546608b25b44adb9a2ab9d32732bf1ad4c10212f4"` [INFO] [stderr] Compiling syn v0.15.7 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking clap-verbosity-flag v0.1.0 [INFO] [stderr] Compiling serde_derive v1.0.79 [INFO] [stderr] Checking quicli v0.3.0 [INFO] [stderr] Checking retry v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::causes': please use the 'iter_chain()' method instead [INFO] [stderr] --> src/main.rs:106:1 [INFO] [stderr] | [INFO] [stderr] 106 | / main!(|args: RetryCli, log_level: verbosity| { [INFO] [stderr] 107 | | debug!("Got arguments: {:?}", args); [INFO] [stderr] 108 | | [INFO] [stderr] 109 | | let (cmd, cmd_args) = args.command.split_at(1); [INFO] [stderr] ... | [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | }); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:82:16 [INFO] [stderr] | [INFO] [stderr] 82 | if !(self.elapsed()? < Duration::from_millis(milliseconds(t))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.elapsed()? >= Duration::from_millis(milliseconds(t))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:88:16 [INFO] [stderr] | [INFO] [stderr] 88 | if !(self.iteration + 1 < m) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.iteration + 1 >= m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::causes': please use the 'iter_chain()' method instead [INFO] [stderr] --> src/main.rs:106:1 [INFO] [stderr] | [INFO] [stderr] 106 | / main!(|args: RetryCli, log_level: verbosity| { [INFO] [stderr] 107 | | debug!("Got arguments: {:?}", args); [INFO] [stderr] 108 | | [INFO] [stderr] 109 | | let (cmd, cmd_args) = args.command.split_at(1); [INFO] [stderr] ... | [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | }); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:82:16 [INFO] [stderr] | [INFO] [stderr] 82 | if !(self.elapsed()? < Duration::from_millis(milliseconds(t))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.elapsed()? >= Duration::from_millis(milliseconds(t))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:88:16 [INFO] [stderr] | [INFO] [stderr] 88 | if !(self.iteration + 1 < m) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.iteration + 1 >= m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.84s [INFO] running `"docker" "inspect" "39c02060d9a3c8ab3525542546608b25b44adb9a2ab9d32732bf1ad4c10212f4"` [INFO] running `"docker" "rm" "-f" "39c02060d9a3c8ab3525542546608b25b44adb9a2ab9d32732bf1ad4c10212f4"` [INFO] [stdout] 39c02060d9a3c8ab3525542546608b25b44adb9a2ab9d32732bf1ad4c10212f4