[INFO] updating cached repository rjosephwright/saytshen-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rjosephwright/saytshen-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rjosephwright/saytshen-rust" "work/ex/clippy-test-run/sources/stable/gh/rjosephwright/saytshen-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rjosephwright/saytshen-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rjosephwright/saytshen-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rjosephwright/saytshen-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rjosephwright/saytshen-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f17b7f93c3d708aedb5ac53a72a4004cdbe4ff52 [INFO] sha for GitHub repo rjosephwright/saytshen-rust: f17b7f93c3d708aedb5ac53a72a4004cdbe4ff52 [INFO] validating manifest of rjosephwright/saytshen-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rjosephwright/saytshen-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rjosephwright/saytshen-rust [INFO] finished frobbing rjosephwright/saytshen-rust [INFO] frobbed toml for rjosephwright/saytshen-rust written to work/ex/clippy-test-run/sources/stable/gh/rjosephwright/saytshen-rust/Cargo.toml [INFO] started frobbing rjosephwright/saytshen-rust [INFO] finished frobbing rjosephwright/saytshen-rust [INFO] frobbed toml for rjosephwright/saytshen-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rjosephwright/saytshen-rust/Cargo.toml [INFO] crate rjosephwright/saytshen-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rjosephwright/saytshen-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rjosephwright/saytshen-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3470f764ebbb1a7cc23928fd35c41d9fc5d8364d6f1357470cb8913ff2e5af5c [INFO] running `"docker" "start" "-a" "3470f764ebbb1a7cc23928fd35c41d9fc5d8364d6f1357470cb8913ff2e5af5c"` [INFO] [stderr] Compiling quote v0.3.12 [INFO] [stderr] Checking linked-hash-map v0.3.0 [INFO] [stderr] Checking unicode-segmentation v1.0.1 [INFO] [stderr] Checking serde v0.9.5 [INFO] [stderr] Checking term_size v0.2.2 [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking clap v2.20.1 [INFO] [stderr] Compiling syn v0.11.4 [INFO] [stderr] Compiling serde_codegen_internals v0.12.1 [INFO] [stderr] Compiling serde_derive v0.9.5 [INFO] [stderr] Checking serde_yaml v0.6.0 [INFO] [stderr] Checking saytshen v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scan.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | passed: passed, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `passed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scan.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | passed: passed, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `passed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:17:21 [INFO] [stderr] | [INFO] [stderr] 17 | pub const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/scan.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | is_match [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/scan.rs:100:28 [INFO] [stderr] | [INFO] [stderr] 100 | let is_match = re.is_match(&stdout.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:17:21 [INFO] [stderr] | [INFO] [stderr] 17 | pub const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/scan.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | is_match [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/scan.rs:100:28 [INFO] [stderr] | [INFO] [stderr] 100 | let is_match = re.is_match(&stdout.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/scan.rs:83:23 [INFO] [stderr] | [INFO] [stderr] 83 | fn run_script(script: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/scan.rs:96:26 [INFO] [stderr] | [INFO] [stderr] 96 | let stdout_matches = match expect { [INFO] [stderr] | __________________________^ [INFO] [stderr] 97 | | &Some(ref pattern) => { [INFO] [stderr] 98 | | let re = regex::Regex::new(&pattern)?; [INFO] [stderr] 99 | | let stdout = String::from_utf8(output.stdout.clone())?; [INFO] [stderr] ... | [INFO] [stderr] 103 | | &None => true [INFO] [stderr] 104 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 96 | let stdout_matches = match *expect { [INFO] [stderr] 97 | Some(ref pattern) => { [INFO] [stderr] 98 | let re = regex::Regex::new(&pattern)?; [INFO] [stderr] 99 | let stdout = String::from_utf8(output.stdout.clone())?; [INFO] [stderr] 100 | let is_match = re.is_match(&stdout.to_string()); [INFO] [stderr] 101 | is_match [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scan.rs:139:31 [INFO] [stderr] | [INFO] [stderr] 139 | fn run_benchmarks(benchmarks: &Vec) -> Result, AuditError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Benchmark]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scan.rs:149:26 [INFO] [stderr] | [INFO] [stderr] 149 | fn write_report(results: &Vec, output: &str) -> Result<(), AuditError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[BenchmarkResult]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/scan.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | / match passed { [INFO] [stderr] 168 | | true => Ok(()), [INFO] [stderr] 169 | | false => Err(AuditError::NonCompliant) [INFO] [stderr] 170 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if passed { Ok(()) } else { Err(AuditError::NonCompliant) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/scan.rs:83:23 [INFO] [stderr] | [INFO] [stderr] 83 | fn run_script(script: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/scan.rs:96:26 [INFO] [stderr] | [INFO] [stderr] 96 | let stdout_matches = match expect { [INFO] [stderr] | __________________________^ [INFO] [stderr] 97 | | &Some(ref pattern) => { [INFO] [stderr] 98 | | let re = regex::Regex::new(&pattern)?; [INFO] [stderr] 99 | | let stdout = String::from_utf8(output.stdout.clone())?; [INFO] [stderr] ... | [INFO] [stderr] 103 | | &None => true [INFO] [stderr] 104 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 96 | let stdout_matches = match *expect { [INFO] [stderr] 97 | Some(ref pattern) => { [INFO] [stderr] 98 | let re = regex::Regex::new(&pattern)?; [INFO] [stderr] 99 | let stdout = String::from_utf8(output.stdout.clone())?; [INFO] [stderr] 100 | let is_match = re.is_match(&stdout.to_string()); [INFO] [stderr] 101 | is_match [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scan.rs:139:31 [INFO] [stderr] | [INFO] [stderr] 139 | fn run_benchmarks(benchmarks: &Vec) -> Result, AuditError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Benchmark]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scan.rs:149:26 [INFO] [stderr] | [INFO] [stderr] 149 | fn write_report(results: &Vec, output: &str) -> Result<(), AuditError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[BenchmarkResult]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/scan.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | / match passed { [INFO] [stderr] 168 | | true => Ok(()), [INFO] [stderr] 169 | | false => Err(AuditError::NonCompliant) [INFO] [stderr] 170 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if passed { Ok(()) } else { Err(AuditError::NonCompliant) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/bin/saytshen.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / matches.subcommand_matches("scan") [INFO] [stderr] 31 | | .and_then(|scan| { [INFO] [stderr] 32 | | // unwrap() should be safe here because clap handles [INFO] [stderr] 33 | | // missing arguments or provides default values. [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | if let Some((spec, output)) = matches.subcommand_matches("scan") [INFO] [stderr] 31 | .and_then(|scan| { [INFO] [stderr] 32 | // unwrap() should be safe here because clap handles [INFO] [stderr] 33 | // missing arguments or provides default values. [INFO] [stderr] 34 | let spec = scan.value_of("spec").unwrap(); [INFO] [stderr] 35 | let output = scan.value_of("output").unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/bin/saytshen.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / matches.subcommand_matches("scan") [INFO] [stderr] 31 | | .and_then(|scan| { [INFO] [stderr] 32 | | // unwrap() should be safe here because clap handles [INFO] [stderr] 33 | | // missing arguments or provides default values. [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | if let Some((spec, output)) = matches.subcommand_matches("scan") [INFO] [stderr] 31 | .and_then(|scan| { [INFO] [stderr] 32 | // unwrap() should be safe here because clap handles [INFO] [stderr] 33 | // missing arguments or provides default values. [INFO] [stderr] 34 | let spec = scan.value_of("spec").unwrap(); [INFO] [stderr] 35 | let output = scan.value_of("output").unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.90s [INFO] running `"docker" "inspect" "3470f764ebbb1a7cc23928fd35c41d9fc5d8364d6f1357470cb8913ff2e5af5c"` [INFO] running `"docker" "rm" "-f" "3470f764ebbb1a7cc23928fd35c41d9fc5d8364d6f1357470cb8913ff2e5af5c"` [INFO] [stdout] 3470f764ebbb1a7cc23928fd35c41d9fc5d8364d6f1357470cb8913ff2e5af5c