[INFO] updating cached repository rjmholt/advent-of-code-2018
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/rjmholt/advent-of-code-2018
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/rjmholt/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable/gh/rjmholt/advent-of-code-2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rjmholt/advent-of-code-2018'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/rjmholt/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rjmholt/advent-of-code-2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rjmholt/advent-of-code-2018'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 55d1d9cda70c72f18e92e7e54efa3315d5e758f5
[INFO] sha for GitHub repo rjmholt/advent-of-code-2018: 55d1d9cda70c72f18e92e7e54efa3315d5e758f5
[INFO] validating manifest of rjmholt/advent-of-code-2018 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rjmholt/advent-of-code-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rjmholt/advent-of-code-2018
[INFO] finished frobbing rjmholt/advent-of-code-2018
[INFO] frobbed toml for rjmholt/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable/gh/rjmholt/advent-of-code-2018/Cargo.toml
[INFO] started frobbing rjmholt/advent-of-code-2018
[INFO] finished frobbing rjmholt/advent-of-code-2018
[INFO] frobbed toml for rjmholt/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rjmholt/advent-of-code-2018/Cargo.toml
[INFO] crate rjmholt/advent-of-code-2018 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rjmholt/advent-of-code-2018 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rjmholt/advent-of-code-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 07e815530c9cae737322057066051a0d668de816a873c37384756aa17a1aa60e
[INFO] running `"docker" "start" "-a" "07e815530c9cae737322057066051a0d668de816a873c37384756aa17a1aa60e"`
[INFO] [stderr]    Compiling same-file v1.0.4
[INFO] [stderr]     Checking clap v2.32.0
[INFO] [stderr]    Compiling walkdir v2.2.7
[INFO] [stderr]    Compiling rust-embed-impl v4.2.0
[INFO] [stderr]     Checking rust-embed v4.2.0
[INFO] [stderr]     Checking advent-of-code v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/puzzles/day2.rs:38:5
[INFO] [stderr]    |
[INFO] [stderr] 38 |     return (has_pair, has_triple);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(has_pair, has_triple)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/puzzles/day2.rs:38:5
[INFO] [stderr]    |
[INFO] [stderr] 38 |     return (has_pair, has_triple);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(has_pair, has_triple)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]  --> src/puzzles/day1.rs:6:12
[INFO] [stderr]   |
[INFO] [stderr] 6 |         if line.len() == 0 {
[INFO] [stderr]   |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/puzzles/day1.rs:38:12
[INFO] [stderr]    |
[INFO] [stderr] 38 |         if line.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]  --> src/puzzles/day2.rs:8:12
[INFO] [stderr]   |
[INFO] [stderr] 8 |         if line.len() == 0 {
[INFO] [stderr]   |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/main.rs:52:48
[INFO] [stderr]    |
[INFO] [stderr] 52 |         let puzzle_fn: &fn(String) -> String = advents.get(day).unwrap();
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&advents[day]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]  --> src/puzzles/day1.rs:6:12
[INFO] [stderr]   |
[INFO] [stderr] 6 |         if line.len() == 0 {
[INFO] [stderr]   |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/puzzles/day1.rs:38:12
[INFO] [stderr]    |
[INFO] [stderr] 38 |         if line.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]  --> src/puzzles/day2.rs:8:12
[INFO] [stderr]   |
[INFO] [stderr] 8 |         if line.len() == 0 {
[INFO] [stderr]   |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/main.rs:52:48
[INFO] [stderr]    |
[INFO] [stderr] 52 |         let puzzle_fn: &fn(String) -> String = advents.get(day).unwrap();
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&advents[day]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.48s
[INFO] running `"docker" "inspect" "07e815530c9cae737322057066051a0d668de816a873c37384756aa17a1aa60e"`
[INFO] running `"docker" "rm" "-f" "07e815530c9cae737322057066051a0d668de816a873c37384756aa17a1aa60e"`
[INFO] [stdout] 07e815530c9cae737322057066051a0d668de816a873c37384756aa17a1aa60e