[INFO] updating cached repository rjaym/symbol_paths [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rjaym/symbol_paths [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rjaym/symbol_paths" "work/ex/clippy-test-run/sources/stable/gh/rjaym/symbol_paths"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rjaym/symbol_paths'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rjaym/symbol_paths" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rjaym/symbol_paths"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rjaym/symbol_paths'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e6f48b3c40f14739d49462e9958bb9ae1c216116 [INFO] sha for GitHub repo rjaym/symbol_paths: e6f48b3c40f14739d49462e9958bb9ae1c216116 [INFO] validating manifest of rjaym/symbol_paths on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rjaym/symbol_paths on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rjaym/symbol_paths [INFO] finished frobbing rjaym/symbol_paths [INFO] frobbed toml for rjaym/symbol_paths written to work/ex/clippy-test-run/sources/stable/gh/rjaym/symbol_paths/Cargo.toml [INFO] started frobbing rjaym/symbol_paths [INFO] finished frobbing rjaym/symbol_paths [INFO] frobbed toml for rjaym/symbol_paths written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rjaym/symbol_paths/Cargo.toml [INFO] crate rjaym/symbol_paths has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rjaym/symbol_paths against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rjaym/symbol_paths:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 078e84ee81c5a36443fbce1aaef6659fb8c5dc5ebe9c88dec59cd665a2657757 [INFO] running `"docker" "start" "-a" "078e84ee81c5a36443fbce1aaef6659fb8c5dc5ebe9c88dec59cd665a2657757"` [INFO] [stderr] Compiling openssl-sys v0.9.12 [INFO] [stderr] Checking unicode-bidi v0.3.2 [INFO] [stderr] Checking num_cpus v1.5.0 [INFO] [stderr] Checking mime v0.2.4 [INFO] [stderr] Checking base64 v0.6.0 [INFO] [stderr] Checking num-bigint v0.1.37 [INFO] [stderr] Checking block-buffer v0.2.0 [INFO] [stderr] Checking sha2 v0.6.0 [INFO] [stderr] Checking idna v0.1.2 [INFO] [stderr] Checking num-rational v0.1.36 [INFO] [stderr] Compiling openssl v0.9.12 [INFO] [stderr] Checking num v0.1.37 [INFO] [stderr] Checking url v1.4.0 [INFO] [stderr] Checking hyper v0.10.10 [INFO] [stderr] Checking native-tls v0.1.2 [INFO] [stderr] Checking hyper-native-tls v0.2.2 [INFO] [stderr] Checking symbol_paths v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/arbitrager.rs:42:27 [INFO] [stderr] | [INFO] [stderr] 42 | let split = key.split("_"); [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/arbitrager.rs:49:10 [INFO] [stderr] | [INFO] [stderr] 49 | .or_insert( // no duplicates [INFO] [stderr] | __________^ [INFO] [stderr] 50 | | HashSet::new() [INFO] [stderr] 51 | | ) [INFO] [stderr] | |_________^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/arbitrager.rs:64:10 [INFO] [stderr] | [INFO] [stderr] 64 | .or_insert( // no duplicates [INFO] [stderr] | __________^ [INFO] [stderr] 65 | | HashSet::new() [INFO] [stderr] 66 | | ) [INFO] [stderr] | |_________^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utility.rs:10:33 [INFO] [stderr] | [INFO] [stderr] 10 | (elapsed.as_secs() * 1_000) + (elapsed.subsec_nanos() / 1_000_000) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_nanos() / 1_000_000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/utility.rs:10:33 [INFO] [stderr] | [INFO] [stderr] 10 | (elapsed.as_secs() * 1_000) + (elapsed.subsec_nanos() / 1_000_000) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `elapsed.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/arbitrager.rs:42:27 [INFO] [stderr] | [INFO] [stderr] 42 | let split = key.split("_"); [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/arbitrager.rs:49:10 [INFO] [stderr] | [INFO] [stderr] 49 | .or_insert( // no duplicates [INFO] [stderr] | __________^ [INFO] [stderr] 50 | | HashSet::new() [INFO] [stderr] 51 | | ) [INFO] [stderr] | |_________^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/arbitrager.rs:64:10 [INFO] [stderr] | [INFO] [stderr] 64 | .or_insert( // no duplicates [INFO] [stderr] | __________^ [INFO] [stderr] 65 | | HashSet::new() [INFO] [stderr] 66 | | ) [INFO] [stderr] | |_________^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utility.rs:10:33 [INFO] [stderr] | [INFO] [stderr] 10 | (elapsed.as_secs() * 1_000) + (elapsed.subsec_nanos() / 1_000_000) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_nanos() / 1_000_000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/utility.rs:10:33 [INFO] [stderr] | [INFO] [stderr] 10 | (elapsed.as_secs() * 1_000) + (elapsed.subsec_nanos() / 1_000_000) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `elapsed.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.54s [INFO] running `"docker" "inspect" "078e84ee81c5a36443fbce1aaef6659fb8c5dc5ebe9c88dec59cd665a2657757"` [INFO] running `"docker" "rm" "-f" "078e84ee81c5a36443fbce1aaef6659fb8c5dc5ebe9c88dec59cd665a2657757"` [INFO] [stdout] 078e84ee81c5a36443fbce1aaef6659fb8c5dc5ebe9c88dec59cd665a2657757