[INFO] updating cached repository ridhoq/nuke [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ridhoq/nuke [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ridhoq/nuke" "work/ex/clippy-test-run/sources/stable/gh/ridhoq/nuke"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ridhoq/nuke'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ridhoq/nuke" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ridhoq/nuke"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ridhoq/nuke'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 47a6f4d42d7bfd51231fa885fda469f1088a5f4a [INFO] sha for GitHub repo ridhoq/nuke: 47a6f4d42d7bfd51231fa885fda469f1088a5f4a [INFO] validating manifest of ridhoq/nuke on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ridhoq/nuke on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ridhoq/nuke [INFO] finished frobbing ridhoq/nuke [INFO] frobbed toml for ridhoq/nuke written to work/ex/clippy-test-run/sources/stable/gh/ridhoq/nuke/Cargo.toml [INFO] started frobbing ridhoq/nuke [INFO] finished frobbing ridhoq/nuke [INFO] frobbed toml for ridhoq/nuke written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ridhoq/nuke/Cargo.toml [INFO] crate ridhoq/nuke has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ridhoq/nuke against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ridhoq/nuke:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 701b6a157a7f0084da764d2eb7610e9d9a01ec3ddfc34463f606acbc37e102a0 [INFO] running `"docker" "start" "-a" "701b6a157a7f0084da764d2eb7610e9d9a01ec3ddfc34463f606acbc37e102a0"` [INFO] [stderr] Checking dunce v0.1.1 [INFO] [stderr] Compiling syn v0.15.9 [INFO] [stderr] Compiling structopt-derive v0.2.11 [INFO] [stderr] Checking structopt v0.2.11 [INFO] [stderr] Checking nuke v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | for d in (0..max_depth + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `(0..=max_depth)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | for d in (0..max_depth + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `(0..=max_depth)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> tests/nuke.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | root [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> tests/nuke.rs:20:16 [INFO] [stderr] | [INFO] [stderr] 20 | let root = PathBuf::from(format!("./tmp-{}/", get_rand_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> tests/nuke.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | fn run_test(test: T) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.44s [INFO] running `"docker" "inspect" "701b6a157a7f0084da764d2eb7610e9d9a01ec3ddfc34463f606acbc37e102a0"` [INFO] running `"docker" "rm" "-f" "701b6a157a7f0084da764d2eb7610e9d9a01ec3ddfc34463f606acbc37e102a0"` [INFO] [stdout] 701b6a157a7f0084da764d2eb7610e9d9a01ec3ddfc34463f606acbc37e102a0