[INFO] updating cached repository rickardenglund/DrawCards [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rickardenglund/DrawCards [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rickardenglund/DrawCards" "work/ex/clippy-test-run/sources/stable/gh/rickardenglund/DrawCards"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rickardenglund/DrawCards'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rickardenglund/DrawCards" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rickardenglund/DrawCards"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rickardenglund/DrawCards'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] eef851f2b9892380bb102f7b94073553af877ba3 [INFO] sha for GitHub repo rickardenglund/DrawCards: eef851f2b9892380bb102f7b94073553af877ba3 [INFO] validating manifest of rickardenglund/DrawCards on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rickardenglund/DrawCards on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rickardenglund/DrawCards [INFO] finished frobbing rickardenglund/DrawCards [INFO] frobbed toml for rickardenglund/DrawCards written to work/ex/clippy-test-run/sources/stable/gh/rickardenglund/DrawCards/Cargo.toml [INFO] started frobbing rickardenglund/DrawCards [INFO] finished frobbing rickardenglund/DrawCards [INFO] frobbed toml for rickardenglund/DrawCards written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rickardenglund/DrawCards/Cargo.toml [INFO] crate rickardenglund/DrawCards has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rickardenglund/DrawCards against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rickardenglund/DrawCards:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d1f12e5a2fcb281351e51546e2dbe205c50ffeda46e9c0340fd3dcbfd7ad9e52 [INFO] running `"docker" "start" "-a" "d1f12e5a2fcb281351e51546e2dbe205c50ffeda46e9c0340fd3dcbfd7ad9e52"` [INFO] [stderr] Checking drakort v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | return (red_wins, n_stopped); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(red_wins, n_stopped)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:81:23 [INFO] [stderr] | [INFO] [stderr] 81 | Color::Red => return (Color::Red, stopped), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Color::Red, stopped)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | Color::Black => return (Color::Black, stopped), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Color::Black, stopped)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | return (red_wins, n_stopped); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(red_wins, n_stopped)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:81:23 [INFO] [stderr] | [INFO] [stderr] 81 | Color::Red => return (Color::Red, stopped), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Color::Red, stopped)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | Color::Black => return (Color::Black, stopped), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Color::Black, stopped)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `deck`. [INFO] [stderr] --> src/main.rs:66:14 [INFO] [stderr] | [INFO] [stderr] 66 | for i in 0..deck.len()-1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 66 | for in deck.iter().take(deck.len()-1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:108:28 [INFO] [stderr] | [INFO] [stderr] 108 | fn count(clr: Color, list: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Color]` [INFO] [stderr] warning: the loop variable `i` is only used to index `deck`. [INFO] [stderr] --> src/main.rs:66:14 [INFO] [stderr] | [INFO] [stderr] 66 | for i in 0..deck.len()-1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 66 | for in deck.iter().take(deck.len()-1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:108:28 [INFO] [stderr] | [INFO] [stderr] 108 | fn count(clr: Color, list: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Color]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.99s [INFO] running `"docker" "inspect" "d1f12e5a2fcb281351e51546e2dbe205c50ffeda46e9c0340fd3dcbfd7ad9e52"` [INFO] running `"docker" "rm" "-f" "d1f12e5a2fcb281351e51546e2dbe205c50ffeda46e9c0340fd3dcbfd7ad9e52"` [INFO] [stdout] d1f12e5a2fcb281351e51546e2dbe205c50ffeda46e9c0340fd3dcbfd7ad9e52