[INFO] updating cached repository richo/tinfo.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/richo/tinfo.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/richo/tinfo.rs" "work/ex/clippy-test-run/sources/stable/gh/richo/tinfo.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/richo/tinfo.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/richo/tinfo.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/richo/tinfo.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/richo/tinfo.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6b6350ea61d747d2f2ab8292bf4891fc9f8157de [INFO] sha for GitHub repo richo/tinfo.rs: 6b6350ea61d747d2f2ab8292bf4891fc9f8157de [INFO] validating manifest of richo/tinfo.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of richo/tinfo.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing richo/tinfo.rs [INFO] finished frobbing richo/tinfo.rs [INFO] frobbed toml for richo/tinfo.rs written to work/ex/clippy-test-run/sources/stable/gh/richo/tinfo.rs/Cargo.toml [INFO] started frobbing richo/tinfo.rs [INFO] finished frobbing richo/tinfo.rs [INFO] frobbed toml for richo/tinfo.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/richo/tinfo.rs/Cargo.toml [INFO] crate richo/tinfo.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting richo/tinfo.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/richo/tinfo.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 67dcafedec11caf55bfcbf22a2214bceb3d20411fb5f778e81446213cd572fff [INFO] running `"docker" "start" "-a" "67dcafedec11caf55bfcbf22a2214bceb3d20411fb5f778e81446213cd572fff"` [INFO] [stderr] Checking tinfo v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:20:39 [INFO] [stderr] | [INFO] [stderr] 20 | Tab { name: name.to_string(), number: number, panes: panes } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:20:55 [INFO] [stderr] | [INFO] [stderr] 20 | Tab { name: name.to_string(), number: number, panes: panes } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `panes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | Window { tabs: tabs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tabs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | attached: attached, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `attached` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:20:39 [INFO] [stderr] | [INFO] [stderr] 20 | Tab { name: name.to_string(), number: number, panes: panes } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:20:55 [INFO] [stderr] | [INFO] [stderr] 20 | Tab { name: name.to_string(), number: number, panes: panes } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `panes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | Window { tabs: tabs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tabs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | attached: attached, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `attached` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return self.tabs.len() == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.tabs.len() == 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | return windows; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `windows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | return out; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return self.tabs.len() == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.tabs.len() == 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | return windows; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `windows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | return out; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | / for tab in window.tabs.iter() { [INFO] [stderr] 107 | | process::Command::new("tmux").arg("move-window").arg("-s") [INFO] [stderr] 108 | | .arg(format!("{}:{}", idx, tab.number)).spawn().unwrap(); [INFO] [stderr] 109 | | return; [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / for (idx, _) in self.iter() { [INFO] [stderr] 120 | | process::Command::new("tmux").arg("attach-session").arg("-t") [INFO] [stderr] 121 | | .arg(format!("{}", idx)).spawn().unwrap(); [INFO] [stderr] 122 | | return; [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | / match tab.name.find(searchterm) { [INFO] [stderr] 132 | | Some(_) => { [INFO] [stderr] 133 | | let newtab: Tab = (*tab).clone(); [INFO] [stderr] 134 | | _win.push(newtab); [INFO] [stderr] 135 | | }, [INFO] [stderr] 136 | | None => {}, [INFO] [stderr] 137 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 131 | if let Some(_) = tab.name.find(searchterm) { [INFO] [stderr] 132 | let newtab: Tab = (*tab).clone(); [INFO] [stderr] 133 | _win.push(newtab); [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | / for tab in window.tabs.iter() { [INFO] [stderr] 107 | | process::Command::new("tmux").arg("move-window").arg("-s") [INFO] [stderr] 108 | | .arg(format!("{}:{}", idx, tab.number)).spawn().unwrap(); [INFO] [stderr] 109 | | return; [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / for (idx, _) in self.iter() { [INFO] [stderr] 120 | | process::Command::new("tmux").arg("attach-session").arg("-t") [INFO] [stderr] 121 | | .arg(format!("{}", idx)).spawn().unwrap(); [INFO] [stderr] 122 | | return; [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tinfo`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | / match tab.name.find(searchterm) { [INFO] [stderr] 132 | | Some(_) => { [INFO] [stderr] 133 | | let newtab: Tab = (*tab).clone(); [INFO] [stderr] 134 | | _win.push(newtab); [INFO] [stderr] 135 | | }, [INFO] [stderr] 136 | | None => {}, [INFO] [stderr] 137 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 131 | if let Some(_) = tab.name.find(searchterm) { [INFO] [stderr] 132 | let newtab: Tab = (*tab).clone(); [INFO] [stderr] 133 | _win.push(newtab); [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tinfo`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "67dcafedec11caf55bfcbf22a2214bceb3d20411fb5f778e81446213cd572fff"` [INFO] running `"docker" "rm" "-f" "67dcafedec11caf55bfcbf22a2214bceb3d20411fb5f778e81446213cd572fff"` [INFO] [stdout] 67dcafedec11caf55bfcbf22a2214bceb3d20411fb5f778e81446213cd572fff