[INFO] updating cached repository richiejp/openqa-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/richiejp/openqa-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/richiejp/openqa-rs" "work/ex/clippy-test-run/sources/stable/gh/richiejp/openqa-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/richiejp/openqa-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/richiejp/openqa-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/richiejp/openqa-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/richiejp/openqa-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fd583d610c15bc5bf1fb5e7df28ca9cb3f079e2d [INFO] sha for GitHub repo richiejp/openqa-rs: fd583d610c15bc5bf1fb5e7df28ca9cb3f079e2d [INFO] validating manifest of richiejp/openqa-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of richiejp/openqa-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing richiejp/openqa-rs [INFO] finished frobbing richiejp/openqa-rs [INFO] frobbed toml for richiejp/openqa-rs written to work/ex/clippy-test-run/sources/stable/gh/richiejp/openqa-rs/Cargo.toml [INFO] started frobbing richiejp/openqa-rs [INFO] finished frobbing richiejp/openqa-rs [INFO] frobbed toml for richiejp/openqa-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/richiejp/openqa-rs/Cargo.toml [INFO] crate richiejp/openqa-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting richiejp/openqa-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/richiejp/openqa-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 77abe661e8c537b60df0da6d484e68065305b5a05c2ea8bf5aa109806a45fd62 [INFO] running `"docker" "start" "-a" "77abe661e8c537b60df0da6d484e68065305b5a05c2ea8bf5aa109806a45fd62"` [INFO] [stderr] Checking tokio-executor v0.1.2 [INFO] [stderr] Compiling openssl-sys v0.9.33 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking crossbeam-epoch v0.4.3 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Checking http v0.1.7 [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking tokio-timer v0.2.4 [INFO] [stderr] Checking crossbeam-deque v0.3.1 [INFO] [stderr] Checking tokio-threadpool v0.1.5 [INFO] [stderr] Checking tokio-reactor v0.1.2 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-fs v0.1.2 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking h2 v0.1.10 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.12.6 [INFO] [stderr] Checking hyper-tls v0.2.1 [INFO] [stderr] Checking openqa v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:152:28 [INFO] [stderr] | [INFO] [stderr] 152 | path_buf = std::env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:152:28 [INFO] [stderr] | [INFO] [stderr] 152 | path_buf = std::env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/user_agent.rs:86:20 [INFO] [stderr] | [INFO] [stderr] 86 | }).map_err(|e| Error::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/user_agent.rs:86:20 [INFO] [stderr] | [INFO] [stderr] 86 | }).map_err(|e| Error::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:153:22 [INFO] [stderr] | [INFO] [stderr] 153 | .ok_or(format_err!("Can't get home dir"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Can't get home dir"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:153:22 [INFO] [stderr] | [INFO] [stderr] 153 | .ok_or(format_err!("Can't get home dir"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Can't get home dir"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 31.81s [INFO] running `"docker" "inspect" "77abe661e8c537b60df0da6d484e68065305b5a05c2ea8bf5aa109806a45fd62"` [INFO] running `"docker" "rm" "-f" "77abe661e8c537b60df0da6d484e68065305b5a05c2ea8bf5aa109806a45fd62"` [INFO] [stdout] 77abe661e8c537b60df0da6d484e68065305b5a05c2ea8bf5aa109806a45fd62