[INFO] updating cached repository richardjennings/rust_4 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/richardjennings/rust_4 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/richardjennings/rust_4" "work/ex/clippy-test-run/sources/stable/gh/richardjennings/rust_4"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/richardjennings/rust_4'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/richardjennings/rust_4" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/richardjennings/rust_4"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/richardjennings/rust_4'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c6459ba924b42db7d11a110c0441b3153190727a [INFO] sha for GitHub repo richardjennings/rust_4: c6459ba924b42db7d11a110c0441b3153190727a [INFO] validating manifest of richardjennings/rust_4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of richardjennings/rust_4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing richardjennings/rust_4 [INFO] finished frobbing richardjennings/rust_4 [INFO] frobbed toml for richardjennings/rust_4 written to work/ex/clippy-test-run/sources/stable/gh/richardjennings/rust_4/Cargo.toml [INFO] started frobbing richardjennings/rust_4 [INFO] finished frobbing richardjennings/rust_4 [INFO] frobbed toml for richardjennings/rust_4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/richardjennings/rust_4/Cargo.toml [INFO] crate richardjennings/rust_4 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting richardjennings/rust_4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/richardjennings/rust_4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 074b5ddc1c2d2914b3312ea163fa8b89501fe3ec5fac949b1121d181b81e71d1 [INFO] running `"docker" "start" "-a" "074b5ddc1c2d2914b3312ea163fa8b89501fe3ec5fac949b1121d181b81e71d1"` [INFO] [stderr] Checking rust_4 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:197:5 [INFO] [stderr] | [INFO] [stderr] 197 | some_string [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:196:23 [INFO] [stderr] | [INFO] [stderr] 196 | let some_string = String::from("hello"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:197:5 [INFO] [stderr] | [INFO] [stderr] 197 | some_string [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:196:23 [INFO] [stderr] | [INFO] [stderr] 196 | let some_string = String::from("hello"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.56s [INFO] running `"docker" "inspect" "074b5ddc1c2d2914b3312ea163fa8b89501fe3ec5fac949b1121d181b81e71d1"` [INFO] running `"docker" "rm" "-f" "074b5ddc1c2d2914b3312ea163fa8b89501fe3ec5fac949b1121d181b81e71d1"` [INFO] [stdout] 074b5ddc1c2d2914b3312ea163fa8b89501fe3ec5fac949b1121d181b81e71d1