[INFO] updating cached repository richardfontana/mimosa [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/richardfontana/mimosa [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/richardfontana/mimosa" "work/ex/clippy-test-run/sources/stable/gh/richardfontana/mimosa"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/richardfontana/mimosa'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/richardfontana/mimosa" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/richardfontana/mimosa"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/richardfontana/mimosa'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 32fba1b14952aeba1cdf9d7897ea6c9cea022e70 [INFO] sha for GitHub repo richardfontana/mimosa: 32fba1b14952aeba1cdf9d7897ea6c9cea022e70 [INFO] validating manifest of richardfontana/mimosa on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of richardfontana/mimosa on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing richardfontana/mimosa [INFO] finished frobbing richardfontana/mimosa [INFO] frobbed toml for richardfontana/mimosa written to work/ex/clippy-test-run/sources/stable/gh/richardfontana/mimosa/Cargo.toml [INFO] started frobbing richardfontana/mimosa [INFO] finished frobbing richardfontana/mimosa [INFO] frobbed toml for richardfontana/mimosa written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/richardfontana/mimosa/Cargo.toml [INFO] crate richardfontana/mimosa has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting richardfontana/mimosa against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/richardfontana/mimosa:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ef03ded752eb1d4de3c68697d4f07bc44b9716e749b359674c9fd0723d427fc5 [INFO] running `"docker" "start" "-a" "ef03ded752eb1d4de3c68697d4f07bc44b9716e749b359674c9fd0723d427fc5"` [INFO] [stderr] Checking mimosa v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/main.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | let v = reduce_to_comments(s, delims); [INFO] [stderr] | ^ help: consider using `_v` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/main.rs:55:23 [INFO] [stderr] | [INFO] [stderr] 55 | fn reduce_to_comments(s: String, ds: CommentDelimiters) -> Vec { [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ds` [INFO] [stderr] --> src/main.rs:55:34 [INFO] [stderr] | [INFO] [stderr] 55 | fn reduce_to_comments(s: String, ds: CommentDelimiters) -> Vec { [INFO] [stderr] | ^^ help: consider using `_ds` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `begin` [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | begin: &'static str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `end` [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | end: &'static str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / match f { [INFO] [stderr] 23 | | Ok(mut fr) => { [INFO] [stderr] 24 | | let mut s = String::new(); [INFO] [stderr] 25 | | fr.read_to_string(&mut s); [INFO] [stderr] ... | [INFO] [stderr] 29 | | Err(_) => { }, [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | if let Ok(mut fr) = f { [INFO] [stderr] 23 | let mut s = String::new(); [INFO] [stderr] 24 | fr.read_to_string(&mut s); [INFO] [stderr] 25 | let v = reduce_to_comments(s, delims); [INFO] [stderr] 26 | println!("_"); [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | fr.read_to_string(&mut s); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | fn lang_guess(s: &String) -> Lang { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/main.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | let v = reduce_to_comments(s, delims); [INFO] [stderr] | ^ help: consider using `_v` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/main.rs:55:23 [INFO] [stderr] | [INFO] [stderr] 55 | fn reduce_to_comments(s: String, ds: CommentDelimiters) -> Vec { [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ds` [INFO] [stderr] --> src/main.rs:55:34 [INFO] [stderr] | [INFO] [stderr] 55 | fn reduce_to_comments(s: String, ds: CommentDelimiters) -> Vec { [INFO] [stderr] | ^^ help: consider using `_ds` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `begin` [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | begin: &'static str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `end` [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | end: &'static str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / match f { [INFO] [stderr] 23 | | Ok(mut fr) => { [INFO] [stderr] 24 | | let mut s = String::new(); [INFO] [stderr] 25 | | fr.read_to_string(&mut s); [INFO] [stderr] ... | [INFO] [stderr] 29 | | Err(_) => { }, [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | if let Ok(mut fr) = f { [INFO] [stderr] 23 | let mut s = String::new(); [INFO] [stderr] 24 | fr.read_to_string(&mut s); [INFO] [stderr] 25 | let v = reduce_to_comments(s, delims); [INFO] [stderr] 26 | println!("_"); [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | fr.read_to_string(&mut s); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | fn lang_guess(s: &String) -> Lang { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.32s [INFO] running `"docker" "inspect" "ef03ded752eb1d4de3c68697d4f07bc44b9716e749b359674c9fd0723d427fc5"` [INFO] running `"docker" "rm" "-f" "ef03ded752eb1d4de3c68697d4f07bc44b9716e749b359674c9fd0723d427fc5"` [INFO] [stdout] ef03ded752eb1d4de3c68697d4f07bc44b9716e749b359674c9fd0723d427fc5