[INFO] updating cached repository richardbrodie/manta_ray
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/richardbrodie/manta_ray
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/richardbrodie/manta_ray" "work/ex/clippy-test-run/sources/stable/gh/richardbrodie/manta_ray"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/richardbrodie/manta_ray'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/richardbrodie/manta_ray" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/richardbrodie/manta_ray"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/richardbrodie/manta_ray'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c708a01f46eab0328c7933e78af5242d90473d71
[INFO] sha for GitHub repo richardbrodie/manta_ray: c708a01f46eab0328c7933e78af5242d90473d71
[INFO] validating manifest of richardbrodie/manta_ray on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of richardbrodie/manta_ray on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing richardbrodie/manta_ray
[INFO] finished frobbing richardbrodie/manta_ray
[INFO] frobbed toml for richardbrodie/manta_ray written to work/ex/clippy-test-run/sources/stable/gh/richardbrodie/manta_ray/Cargo.toml
[INFO] started frobbing richardbrodie/manta_ray
[INFO] finished frobbing richardbrodie/manta_ray
[INFO] frobbed toml for richardbrodie/manta_ray written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/richardbrodie/manta_ray/Cargo.toml
[INFO] crate richardbrodie/manta_ray has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting richardbrodie/manta_ray against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/richardbrodie/manta_ray:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 51e85cddeba63699760147826334729f921ed2bd8835af9383f779374c76c34f
[INFO] running `"docker" "start" "-a" "51e85cddeba63699760147826334729f921ed2bd8835af9383f779374c76c34f"`
[INFO] [stderr]     Checking serde_yaml v0.8.5
[INFO] [stderr]     Checking crossbeam-epoch v0.3.1
[INFO] [stderr]    Compiling num-derive v0.2.3
[INFO] [stderr]     Checking crossbeam-deque v0.2.0
[INFO] [stderr]     Checking rayon-core v1.4.1
[INFO] [stderr]     Checking rayon v1.0.2
[INFO] [stderr]     Checking tiff v0.2.1
[INFO] [stderr]     Checking jpeg-decoder v0.1.15
[INFO] [stderr]     Checking image v0.20.0
[INFO] [stderr]     Checking manta_ray v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/world.rs:43:7
[INFO] [stderr]    |
[INFO] [stderr] 43 |       direction: direction,
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/world.rs:43:7
[INFO] [stderr]    |
[INFO] [stderr] 43 |       direction: direction,
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/colour.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 | /     return Colour {
[INFO] [stderr] 22 | |       red: 0.0,
[INFO] [stderr] 23 | |       green: 0.0,
[INFO] [stderr] 24 | |       blue: 0.0,
[INFO] [stderr] 25 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 21 |     Colour {
[INFO] [stderr] 22 |       red: 0.0,
[INFO] [stderr] 23 |       green: 0.0,
[INFO] [stderr] 24 |       blue: 0.0,
[INFO] [stderr] 25 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/geometry.rs:45:5
[INFO] [stderr]    |
[INFO] [stderr] 45 |     return Some(distance);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(distance)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/geometry.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 |     return p.normal(&self.center);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `p.normal(&self.center)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/geometry.rs:68:5
[INFO] [stderr]    |
[INFO] [stderr] 68 |     return None;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/geometry.rs:71:5
[INFO] [stderr]    |
[INFO] [stderr] 71 |     return -self.normal;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `-self.normal`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/point.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     return vec.normalise();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `vec.normalise()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vector.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     return Vector {
[INFO] [stderr] 13 | |       x: self.x * inv_len,
[INFO] [stderr] 14 | |       y: self.y * inv_len,
[INFO] [stderr] 15 | |       z: self.z * inv_len,
[INFO] [stderr] 16 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 12 |     Vector {
[INFO] [stderr] 13 |       x: self.x * inv_len,
[INFO] [stderr] 14 |       y: self.y * inv_len,
[INFO] [stderr] 15 |       z: self.z * inv_len,
[INFO] [stderr] 16 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vector.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 |     return self.x * rhs.x + self.y * rhs.y + self.z * rhs.z;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x * rhs.x + self.y * rhs.y + self.z * rhs.z`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vector.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 |     return direction - (normal * direction.dot(normal) * 2f64);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `direction - (normal * direction.dot(normal) * 2f64)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/world.rs:57:5
[INFO] [stderr]    |
[INFO] [stderr] 57 |     return self.origin + a;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.origin + a`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:91:7
[INFO] [stderr]    |
[INFO] [stderr] 91 |       return colour;
[INFO] [stderr]    |       ^^^^^^^^^^^^^^ help: remove `return` as shown: `colour`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:93:13
[INFO] [stderr]    |
[INFO] [stderr] 93 |     None => return colour,
[INFO] [stderr]    |             ^^^^^^^^^^^^^ help: remove `return` as shown: `colour`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:102:3
[INFO] [stderr]     |
[INFO] [stderr] 102 | /   return match scene.trace(&shadow_ray) {
[INFO] [stderr] 103 | |     None => true,
[INFO] [stderr] 104 | |     Some(ref sh_intersect) => sh_intersect.distance > light.distance(&phit),
[INFO] [stderr] 105 | |   };
[INFO] [stderr]     | |____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 102 |   match scene.trace(&shadow_ray) {
[INFO] [stderr] 103 |     None => true,
[INFO] [stderr] 104 |     Some(ref sh_intersect) => sh_intersect.distance > light.distance(&phit),
[INFO] [stderr] 105 |   }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:118:3
[INFO] [stderr]     |
[INFO] [stderr] 118 |   return light_colour;
[INFO] [stderr]     |   ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `light_colour`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:133:3
[INFO] [stderr]     |
[INFO] [stderr] 133 |   return colour;
[INFO] [stderr]     |   ^^^^^^^^^^^^^^ help: remove `return` as shown: `colour`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:152:3
[INFO] [stderr]     |
[INFO] [stderr] 152 |   return colour;
[INFO] [stderr]     |   ^^^^^^^^^^^^^^ help: remove `return` as shown: `colour`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/colour.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 | /     return Colour {
[INFO] [stderr] 22 | |       red: 0.0,
[INFO] [stderr] 23 | |       green: 0.0,
[INFO] [stderr] 24 | |       blue: 0.0,
[INFO] [stderr] 25 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 21 |     Colour {
[INFO] [stderr] 22 |       red: 0.0,
[INFO] [stderr] 23 |       green: 0.0,
[INFO] [stderr] 24 |       blue: 0.0,
[INFO] [stderr] 25 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/geometry.rs:45:5
[INFO] [stderr]    |
[INFO] [stderr] 45 |     return Some(distance);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(distance)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/geometry.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 |     return p.normal(&self.center);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `p.normal(&self.center)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/geometry.rs:68:5
[INFO] [stderr]    |
[INFO] [stderr] 68 |     return None;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/geometry.rs:71:5
[INFO] [stderr]    |
[INFO] [stderr] 71 |     return -self.normal;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `-self.normal`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/point.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     return vec.normalise();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `vec.normalise()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vector.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     return Vector {
[INFO] [stderr] 13 | |       x: self.x * inv_len,
[INFO] [stderr] 14 | |       y: self.y * inv_len,
[INFO] [stderr] 15 | |       z: self.z * inv_len,
[INFO] [stderr] 16 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 12 |     Vector {
[INFO] [stderr] 13 |       x: self.x * inv_len,
[INFO] [stderr] 14 |       y: self.y * inv_len,
[INFO] [stderr] 15 |       z: self.z * inv_len,
[INFO] [stderr] 16 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vector.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 |     return self.x * rhs.x + self.y * rhs.y + self.z * rhs.z;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x * rhs.x + self.y * rhs.y + self.z * rhs.z`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vector.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 |     return direction - (normal * direction.dot(normal) * 2f64);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `direction - (normal * direction.dot(normal) * 2f64)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/world.rs:57:5
[INFO] [stderr]    |
[INFO] [stderr] 57 |     return self.origin + a;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.origin + a`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:91:7
[INFO] [stderr]    |
[INFO] [stderr] 91 |       return colour;
[INFO] [stderr]    |       ^^^^^^^^^^^^^^ help: remove `return` as shown: `colour`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:93:13
[INFO] [stderr]    |
[INFO] [stderr] 93 |     None => return colour,
[INFO] [stderr]    |             ^^^^^^^^^^^^^ help: remove `return` as shown: `colour`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:102:3
[INFO] [stderr]     |
[INFO] [stderr] 102 | /   return match scene.trace(&shadow_ray) {
[INFO] [stderr] 103 | |     None => true,
[INFO] [stderr] 104 | |     Some(ref sh_intersect) => sh_intersect.distance > light.distance(&phit),
[INFO] [stderr] 105 | |   };
[INFO] [stderr]     | |____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 102 |   match scene.trace(&shadow_ray) {
[INFO] [stderr] 103 |     None => true,
[INFO] [stderr] 104 |     Some(ref sh_intersect) => sh_intersect.distance > light.distance(&phit),
[INFO] [stderr] 105 |   }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:118:3
[INFO] [stderr]     |
[INFO] [stderr] 118 |   return light_colour;
[INFO] [stderr]     |   ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `light_colour`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:133:3
[INFO] [stderr]     |
[INFO] [stderr] 133 |   return colour;
[INFO] [stderr]     |   ^^^^^^^^^^^^^^ help: remove `return` as shown: `colour`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:152:3
[INFO] [stderr]     |
[INFO] [stderr] 152 |   return colour;
[INFO] [stderr]     |   ^^^^^^^^^^^^^^ help: remove `return` as shown: `colour`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/world.rs:31:23
[INFO] [stderr]    |
[INFO] [stderr] 31 |   pub fn create_prime<'a>(&self, x: u32, y: u32, scene: &Scene) -> Ray {
[INFO] [stderr]    |                       ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/world.rs:33:24
[INFO] [stderr]    |
[INFO] [stderr] 33 |     let aspect_ratio = (scene.width as f64) / (scene.height as f64);
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.width)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/world.rs:33:47
[INFO] [stderr]    |
[INFO] [stderr] 33 |     let aspect_ratio = (scene.width as f64) / (scene.height as f64);
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.height)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/world.rs:34:23
[INFO] [stderr]    |
[INFO] [stderr] 34 |     let sensor_x = (((x as f64 + 0.5) / scene.width as f64) * 2.0 - 1.0) * aspect_ratio * fov;
[INFO] [stderr]    |                       ^^^^^^^^ help: try: `f64::from(x)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/world.rs:34:41
[INFO] [stderr]    |
[INFO] [stderr] 34 |     let sensor_x = (((x as f64 + 0.5) / scene.width as f64) * 2.0 - 1.0) * aspect_ratio * fov;
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.width)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/world.rs:35:28
[INFO] [stderr]    |
[INFO] [stderr] 35 |     let sensor_y = 1.0 - ((y as f64 + 0.5) / scene.height as f64) * 2.0 * fov;
[INFO] [stderr]    |                            ^^^^^^^^ help: try: `f64::from(y)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/world.rs:35:46
[INFO] [stderr]    |
[INFO] [stderr] 35 |     let sensor_y = 1.0 - ((y as f64 + 0.5) / scene.height as f64) * 2.0 * fov;
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.height)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/world.rs:66:3
[INFO] [stderr]    |
[INFO] [stderr] 66 | /   pub fn new<'b>(d: f64, o: &'b Geometry) -> Intersection {
[INFO] [stderr] 67 | |     Intersection {
[INFO] [stderr] 68 | |       distance: d,
[INFO] [stderr] 69 | |       object: o,
[INFO] [stderr] 70 | |     }
[INFO] [stderr] 71 | |   }
[INFO] [stderr]    | |___^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:74:11
[INFO] [stderr]    |
[INFO] [stderr] 74 | /           if let &SurfaceType::Reflective(reflectivity) = intersection.object.surface() {
[INFO] [stderr] 75 | |             let reflected_light = reflective_light(&normal, &ray.direction, &phit, scene, depth);
[INFO] [stderr] 76 | |             colour = colour + (reflected_light * reflectivity);
[INFO] [stderr] 77 | |             let specular_light = phong_lighting(
[INFO] [stderr] ...  |
[INFO] [stderr] 87 | |             colour = colour + specular_light;
[INFO] [stderr] 88 | |           }
[INFO] [stderr]    | |___________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 74 |           if let SurfaceType::Reflective(reflectivity) = *intersection.object.surface() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:148:24
[INFO] [stderr]     |
[INFO] [stderr] 148 |     let pow = dot.powf(obj.shininess() as f64);
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(obj.shininess())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/world.rs:31:23
[INFO] [stderr]    |
[INFO] [stderr] 31 |   pub fn create_prime<'a>(&self, x: u32, y: u32, scene: &Scene) -> Ray {
[INFO] [stderr]    |                       ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/world.rs:33:24
[INFO] [stderr]    |
[INFO] [stderr] 33 |     let aspect_ratio = (scene.width as f64) / (scene.height as f64);
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.width)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/world.rs:33:47
[INFO] [stderr]    |
[INFO] [stderr] 33 |     let aspect_ratio = (scene.width as f64) / (scene.height as f64);
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.height)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/world.rs:34:23
[INFO] [stderr]    |
[INFO] [stderr] 34 |     let sensor_x = (((x as f64 + 0.5) / scene.width as f64) * 2.0 - 1.0) * aspect_ratio * fov;
[INFO] [stderr]    |                       ^^^^^^^^ help: try: `f64::from(x)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/world.rs:34:41
[INFO] [stderr]    |
[INFO] [stderr] 34 |     let sensor_x = (((x as f64 + 0.5) / scene.width as f64) * 2.0 - 1.0) * aspect_ratio * fov;
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.width)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/world.rs:35:28
[INFO] [stderr]    |
[INFO] [stderr] 35 |     let sensor_y = 1.0 - ((y as f64 + 0.5) / scene.height as f64) * 2.0 * fov;
[INFO] [stderr]    |                            ^^^^^^^^ help: try: `f64::from(y)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/world.rs:35:46
[INFO] [stderr]    |
[INFO] [stderr] 35 |     let sensor_y = 1.0 - ((y as f64 + 0.5) / scene.height as f64) * 2.0 * fov;
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.height)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/world.rs:66:3
[INFO] [stderr]    |
[INFO] [stderr] 66 | /   pub fn new<'b>(d: f64, o: &'b Geometry) -> Intersection {
[INFO] [stderr] 67 | |     Intersection {
[INFO] [stderr] 68 | |       distance: d,
[INFO] [stderr] 69 | |       object: o,
[INFO] [stderr] 70 | |     }
[INFO] [stderr] 71 | |   }
[INFO] [stderr]    | |___^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:74:11
[INFO] [stderr]    |
[INFO] [stderr] 74 | /           if let &SurfaceType::Reflective(reflectivity) = intersection.object.surface() {
[INFO] [stderr] 75 | |             let reflected_light = reflective_light(&normal, &ray.direction, &phit, scene, depth);
[INFO] [stderr] 76 | |             colour = colour + (reflected_light * reflectivity);
[INFO] [stderr] 77 | |             let specular_light = phong_lighting(
[INFO] [stderr] ...  |
[INFO] [stderr] 87 | |             colour = colour + specular_light;
[INFO] [stderr] 88 | |           }
[INFO] [stderr]    | |___________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 74 |           if let SurfaceType::Reflective(reflectivity) = *intersection.object.surface() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:148:24
[INFO] [stderr]     |
[INFO] [stderr] 148 |     let pow = dot.powf(obj.shininess() as f64);
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(obj.shininess())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 23.10s
[INFO] running `"docker" "inspect" "51e85cddeba63699760147826334729f921ed2bd8835af9383f779374c76c34f"`
[INFO] running `"docker" "rm" "-f" "51e85cddeba63699760147826334729f921ed2bd8835af9383f779374c76c34f"`
[INFO] [stdout] 51e85cddeba63699760147826334729f921ed2bd8835af9383f779374c76c34f