[INFO] updating cached repository richardanaya/pig
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/richardanaya/pig
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/richardanaya/pig" "work/ex/clippy-test-run/sources/stable/gh/richardanaya/pig"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/richardanaya/pig'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/richardanaya/pig" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/richardanaya/pig"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/richardanaya/pig'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 6c2198db226c0d63ca406dc91ced841cd209c019
[INFO] sha for GitHub repo richardanaya/pig: 6c2198db226c0d63ca406dc91ced841cd209c019
[INFO] validating manifest of richardanaya/pig on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of richardanaya/pig on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing richardanaya/pig
[INFO] finished frobbing richardanaya/pig
[INFO] frobbed toml for richardanaya/pig written to work/ex/clippy-test-run/sources/stable/gh/richardanaya/pig/Cargo.toml
[INFO] started frobbing richardanaya/pig
[INFO] finished frobbing richardanaya/pig
[INFO] frobbed toml for richardanaya/pig written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/richardanaya/pig/Cargo.toml
[INFO] crate richardanaya/pig has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting richardanaya/pig against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/richardanaya/pig:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 417cc5c9433a98efb5acd63905b5f86b2aaea6a8ad030aa34cbc6f61fc11ae19
[INFO] running `"docker" "start" "-a" "417cc5c9433a98efb5acd63905b5f86b2aaea6a8ad030aa34cbc6f61fc11ae19"`
[INFO] [stderr]    Compiling syn v0.15.8
[INFO] [stderr]     Checking colored v1.6.1
[INFO] [stderr]     Checking digest v0.7.6
[INFO] [stderr]     Checking sha2 v0.7.1
[INFO] [stderr]     Checking hmac v0.5.0
[INFO] [stderr]     Checking postgres-protocol v0.3.2
[INFO] [stderr]     Checking postgres-shared v0.4.2
[INFO] [stderr]     Checking postgres v0.15.2
[INFO] [stderr]    Compiling structopt-derive v0.2.11
[INFO] [stderr]    Compiling serde_derive v1.0.79
[INFO] [stderr]     Checking structopt v0.2.11
[INFO] [stderr]     Checking clap-verbosity-flag v0.1.0
[INFO] [stderr]     Checking quicli v0.3.1
[INFO] [stderr]     Checking pig v0.0.4 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:393:33
[INFO] [stderr]     |
[INFO] [stderr] 393 |                                 date: date,
[INFO] [stderr]     |                                 ^^^^^^^^^^ help: replace it with: `date`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:393:33
[INFO] [stderr]     |
[INFO] [stderr] 393 |                                 date: date,
[INFO] [stderr]     |                                 ^^^^^^^^^^ help: replace it with: `date`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:139:20
[INFO] [stderr]     |
[INFO] [stderr] 139 |         Some(s) => return Ok(s.to_owned()),
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s.to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:142:28
[INFO] [stderr]     |
[INFO] [stderr] 142 |                 Some(e) => return Ok(e.into_string().unwrap()),
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(e.into_string().unwrap())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:143:22
[INFO] [stderr]     |
[INFO] [stderr] 143 |                 _ => return Err(format_err!("No connection string found, try -c <connection string> or set the environment variable PIG_CONNECTION_STRING.")),
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("No connection string found, try -c <connection string> or set the environment variable PIG_CONNECTION_STRING."))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:139:20
[INFO] [stderr]     |
[INFO] [stderr] 139 |         Some(s) => return Ok(s.to_owned()),
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s.to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:142:28
[INFO] [stderr]     |
[INFO] [stderr] 142 |                 Some(e) => return Ok(e.into_string().unwrap()),
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(e.into_string().unwrap())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:143:22
[INFO] [stderr]     |
[INFO] [stderr] 143 |                 _ => return Err(format_err!("No connection string found, try -c <connection string> or set the environment variable PIG_CONNECTION_STRING.")),
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("No connection string found, try -c <connection string> or set the environment variable PIG_CONNECTION_STRING."))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:209:8
[INFO] [stderr]     |
[INFO] [stderr] 209 |     if project_files.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!project_files.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:277:8
[INFO] [stderr]     |
[INFO] [stderr] 277 |     if project_files.len() != 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!project_files.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:314:60
[INFO] [stderr]     |
[INFO] [stderr] 314 | fn is_current_migration_unused(conn:&Connection, file_name:&String) -> Result<bool>{
[INFO] [stderr]     |                                                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:209:8
[INFO] [stderr]     |
[INFO] [stderr] 209 |     if project_files.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!project_files.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:408:8
[INFO] [stderr]     |
[INFO] [stderr] 408 |     if project_files.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `project_files.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:277:8
[INFO] [stderr]     |
[INFO] [stderr] 277 |     if project_files.len() != 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!project_files.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:314:60
[INFO] [stderr]     |
[INFO] [stderr] 314 | fn is_current_migration_unused(conn:&Connection, file_name:&String) -> Result<bool>{
[INFO] [stderr]     |                                                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:408:8
[INFO] [stderr]     |
[INFO] [stderr] 408 |     if project_files.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `project_files.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 22.02s
[INFO] running `"docker" "inspect" "417cc5c9433a98efb5acd63905b5f86b2aaea6a8ad030aa34cbc6f61fc11ae19"`
[INFO] running `"docker" "rm" "-f" "417cc5c9433a98efb5acd63905b5f86b2aaea6a8ad030aa34cbc6f61fc11ae19"`
[INFO] [stdout] 417cc5c9433a98efb5acd63905b5f86b2aaea6a8ad030aa34cbc6f61fc11ae19