[INFO] updating cached repository rhysormond/emu8
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/rhysormond/emu8
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/rhysormond/emu8" "work/ex/clippy-test-run/sources/stable/gh/rhysormond/emu8"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rhysormond/emu8'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/rhysormond/emu8" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rhysormond/emu8"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rhysormond/emu8'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a7daaa2b9b627da82e0b5717a14812a47370dd2d
[INFO] sha for GitHub repo rhysormond/emu8: a7daaa2b9b627da82e0b5717a14812a47370dd2d
[INFO] validating manifest of rhysormond/emu8 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rhysormond/emu8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rhysormond/emu8
[INFO] finished frobbing rhysormond/emu8
[INFO] frobbed toml for rhysormond/emu8 written to work/ex/clippy-test-run/sources/stable/gh/rhysormond/emu8/Cargo.toml
[INFO] started frobbing rhysormond/emu8
[INFO] finished frobbing rhysormond/emu8
[INFO] frobbed toml for rhysormond/emu8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rhysormond/emu8/Cargo.toml
[INFO] crate rhysormond/emu8 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rhysormond/emu8 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rhysormond/emu8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 979b0ad50d1d409f1ca2c05550d926c1f6c1bf97dbca76aa401cd696ce7f53bc
[INFO] running `"docker" "start" "-a" "979b0ad50d1d409f1ca2c05550d926c1f6c1bf97dbca76aa401cd696ce7f53bc"`
[INFO] [stderr]    Compiling sdl2-sys v0.31.0
[INFO] [stderr]     Checking sdl2 v0.31.0
[INFO] [stderr]     Checking emu8 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead
[INFO] [stderr]   --> src/chip8.rs:88:9
[INFO] [stderr]    |
[INFO] [stderr] 88 |         file.read(&mut self.memory[0x200..]).unwrap();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:159:70
[INFO] [stderr]     |
[INFO] [stderr] 159 |         let sprite_data = &self.memory[(self.i as usize)..((self.i + n as u16) as usize)];
[INFO] [stderr]     |                                                                      ^^^^^^^^ help: try: `u16::from(n)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/chip8.rs:171:21
[INFO] [stderr]     |
[INFO] [stderr] 171 |                 let ref mut pixel = self.frame_buffer[pixel_x][pixel_y];
[INFO] [stderr]     |                 ----^^^^^^^^^^^^^--------------------------------------- help: try: `let pixel = &mut self.frame_buffer[pixel_x][pixel_y];`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:311:27
[INFO] [stderr]     |
[INFO] [stderr] 311 |                 self.pc = self.v[0x0] as u16 + addr;
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[0x0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:355:27
[INFO] [stderr]     |
[INFO] [stderr] 355 |                 self.i += self.v[x as usize] as u16;
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[x as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:361:26
[INFO] [stderr]     |
[INFO] [stderr] 361 |                 self.i = self.v[x as usize] as u16 * 5;
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[x as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:376:56
[INFO] [stderr]     |
[INFO] [stderr] 376 |                 self.memory[self.i as usize..(self.i + x as u16) as usize]
[INFO] [stderr]     |                                                        ^^^^^^^^ help: try: `u16::from(x)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:383:78
[INFO] [stderr]     |
[INFO] [stderr] 383 |                     .copy_from_slice(&self.memory[self.i as usize..(self.i + x as u16) as usize]);
[INFO] [stderr]     |                                                                              ^^^^^^^^ help: try: `u16::from(x)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is used to index `frame`
[INFO] [stderr]   --> src/display.rs:89:18
[INFO] [stderr]    |
[INFO] [stderr] 89 |         for x in 0..self.width {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 89 |         for (x, <item>) in frame.iter().enumerate().take(self.width) {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `emu8`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead
[INFO] [stderr]   --> src/chip8.rs:88:9
[INFO] [stderr]    |
[INFO] [stderr] 88 |         file.read(&mut self.memory[0x200..]).unwrap();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:159:70
[INFO] [stderr]     |
[INFO] [stderr] 159 |         let sprite_data = &self.memory[(self.i as usize)..((self.i + n as u16) as usize)];
[INFO] [stderr]     |                                                                      ^^^^^^^^ help: try: `u16::from(n)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/chip8.rs:171:21
[INFO] [stderr]     |
[INFO] [stderr] 171 |                 let ref mut pixel = self.frame_buffer[pixel_x][pixel_y];
[INFO] [stderr]     |                 ----^^^^^^^^^^^^^--------------------------------------- help: try: `let pixel = &mut self.frame_buffer[pixel_x][pixel_y];`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:311:27
[INFO] [stderr]     |
[INFO] [stderr] 311 |                 self.pc = self.v[0x0] as u16 + addr;
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[0x0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:355:27
[INFO] [stderr]     |
[INFO] [stderr] 355 |                 self.i += self.v[x as usize] as u16;
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[x as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:361:26
[INFO] [stderr]     |
[INFO] [stderr] 361 |                 self.i = self.v[x as usize] as u16 * 5;
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[x as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:376:56
[INFO] [stderr]     |
[INFO] [stderr] 376 |                 self.memory[self.i as usize..(self.i + x as u16) as usize]
[INFO] [stderr]     |                                                        ^^^^^^^^ help: try: `u16::from(x)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:383:78
[INFO] [stderr]     |
[INFO] [stderr] 383 |                     .copy_from_slice(&self.memory[self.i as usize..(self.i + x as u16) as usize]);
[INFO] [stderr]     |                                                                              ^^^^^^^^ help: try: `u16::from(x)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is used to index `frame`
[INFO] [stderr]   --> src/display.rs:89:18
[INFO] [stderr]    |
[INFO] [stderr] 89 |         for x in 0..self.width {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 89 |         for (x, <item>) in frame.iter().enumerate().take(self.width) {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `emu8`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "979b0ad50d1d409f1ca2c05550d926c1f6c1bf97dbca76aa401cd696ce7f53bc"`
[INFO] running `"docker" "rm" "-f" "979b0ad50d1d409f1ca2c05550d926c1f6c1bf97dbca76aa401cd696ce7f53bc"`
[INFO] [stdout] 979b0ad50d1d409f1ca2c05550d926c1f6c1bf97dbca76aa401cd696ce7f53bc