[INFO] updating cached repository rhysd/git-brws [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rhysd/git-brws [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rhysd/git-brws" "work/ex/clippy-test-run/sources/stable/gh/rhysd/git-brws"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rhysd/git-brws'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rhysd/git-brws" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rhysd/git-brws"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rhysd/git-brws'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bbc20a65a0acfdecd21fa7d05b6066382099a5e4 [INFO] sha for GitHub repo rhysd/git-brws: bbc20a65a0acfdecd21fa7d05b6066382099a5e4 [INFO] validating manifest of rhysd/git-brws on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rhysd/git-brws on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rhysd/git-brws [INFO] finished frobbing rhysd/git-brws [INFO] frobbed toml for rhysd/git-brws written to work/ex/clippy-test-run/sources/stable/gh/rhysd/git-brws/Cargo.toml [INFO] started frobbing rhysd/git-brws [INFO] finished frobbing rhysd/git-brws [INFO] frobbed toml for rhysd/git-brws written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rhysd/git-brws/Cargo.toml [INFO] crate rhysd/git-brws has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rhysd/git-brws against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rhysd/git-brws:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5bb2df0350521dd6e86ee4d8fb9b54968ffe6463dbe292d3120930fd4394bf84 [INFO] running `"docker" "start" "-a" "5bb2df0350521dd6e86ee4d8fb9b54968ffe6463dbe292d3120930fd4394bf84"` [INFO] [stderr] Compiling cargo-husky v1.2.1 [INFO] [stderr] Checking open v1.2.2 [INFO] [stderr] Checking git-brws v0.6.1 (/opt/crater/workdir) [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/test/page.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | relative_path: _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/test/page.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | hash: _, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `FileOrDir { line, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/test/argv.rs:16:32 [INFO] [stderr] | [INFO] [stderr] 16 | .any(|u| o.repo == u.to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `*u` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's keys [INFO] [stderr] --> src/test/envvar.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | for (key, _) in &envs { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 23 | for key in envs.keys() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.98s [INFO] running `"docker" "inspect" "5bb2df0350521dd6e86ee4d8fb9b54968ffe6463dbe292d3120930fd4394bf84"` [INFO] running `"docker" "rm" "-f" "5bb2df0350521dd6e86ee4d8fb9b54968ffe6463dbe292d3120930fd4394bf84"` [INFO] [stdout] 5bb2df0350521dd6e86ee4d8fb9b54968ffe6463dbe292d3120930fd4394bf84