[INFO] updating cached repository rhorrace/CS410P-Project [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rhorrace/CS410P-Project [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rhorrace/CS410P-Project" "work/ex/clippy-test-run/sources/stable/gh/rhorrace/CS410P-Project"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rhorrace/CS410P-Project'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rhorrace/CS410P-Project" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rhorrace/CS410P-Project"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rhorrace/CS410P-Project'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 17552aa2bb5954af6c103a56a922acefd7ef16be [INFO] sha for GitHub repo rhorrace/CS410P-Project: 17552aa2bb5954af6c103a56a922acefd7ef16be [INFO] validating manifest of rhorrace/CS410P-Project on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rhorrace/CS410P-Project on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rhorrace/CS410P-Project [INFO] finished frobbing rhorrace/CS410P-Project [INFO] frobbed toml for rhorrace/CS410P-Project written to work/ex/clippy-test-run/sources/stable/gh/rhorrace/CS410P-Project/Cargo.toml [INFO] started frobbing rhorrace/CS410P-Project [INFO] finished frobbing rhorrace/CS410P-Project [INFO] frobbed toml for rhorrace/CS410P-Project written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rhorrace/CS410P-Project/Cargo.toml [INFO] crate rhorrace/CS410P-Project has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rhorrace/CS410P-Project against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rhorrace/CS410P-Project:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9c341d43c85f2a18bc30c593038b4a226f79a106b6392a0941795effda666541 [INFO] running `"docker" "start" "-a" "9c341d43c85f2a18bc30c593038b4a226f79a106b6392a0941795effda666541"` [INFO] [stderr] Checking project v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/game/card.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | / fn ne(&self, other: &Self) -> bool { [INFO] [stderr] 23 | | self.name != other.name [INFO] [stderr] 24 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `game::card::Card` [INFO] [stderr] --> src/game/card.rs:30:3 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn new() -> Card { [INFO] [stderr] 31 | | Card { name: 0, [INFO] [stderr] 32 | | suit: 0, } [INFO] [stderr] 33 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::deck::Deck` [INFO] [stderr] --> src/game/deck.rs:24:3 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> Deck { [INFO] [stderr] 25 | | Deck { [INFO] [stderr] 26 | | cards: [Card::new(); 52], [INFO] [stderr] 27 | | head: 0, [INFO] [stderr] 28 | | tail: 0, [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | impl Default for game::deck::Deck { [INFO] [stderr] 23 | fn default() -> Self { [INFO] [stderr] 24 | Self::new() [INFO] [stderr] 25 | } [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::dealer::Dealer` [INFO] [stderr] --> src/game/dealer.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Dealer { [INFO] [stderr] 23 | | let mut new_deck = Deck::new(); [INFO] [stderr] 24 | | new_deck.build(); [INFO] [stderr] 25 | | Dealer{deck: new_deck} [INFO] [stderr] 26 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | impl Default for game::dealer::Dealer { [INFO] [stderr] 21 | fn default() -> Self { [INFO] [stderr] 22 | Self::new() [INFO] [stderr] 23 | } [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `hands`. [INFO] [stderr] --> src/game/dealer.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | for j in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 47 | for in &mut hands { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `flp`. [INFO] [stderr] --> src/game/dealer.rs:58:14 [INFO] [stderr] | [INFO] [stderr] 58 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 58 | for in &mut flp { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::table::Table` [INFO] [stderr] --> src/game/table.rs:21:3 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> Table { [INFO] [stderr] 22 | | Table {f_t_r: [Card::new(); 5]} [INFO] [stderr] 23 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | impl Default for game::table::Table { [INFO] [stderr] 20 | fn default() -> Self { [INFO] [stderr] 21 | Self::new() [INFO] [stderr] 22 | } [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `flp` [INFO] [stderr] --> src/game/table.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 32 | for (i, ) in flp.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/game/table.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..3 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `self.f_t_r[..3].clone_from_slice(&flp[..3])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::player::Player` [INFO] [stderr] --> src/game/player.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Player { [INFO] [stderr] 23 | | Player { hand: [Card::new(); 2], [INFO] [stderr] 24 | | combo: 0, } [INFO] [stderr] 25 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | impl Default for game::player::Player { [INFO] [stderr] 21 | fn default() -> Self { [INFO] [stderr] 22 | Self::new() [INFO] [stderr] 23 | } [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/game/player.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / match self.hand[0].value() == self.hand[1].value() { [INFO] [stderr] 58 | | true => self.combo = 1, [INFO] [stderr] 59 | | false => self.combo = 0, [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if self.hand[0].value() == self.hand[1].value() { self.combo = 1 } else { self.combo = 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::calc::Calc` [INFO] [stderr] --> src/game/calc.rs:25:3 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn new() -> Calc { [INFO] [stderr] 26 | | Calc{ plyr_hnd: [Card::new(); 7], [INFO] [stderr] 27 | | hand_sz: 0, [INFO] [stderr] 28 | | card_cnt: [0; 15], [INFO] [stderr] 29 | | suit_cnt: [0; 5] } [INFO] [stderr] 30 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | impl Default for game::calc::Calc { [INFO] [stderr] 24 | fn default() -> Self { [INFO] [stderr] 25 | Self::new() [INFO] [stderr] 26 | } [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/game/calc.rs:66:16 [INFO] [stderr] | [INFO] [stderr] 66 | for j in (1..i+1).rev() { [INFO] [stderr] | ^^^^^^^^ help: use: `(1..=i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/game/calc.rs:213:11 [INFO] [stderr] | [INFO] [stderr] 213 | / match self.royal_flush(suit) { // If has all plyr_hnd for RF [INFO] [stderr] 214 | | true => val = 9, // Royal Flush [INFO] [stderr] 215 | | false => val = 8, // Straight Flush [INFO] [stderr] 216 | | } [INFO] [stderr] | |___________^ help: consider using an if/else expression: `if self.royal_flush(suit) { val = 9 } else { val = 8 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/game/calc.rs:244:3 [INFO] [stderr] | [INFO] [stderr] 244 | / pub fn best_hand(self,hand_val: u64) -> [Card; 5] { [INFO] [stderr] 245 | | let mut hand = [Card::new(); 5]; [INFO] [stderr] 246 | | let mut i = 0; [INFO] [stderr] 247 | | match hand_val { [INFO] [stderr] ... | [INFO] [stderr] 431 | | hand // return hand [INFO] [stderr] 432 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::com::Com` [INFO] [stderr] --> src/game/com.rs:24:3 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> Com { [INFO] [stderr] 25 | | Com { hand: Player::new(), [INFO] [stderr] 26 | | calc: Calc::new(), } [INFO] [stderr] 27 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | impl Default for game::com::Com { [INFO] [stderr] 23 | fn default() -> Self { [INFO] [stderr] 24 | Self::new() [INFO] [stderr] 25 | } [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/game/card.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | / fn ne(&self, other: &Self) -> bool { [INFO] [stderr] 23 | | self.name != other.name [INFO] [stderr] 24 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `game::card::Card` [INFO] [stderr] --> src/game/card.rs:30:3 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn new() -> Card { [INFO] [stderr] 31 | | Card { name: 0, [INFO] [stderr] 32 | | suit: 0, } [INFO] [stderr] 33 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::Game` [INFO] [stderr] --> src/game/mod.rs:70:3 [INFO] [stderr] | [INFO] [stderr] 70 | / pub fn new() -> Game { [INFO] [stderr] 71 | | Game { player: Player::new(), [INFO] [stderr] 72 | | computer: Com::new(), [INFO] [stderr] 73 | | dealer: Dealer::new(), [INFO] [stderr] 74 | | table: Table::new(), [INFO] [stderr] 75 | | calc: Calc::new(), } [INFO] [stderr] 76 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 68 | impl Default for game::Game { [INFO] [stderr] 69 | fn default() -> Self { [INFO] [stderr] 70 | Self::new() [INFO] [stderr] 71 | } [INFO] [stderr] 72 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::deck::Deck` [INFO] [stderr] --> src/game/deck.rs:24:3 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> Deck { [INFO] [stderr] 25 | | Deck { [INFO] [stderr] 26 | | cards: [Card::new(); 52], [INFO] [stderr] 27 | | head: 0, [INFO] [stderr] 28 | | tail: 0, [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | impl Default for game::deck::Deck { [INFO] [stderr] 23 | fn default() -> Self { [INFO] [stderr] 24 | Self::new() [INFO] [stderr] 25 | } [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::dealer::Dealer` [INFO] [stderr] --> src/game/dealer.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Dealer { [INFO] [stderr] 23 | | let mut new_deck = Deck::new(); [INFO] [stderr] 24 | | new_deck.build(); [INFO] [stderr] 25 | | Dealer{deck: new_deck} [INFO] [stderr] 26 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | impl Default for game::dealer::Dealer { [INFO] [stderr] 21 | fn default() -> Self { [INFO] [stderr] 22 | Self::new() [INFO] [stderr] 23 | } [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `hands`. [INFO] [stderr] --> src/game/dealer.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | for j in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 47 | for in &mut hands { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `flp`. [INFO] [stderr] --> src/game/dealer.rs:58:14 [INFO] [stderr] | [INFO] [stderr] 58 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 58 | for in &mut flp { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::table::Table` [INFO] [stderr] --> src/game/table.rs:21:3 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> Table { [INFO] [stderr] 22 | | Table {f_t_r: [Card::new(); 5]} [INFO] [stderr] 23 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | impl Default for game::table::Table { [INFO] [stderr] 20 | fn default() -> Self { [INFO] [stderr] 21 | Self::new() [INFO] [stderr] 22 | } [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `flp` [INFO] [stderr] --> src/game/table.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 32 | for (i, ) in flp.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/game/table.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..3 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `self.f_t_r[..3].clone_from_slice(&flp[..3])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::player::Player` [INFO] [stderr] --> src/game/player.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Player { [INFO] [stderr] 23 | | Player { hand: [Card::new(); 2], [INFO] [stderr] 24 | | combo: 0, } [INFO] [stderr] 25 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | impl Default for game::player::Player { [INFO] [stderr] 21 | fn default() -> Self { [INFO] [stderr] 22 | Self::new() [INFO] [stderr] 23 | } [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/game/player.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / match self.hand[0].value() == self.hand[1].value() { [INFO] [stderr] 58 | | true => self.combo = 1, [INFO] [stderr] 59 | | false => self.combo = 0, [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if self.hand[0].value() == self.hand[1].value() { self.combo = 1 } else { self.combo = 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::calc::Calc` [INFO] [stderr] --> src/game/calc.rs:25:3 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn new() -> Calc { [INFO] [stderr] 26 | | Calc{ plyr_hnd: [Card::new(); 7], [INFO] [stderr] 27 | | hand_sz: 0, [INFO] [stderr] 28 | | card_cnt: [0; 15], [INFO] [stderr] 29 | | suit_cnt: [0; 5] } [INFO] [stderr] 30 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | impl Default for game::calc::Calc { [INFO] [stderr] 24 | fn default() -> Self { [INFO] [stderr] 25 | Self::new() [INFO] [stderr] 26 | } [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/game/calc.rs:66:16 [INFO] [stderr] | [INFO] [stderr] 66 | for j in (1..i+1).rev() { [INFO] [stderr] | ^^^^^^^^ help: use: `(1..=i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/game/calc.rs:213:11 [INFO] [stderr] | [INFO] [stderr] 213 | / match self.royal_flush(suit) { // If has all plyr_hnd for RF [INFO] [stderr] 214 | | true => val = 9, // Royal Flush [INFO] [stderr] 215 | | false => val = 8, // Straight Flush [INFO] [stderr] 216 | | } [INFO] [stderr] | |___________^ help: consider using an if/else expression: `if self.royal_flush(suit) { val = 9 } else { val = 8 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/game/calc.rs:244:3 [INFO] [stderr] | [INFO] [stderr] 244 | / pub fn best_hand(self,hand_val: u64) -> [Card; 5] { [INFO] [stderr] 245 | | let mut hand = [Card::new(); 5]; [INFO] [stderr] 246 | | let mut i = 0; [INFO] [stderr] 247 | | match hand_val { [INFO] [stderr] ... | [INFO] [stderr] 431 | | hand // return hand [INFO] [stderr] 432 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::com::Com` [INFO] [stderr] --> src/game/com.rs:24:3 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> Com { [INFO] [stderr] 25 | | Com { hand: Player::new(), [INFO] [stderr] 26 | | calc: Calc::new(), } [INFO] [stderr] 27 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | impl Default for game::com::Com { [INFO] [stderr] 23 | fn default() -> Self { [INFO] [stderr] 24 | Self::new() [INFO] [stderr] 25 | } [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::Game` [INFO] [stderr] --> src/game/mod.rs:70:3 [INFO] [stderr] | [INFO] [stderr] 70 | / pub fn new() -> Game { [INFO] [stderr] 71 | | Game { player: Player::new(), [INFO] [stderr] 72 | | computer: Com::new(), [INFO] [stderr] 73 | | dealer: Dealer::new(), [INFO] [stderr] 74 | | table: Table::new(), [INFO] [stderr] 75 | | calc: Calc::new(), } [INFO] [stderr] 76 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 68 | impl Default for game::Game { [INFO] [stderr] 69 | fn default() -> Self { [INFO] [stderr] 70 | Self::new() [INFO] [stderr] 71 | } [INFO] [stderr] 72 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.13s [INFO] running `"docker" "inspect" "9c341d43c85f2a18bc30c593038b4a226f79a106b6392a0941795effda666541"` [INFO] running `"docker" "rm" "-f" "9c341d43c85f2a18bc30c593038b4a226f79a106b6392a0941795effda666541"` [INFO] [stdout] 9c341d43c85f2a18bc30c593038b4a226f79a106b6392a0941795effda666541