[INFO] updating cached repository rhinodavid/digit_divisible [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rhinodavid/digit_divisible [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rhinodavid/digit_divisible" "work/ex/clippy-test-run/sources/stable/gh/rhinodavid/digit_divisible"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rhinodavid/digit_divisible'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rhinodavid/digit_divisible" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rhinodavid/digit_divisible"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rhinodavid/digit_divisible'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e2c33d18825abbb68da02ca7deb9ba9b418fc5bd [INFO] sha for GitHub repo rhinodavid/digit_divisible: e2c33d18825abbb68da02ca7deb9ba9b418fc5bd [INFO] validating manifest of rhinodavid/digit_divisible on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rhinodavid/digit_divisible on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rhinodavid/digit_divisible [INFO] finished frobbing rhinodavid/digit_divisible [INFO] frobbed toml for rhinodavid/digit_divisible written to work/ex/clippy-test-run/sources/stable/gh/rhinodavid/digit_divisible/Cargo.toml [INFO] started frobbing rhinodavid/digit_divisible [INFO] finished frobbing rhinodavid/digit_divisible [INFO] frobbed toml for rhinodavid/digit_divisible written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rhinodavid/digit_divisible/Cargo.toml [INFO] crate rhinodavid/digit_divisible has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rhinodavid/digit_divisible against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rhinodavid/digit_divisible:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5bc6d462e8199f46180569fd09b35935e419d2bcb307f114d3e9e1371c31f02d [INFO] running `"docker" "start" "-a" "5bc6d462e8199f46180569fd09b35935e419d2bcb307f114d3e9e1371c31f02d"` [INFO] [stderr] Checking digit_divisible v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | / match x != 0 { [INFO] [stderr] 3 | | true => Ok(make_digits(x).iter().all(|d| is_evenly_divisible(x, *d))), [INFO] [stderr] 4 | | false => Err("This doesn't work with zero!"), [INFO] [stderr] 5 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if x != 0 { Ok(make_digits(x).iter().all(|d| is_evenly_divisible(x, *d))) } else { Err("This doesn't work with zero!") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / match divisor != 0 { [INFO] [stderr] 10 | | true => quotient % divisor == 0, [INFO] [stderr] 11 | | false => false, [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if divisor != 0 { quotient % divisor == 0 } else { false }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | x = x / 10; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `x /= 10` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | / match x != 0 { [INFO] [stderr] 3 | | true => Ok(make_digits(x).iter().all(|d| is_evenly_divisible(x, *d))), [INFO] [stderr] 4 | | false => Err("This doesn't work with zero!"), [INFO] [stderr] 5 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if x != 0 { Ok(make_digits(x).iter().all(|d| is_evenly_divisible(x, *d))) } else { Err("This doesn't work with zero!") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / match divisor != 0 { [INFO] [stderr] 10 | | true => quotient % divisor == 0, [INFO] [stderr] 11 | | false => false, [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if divisor != 0 { quotient % divisor == 0 } else { false }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | x = x / 10; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `x /= 10` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / match result { [INFO] [stderr] 14 | | true => println!("{:?} is divisible by all its digits", num), [INFO] [stderr] 15 | | false => println!("{:?} is not divisible by all its digits", num), [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if result { println!("{:?} is divisible by all its digits", num) } else { println!("{:?} is not divisible by all its digits", num) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / match result { [INFO] [stderr] 14 | | true => println!("{:?} is divisible by all its digits", num), [INFO] [stderr] 15 | | false => println!("{:?} is not divisible by all its digits", num), [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if result { println!("{:?} is divisible by all its digits", num) } else { println!("{:?} is not divisible by all its digits", num) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.06s [INFO] running `"docker" "inspect" "5bc6d462e8199f46180569fd09b35935e419d2bcb307f114d3e9e1371c31f02d"` [INFO] running `"docker" "rm" "-f" "5bc6d462e8199f46180569fd09b35935e419d2bcb307f114d3e9e1371c31f02d"` [INFO] [stdout] 5bc6d462e8199f46180569fd09b35935e419d2bcb307f114d3e9e1371c31f02d