[INFO] updating cached repository rharriso/jot
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/rharriso/jot
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/rharriso/jot" "work/ex/clippy-test-run/sources/stable/gh/rharriso/jot"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rharriso/jot'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/rharriso/jot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rharriso/jot"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rharriso/jot'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 9cf871580aa7b66de9d365dec2ea13965ec44663
[INFO] sha for GitHub repo rharriso/jot: 9cf871580aa7b66de9d365dec2ea13965ec44663
[INFO] validating manifest of rharriso/jot on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rharriso/jot on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rharriso/jot
[INFO] finished frobbing rharriso/jot
[INFO] frobbed toml for rharriso/jot written to work/ex/clippy-test-run/sources/stable/gh/rharriso/jot/Cargo.toml
[INFO] started frobbing rharriso/jot
[INFO] finished frobbing rharriso/jot
[INFO] frobbed toml for rharriso/jot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rharriso/jot/Cargo.toml
[INFO] crate rharriso/jot has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rharriso/jot against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rharriso/jot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] cd7500070be729a1a1c71ed15d2748c1fe180843713447c266fe10edd3c5ecdb
[INFO] running `"docker" "start" "-a" "cd7500070be729a1a1c71ed15d2748c1fe180843713447c266fe10edd3c5ecdb"`
[INFO] [stderr]    Compiling libsqlite3-sys v0.8.0
[INFO] [stderr]     Checking term_size v0.3.0
[INFO] [stderr]     Checking atty v0.2.2
[INFO] [stderr]     Checking uuid v0.5.0
[INFO] [stderr]     Checking chrono v0.3.1
[INFO] [stderr]     Checking clap v2.24.1
[INFO] [stderr]     Checking rusqlite v0.11.0
[INFO] [stderr]     Checking jd v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/note.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 | /         return Note {
[INFO] [stderr] 17 | |             content: content.to_string(),
[INFO] [stderr] 18 | |             created_at: UTC::now().naive_utc(),
[INFO] [stderr] 19 | |             uuid: Uuid::new_v4().to_string()
[INFO] [stderr] 20 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 16 |         Note {
[INFO] [stderr] 17 |             content: content.to_string(),
[INFO] [stderr] 18 |             created_at: UTC::now().naive_utc(),
[INFO] [stderr] 19 |             uuid: Uuid::new_v4().to_string()
[INFO] [stderr] 20 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::path::Path`
[INFO] [stderr]  --> src/main.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 | use std::path::Path;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 |     return Connection::open(db_file).expect("unable to create db.");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Connection::open(db_file).expect("unable to create db.")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:51:5
[INFO] [stderr]    |
[INFO] [stderr] 51 |     return notes;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `notes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:19:23
[INFO] [stderr]    |
[INFO] [stderr] 19 |     let mut db_file = env::home_dir().expect("couln't get home dir");
[INFO] [stderr]    |                       ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:65:23
[INFO] [stderr]    |
[INFO] [stderr] 65 |     let mut jot_dir = env::home_dir().expect("couln't get home dir");
[INFO] [stderr]    |                       ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/note.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 | /         return Note {
[INFO] [stderr] 17 | |             content: content.to_string(),
[INFO] [stderr] 18 | |             created_at: UTC::now().naive_utc(),
[INFO] [stderr] 19 | |             uuid: Uuid::new_v4().to_string()
[INFO] [stderr] 20 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 16 |         Note {
[INFO] [stderr] 17 |             content: content.to_string(),
[INFO] [stderr] 18 |             created_at: UTC::now().naive_utc(),
[INFO] [stderr] 19 |             uuid: Uuid::new_v4().to_string()
[INFO] [stderr] 20 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::path::Path`
[INFO] [stderr]  --> src/main.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 | use std::path::Path;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 |     return Connection::open(db_file).expect("unable to create db.");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Connection::open(db_file).expect("unable to create db.")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:51:5
[INFO] [stderr]    |
[INFO] [stderr] 51 |     return notes;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `notes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:19:23
[INFO] [stderr]    |
[INFO] [stderr] 19 |     let mut db_file = env::home_dir().expect("couln't get home dir");
[INFO] [stderr]    |                       ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:65:23
[INFO] [stderr]    |
[INFO] [stderr] 65 |     let mut jot_dir = env::home_dir().expect("couln't get home dir");
[INFO] [stderr]    |                       ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `matches`
[INFO] [stderr]   --> src/main.rs:88:17
[INFO] [stderr]    |
[INFO] [stderr] 88 |     if let Some(matches) = matches.subcommand_matches("init") {
[INFO] [stderr]    |                 ^^^^^^^ help: consider using `_matches` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `matches`
[INFO] [stderr]   --> src/main.rs:93:24
[INFO] [stderr]    |
[INFO] [stderr] 93 |     } else if let Some(matches) = matches.subcommand_matches("list") {
[INFO] [stderr]    |                        ^^^^^^^ help: consider using `_matches` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/main.rs:69:5
[INFO] [stderr]    |
[INFO] [stderr] 69 |     fs::create_dir(jot_dir.clone());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `matches`
[INFO] [stderr]   --> src/main.rs:88:17
[INFO] [stderr]    |
[INFO] [stderr] 88 |     if let Some(matches) = matches.subcommand_matches("init") {
[INFO] [stderr]    |                 ^^^^^^^ help: consider using `_matches` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `matches`
[INFO] [stderr]   --> src/main.rs:93:24
[INFO] [stderr]    |
[INFO] [stderr] 93 |     } else if let Some(matches) = matches.subcommand_matches("list") {
[INFO] [stderr]    |                        ^^^^^^^ help: consider using `_matches` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/main.rs:69:5
[INFO] [stderr]    |
[INFO] [stderr] 69 |     fs::create_dir(jot_dir.clone());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 13.49s
[INFO] running `"docker" "inspect" "cd7500070be729a1a1c71ed15d2748c1fe180843713447c266fe10edd3c5ecdb"`
[INFO] running `"docker" "rm" "-f" "cd7500070be729a1a1c71ed15d2748c1fe180843713447c266fe10edd3c5ecdb"`
[INFO] [stdout] cd7500070be729a1a1c71ed15d2748c1fe180843713447c266fe10edd3c5ecdb