[INFO] updating cached repository rharel/rust-pixel-sorter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rharel/rust-pixel-sorter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rharel/rust-pixel-sorter" "work/ex/clippy-test-run/sources/stable/gh/rharel/rust-pixel-sorter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rharel/rust-pixel-sorter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rharel/rust-pixel-sorter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rharel/rust-pixel-sorter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rharel/rust-pixel-sorter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5d8cd3e82ff66f65093714abf3ae6cff811b7b75 [INFO] sha for GitHub repo rharel/rust-pixel-sorter: 5d8cd3e82ff66f65093714abf3ae6cff811b7b75 [INFO] validating manifest of rharel/rust-pixel-sorter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rharel/rust-pixel-sorter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rharel/rust-pixel-sorter [INFO] finished frobbing rharel/rust-pixel-sorter [INFO] frobbed toml for rharel/rust-pixel-sorter written to work/ex/clippy-test-run/sources/stable/gh/rharel/rust-pixel-sorter/Cargo.toml [INFO] started frobbing rharel/rust-pixel-sorter [INFO] finished frobbing rharel/rust-pixel-sorter [INFO] frobbed toml for rharel/rust-pixel-sorter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rharel/rust-pixel-sorter/Cargo.toml [INFO] crate rharel/rust-pixel-sorter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rharel/rust-pixel-sorter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rharel/rust-pixel-sorter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 46ad4ef52d0c09125b18aa5854fc205721984e20950e450084f97511229ff98c [INFO] running `"docker" "start" "-a" "46ad4ef52d0c09125b18aa5854fc205721984e20950e450084f97511229ff98c"` [INFO] [stderr] Checking either v1.4.0 [INFO] [stderr] Compiling rayon-core v1.3.0 [INFO] [stderr] Checking inflate v0.3.3 [INFO] [stderr] Checking num-bigint v0.1.40 [INFO] [stderr] Checking clap v2.27.1 [INFO] [stderr] Compiling palette v0.2.1 [INFO] [stderr] Checking coco v0.1.1 [INFO] [stderr] Checking num-rational v0.1.40 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.17.0 [INFO] [stderr] Checking pixelsort v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / return match image [INFO] [stderr] 27 | | { [INFO] [stderr] 28 | | DynamicImage::ImageRgb8(buffer) => buffer, [INFO] [stderr] 29 | | _ => image.to_rgb() [INFO] [stderr] 30 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | match image [INFO] [stderr] 27 | { [INFO] [stderr] 28 | DynamicImage::ImageRgb8(buffer) => buffer, [INFO] [stderr] 29 | _ => image.to_rgb() [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / return match image [INFO] [stderr] 27 | | { [INFO] [stderr] 28 | | DynamicImage::ImageRgb8(buffer) => buffer, [INFO] [stderr] 29 | | _ => image.to_rgb() [INFO] [stderr] 30 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | match image [INFO] [stderr] 27 | { [INFO] [stderr] 28 | DynamicImage::ImageRgb8(buffer) => buffer, [INFO] [stderr] 29 | _ => image.to_rgb() [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/color.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn color_space(&self) -> ColorSpace [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/color.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn index(&self) -> usize [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `source`. [INFO] [stderr] --> src/color.rs:105:18 [INFO] [stderr] | [INFO] [stderr] 105 | for i in 0..3 [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 105 | for in &source [INFO] [stderr] | ^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:134:26 [INFO] [stderr] | [INFO] [stderr] 134 | components: [red as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(red)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:135:26 [INFO] [stderr] | [INFO] [stderr] 135 | green as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:136:26 [INFO] [stderr] | [INFO] [stderr] 136 | blue as f32 / 255.0] [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/command_line_interface.rs:26:29 [INFO] [stderr] | [INFO] [stderr] 26 | for argument in vec!["affect_hsl", "affect_hsv", "affect_rgb"] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["affect_hsl", "affect_hsv", "affect_rgb"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | let ref mut file = File::create(file_path).unwrap_or_else(|_| [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 52 | let file = &mut File::create(file_path).unwrap_or_else(|_| [INFO] [stderr] 53 | { [INFO] [stderr] 54 | println!("ERROR: Failed to open output file."); [INFO] [stderr] 55 | exit(1); [INFO] [stderr] 56 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/color.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn color_space(&self) -> ColorSpace [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/color.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn index(&self) -> usize [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `source`. [INFO] [stderr] --> src/color.rs:105:18 [INFO] [stderr] | [INFO] [stderr] 105 | for i in 0..3 [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 105 | for in &source [INFO] [stderr] | ^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:134:26 [INFO] [stderr] | [INFO] [stderr] 134 | components: [red as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(red)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:135:26 [INFO] [stderr] | [INFO] [stderr] 135 | green as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:136:26 [INFO] [stderr] | [INFO] [stderr] 136 | blue as f32 / 255.0] [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/command_line_interface.rs:26:29 [INFO] [stderr] | [INFO] [stderr] 26 | for argument in vec!["affect_hsl", "affect_hsv", "affect_rgb"] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["affect_hsl", "affect_hsv", "affect_rgb"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | let ref mut file = File::create(file_path).unwrap_or_else(|_| [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 52 | let file = &mut File::create(file_path).unwrap_or_else(|_| [INFO] [stderr] 53 | { [INFO] [stderr] 54 | println!("ERROR: Failed to open output file."); [INFO] [stderr] 55 | exit(1); [INFO] [stderr] 56 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.22s [INFO] running `"docker" "inspect" "46ad4ef52d0c09125b18aa5854fc205721984e20950e450084f97511229ff98c"` [INFO] running `"docker" "rm" "-f" "46ad4ef52d0c09125b18aa5854fc205721984e20950e450084f97511229ff98c"` [INFO] [stdout] 46ad4ef52d0c09125b18aa5854fc205721984e20950e450084f97511229ff98c