[INFO] updating cached repository rglara/fill-a-pix-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rglara/fill-a-pix-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rglara/fill-a-pix-rust" "work/ex/clippy-test-run/sources/stable/gh/rglara/fill-a-pix-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rglara/fill-a-pix-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rglara/fill-a-pix-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rglara/fill-a-pix-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rglara/fill-a-pix-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0da0e4813337dfd7c79d4e0d8817a191febc8976 [INFO] sha for GitHub repo rglara/fill-a-pix-rust: 0da0e4813337dfd7c79d4e0d8817a191febc8976 [INFO] validating manifest of rglara/fill-a-pix-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rglara/fill-a-pix-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rglara/fill-a-pix-rust [INFO] finished frobbing rglara/fill-a-pix-rust [INFO] frobbed toml for rglara/fill-a-pix-rust written to work/ex/clippy-test-run/sources/stable/gh/rglara/fill-a-pix-rust/Cargo.toml [INFO] started frobbing rglara/fill-a-pix-rust [INFO] finished frobbing rglara/fill-a-pix-rust [INFO] frobbed toml for rglara/fill-a-pix-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rglara/fill-a-pix-rust/Cargo.toml [INFO] crate rglara/fill-a-pix-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rglara/fill-a-pix-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rglara/fill-a-pix-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e114a4fe1d150849de61e6efb8b82629e9788a1153dc8c27981998885ca4ea36 [INFO] running `"docker" "start" "-a" "e114a4fe1d150849de61e6efb8b82629e9788a1153dc8c27981998885ca4ea36"` [INFO] [stderr] Checking stb_truetype v0.2.4 [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Compiling wayland-scanner v0.12.5 [INFO] [stderr] Checking tempfile v3.0.4 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling syn v0.15.6 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Compiling glutin v0.14.0 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Compiling wayland-client v0.12.5 [INFO] [stderr] Compiling wayland-protocols v0.12.5 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Compiling serde_derive v1.0.79 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking piston-gfx_texture v0.32.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.51.0 [INFO] [stderr] Checking piston_window v0.80.0 [INFO] [stderr] Checking fill-a-pix-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/picgrid.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/picgrid.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/picgrid_controller.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | picgrid: picgrid, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `picgrid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/picgrid_view.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | settings: settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/picgrid.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/picgrid.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/picgrid_controller.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | picgrid: picgrid, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `picgrid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/picgrid_view.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | settings: settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/picgrid.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / let mut ret_val = Some(CellState::Unshaded(PictureGrid::EMPTY)); [INFO] [stderr] 61 | | if x >= 0 && x < self.width as isize && y >= 0 && y < self.height as isize { [INFO] [stderr] 62 | | ret_val = Some(self.cells[&(y * self.width as isize + x)].clone()); [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let ret_val = if x >= 0 && x < self.width as isize && y >= 0 && y < self.height as isize { Some(self.cells[&(y * self.width as isize + x)].clone()) } else { Some(CellState::Unshaded(PictureGrid::EMPTY)) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/picgrid.rs:62:28 [INFO] [stderr] | [INFO] [stderr] 62 | ret_val = Some(self.cells[&(y * self.width as isize + x)].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cells[&(y * self.width as isize + x)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/picgrid.rs:178:21 [INFO] [stderr] | [INFO] [stderr] 178 | / match cell { [INFO] [stderr] 179 | | CellState::Shaded(_hint) => num += 1, [INFO] [stderr] 180 | | _ => {} [INFO] [stderr] 181 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let CellState::Shaded(_hint) = cell { num += 1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/picgrid.rs:194:21 [INFO] [stderr] | [INFO] [stderr] 194 | / match cell { [INFO] [stderr] 195 | | CellState::Unshaded(_hint) => num += 1, [INFO] [stderr] 196 | | _ => {} [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let CellState::Unshaded(_hint) = cell { num += 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/picgrid.rs:210:21 [INFO] [stderr] | [INFO] [stderr] 210 | / match cell { [INFO] [stderr] 211 | | CellState::Unsolved(_hint) => num += 1, [INFO] [stderr] 212 | | _ => {} [INFO] [stderr] 213 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let CellState::Unsolved(_hint) = cell { num += 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/picgrid_controller.rs:112:16 [INFO] [stderr] | [INFO] [stderr] 112 | if let Some(_) = e.update_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 113 | | for _loop in 0..self.steps_per_update { [INFO] [stderr] 114 | | if self.is_solving { [INFO] [stderr] 115 | | if let Some(cell) = self.cell_pos { [INFO] [stderr] ... | [INFO] [stderr] 154 | | } [INFO] [stderr] 155 | | } [INFO] [stderr] | |_________- help: try this: `if e.update_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `picgrid_view::PictureGridViewSettings` [INFO] [stderr] --> src/picgrid_view.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / pub fn new() -> PictureGridViewSettings { [INFO] [stderr] 53 | | PictureGridViewSettings { [INFO] [stderr] 54 | | controls_position: [15.0; 2], [INFO] [stderr] 55 | | grid_position: [260.0, 15.0], [INFO] [stderr] ... | [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/picgrid_view.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | let ref settings = self.settings; [INFO] [stderr] | ----^^^^^^^^^^^^----------------- help: try: `let settings = &self.settings;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/picgrid_view.rs:108:26 [INFO] [stderr] | [INFO] [stderr] 108 | let hcell = ((vp.rect[2] as f64) - settings.margin[0] - settings.grid_position[0]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(vp.rect[2])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/picgrid_view.rs:109:19 [INFO] [stderr] | [INFO] [stderr] 109 | / (controller.picgrid.width as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(controller.picgrid.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/picgrid_view.rs:110:26 [INFO] [stderr] | [INFO] [stderr] 110 | let vcell = ((vp.rect[3] as f64) - (settings.margin[1] * 2.0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(vp.rect[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/picgrid_view.rs:111:19 [INFO] [stderr] | [INFO] [stderr] 111 | / (controller.picgrid.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(controller.picgrid.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/picgrid_view.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | (settings.grid_border_width / 2.0).into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(settings.grid_border_width / 2.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/picgrid_view.rs:132:21 [INFO] [stderr] | [INFO] [stderr] 132 | radius: (settings.cell_border_width / 2.0).into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(settings.cell_border_width / 2.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/picgrid_view.rs:147:33 [INFO] [stderr] | [INFO] [stderr] 147 | self.grid_rect[0] + f64::from(settings.grid_border_width / 2.0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `f64::from()`: `settings.grid_border_width / 2.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/picgrid_view.rs:148:33 [INFO] [stderr] | [INFO] [stderr] 148 | self.grid_rect[1] + f64::from(settings.grid_border_width / 2.0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `f64::from()`: `settings.grid_border_width / 2.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/picgrid_view.rs:239:32 [INFO] [stderr] | [INFO] [stderr] 239 | let mut label_offset = settings.label_size as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(settings.label_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/picgrid_view.rs:252:29 [INFO] [stderr] | [INFO] [stderr] 252 | label_offset += (settings.label_size as f64) * 1.5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(settings.label_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:32:24 [INFO] [stderr] | [INFO] [stderr] 32 | fn load_file(filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | let ref font = assets.join("FiraSans-Regular.ttf"); [INFO] [stderr] | ----^^^^^^^^--------------------------------------- help: try: `let font = &assets.join("FiraSans-Regular.ttf");` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/picgrid.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / let mut ret_val = Some(CellState::Unshaded(PictureGrid::EMPTY)); [INFO] [stderr] 61 | | if x >= 0 && x < self.width as isize && y >= 0 && y < self.height as isize { [INFO] [stderr] 62 | | ret_val = Some(self.cells[&(y * self.width as isize + x)].clone()); [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let ret_val = if x >= 0 && x < self.width as isize && y >= 0 && y < self.height as isize { Some(self.cells[&(y * self.width as isize + x)].clone()) } else { Some(CellState::Unshaded(PictureGrid::EMPTY)) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/picgrid.rs:62:28 [INFO] [stderr] | [INFO] [stderr] 62 | ret_val = Some(self.cells[&(y * self.width as isize + x)].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cells[&(y * self.width as isize + x)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/picgrid.rs:178:21 [INFO] [stderr] | [INFO] [stderr] 178 | / match cell { [INFO] [stderr] 179 | | CellState::Shaded(_hint) => num += 1, [INFO] [stderr] 180 | | _ => {} [INFO] [stderr] 181 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let CellState::Shaded(_hint) = cell { num += 1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/picgrid.rs:194:21 [INFO] [stderr] | [INFO] [stderr] 194 | / match cell { [INFO] [stderr] 195 | | CellState::Unshaded(_hint) => num += 1, [INFO] [stderr] 196 | | _ => {} [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let CellState::Unshaded(_hint) = cell { num += 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/picgrid.rs:210:21 [INFO] [stderr] | [INFO] [stderr] 210 | / match cell { [INFO] [stderr] 211 | | CellState::Unsolved(_hint) => num += 1, [INFO] [stderr] 212 | | _ => {} [INFO] [stderr] 213 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let CellState::Unsolved(_hint) = cell { num += 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/picgrid_controller.rs:112:16 [INFO] [stderr] | [INFO] [stderr] 112 | if let Some(_) = e.update_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 113 | | for _loop in 0..self.steps_per_update { [INFO] [stderr] 114 | | if self.is_solving { [INFO] [stderr] 115 | | if let Some(cell) = self.cell_pos { [INFO] [stderr] ... | [INFO] [stderr] 154 | | } [INFO] [stderr] 155 | | } [INFO] [stderr] | |_________- help: try this: `if e.update_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `picgrid_view::PictureGridViewSettings` [INFO] [stderr] --> src/picgrid_view.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / pub fn new() -> PictureGridViewSettings { [INFO] [stderr] 53 | | PictureGridViewSettings { [INFO] [stderr] 54 | | controls_position: [15.0; 2], [INFO] [stderr] 55 | | grid_position: [260.0, 15.0], [INFO] [stderr] ... | [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/picgrid_view.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | let ref settings = self.settings; [INFO] [stderr] | ----^^^^^^^^^^^^----------------- help: try: `let settings = &self.settings;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/picgrid_view.rs:108:26 [INFO] [stderr] | [INFO] [stderr] 108 | let hcell = ((vp.rect[2] as f64) - settings.margin[0] - settings.grid_position[0]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(vp.rect[2])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/picgrid_view.rs:109:19 [INFO] [stderr] | [INFO] [stderr] 109 | / (controller.picgrid.width as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(controller.picgrid.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/picgrid_view.rs:110:26 [INFO] [stderr] | [INFO] [stderr] 110 | let vcell = ((vp.rect[3] as f64) - (settings.margin[1] * 2.0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(vp.rect[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/picgrid_view.rs:111:19 [INFO] [stderr] | [INFO] [stderr] 111 | / (controller.picgrid.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(controller.picgrid.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/picgrid_view.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | (settings.grid_border_width / 2.0).into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(settings.grid_border_width / 2.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/picgrid_view.rs:132:21 [INFO] [stderr] | [INFO] [stderr] 132 | radius: (settings.cell_border_width / 2.0).into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(settings.cell_border_width / 2.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/picgrid_view.rs:147:33 [INFO] [stderr] | [INFO] [stderr] 147 | self.grid_rect[0] + f64::from(settings.grid_border_width / 2.0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `f64::from()`: `settings.grid_border_width / 2.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/picgrid_view.rs:148:33 [INFO] [stderr] | [INFO] [stderr] 148 | self.grid_rect[1] + f64::from(settings.grid_border_width / 2.0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `f64::from()`: `settings.grid_border_width / 2.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/picgrid_view.rs:239:32 [INFO] [stderr] | [INFO] [stderr] 239 | let mut label_offset = settings.label_size as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(settings.label_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/picgrid_view.rs:252:29 [INFO] [stderr] | [INFO] [stderr] 252 | label_offset += (settings.label_size as f64) * 1.5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(settings.label_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:32:24 [INFO] [stderr] | [INFO] [stderr] 32 | fn load_file(filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | let ref font = assets.join("FiraSans-Regular.ttf"); [INFO] [stderr] | ----^^^^^^^^--------------------------------------- help: try: `let font = &assets.join("FiraSans-Regular.ttf");` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 12s [INFO] running `"docker" "inspect" "e114a4fe1d150849de61e6efb8b82629e9788a1153dc8c27981998885ca4ea36"` [INFO] running `"docker" "rm" "-f" "e114a4fe1d150849de61e6efb8b82629e9788a1153dc8c27981998885ca4ea36"` [INFO] [stdout] e114a4fe1d150849de61e6efb8b82629e9788a1153dc8c27981998885ca4ea36