[INFO] updating cached repository reujab/platinum [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/reujab/platinum [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/reujab/platinum" "work/ex/clippy-test-run/sources/stable/gh/reujab/platinum"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/reujab/platinum'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/reujab/platinum" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/reujab/platinum"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/reujab/platinum'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f6c288e37dd11162b813e95f7376222e7930fa99 [INFO] sha for GitHub repo reujab/platinum: f6c288e37dd11162b813e95f7376222e7930fa99 [INFO] validating manifest of reujab/platinum on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of reujab/platinum on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing reujab/platinum [INFO] finished frobbing reujab/platinum [INFO] frobbed toml for reujab/platinum written to work/ex/clippy-test-run/sources/stable/gh/reujab/platinum/Cargo.toml [INFO] started frobbing reujab/platinum [INFO] finished frobbing reujab/platinum [INFO] frobbed toml for reujab/platinum written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/reujab/platinum/Cargo.toml [INFO] crate reujab/platinum has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting reujab/platinum against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/reujab/platinum:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cdae7b1a5ae6571ef3b0a5d59c6815e3bbd210fff84216216229c42846b5be2f [INFO] running `"docker" "start" "-a" "cdae7b1a5ae6571ef3b0a5d59c6815e3bbd210fff84216216229c42846b5be2f"` [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking filetime v0.1.15 [INFO] [stderr] Checking inotify v0.3.0 [INFO] [stderr] Checking xmltree v0.8.0 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking notify v4.0.3 [INFO] [stderr] Checking platinum v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/input.rs:25:31 [INFO] [stderr] | [INFO] [stderr] 25 | if buffer.starts_with(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/modules/cmd.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | / match line { [INFO] [stderr] 35 | | Ok(line) => { [INFO] [stderr] 36 | | segment.lock().unwrap().value = line; [INFO] [stderr] 37 | | tx.send(()).unwrap(); [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | Err(_) => {} [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | if let Ok(line) = line { [INFO] [stderr] 35 | segment.lock().unwrap().value = line; [INFO] [stderr] 36 | tx.send(()).unwrap(); [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/modules/cpu.rs:21:12 [INFO] [stderr] | [INFO] [stderr] 21 | if utilization == 100.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(utilization - 100.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/modules/cpu.rs:21:12 [INFO] [stderr] | [INFO] [stderr] 21 | if utilization == 100.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/modules/disk.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | .map(|line| line.split_whitespace().skip(1).next().unwrap().into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `platinum`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/input.rs:25:31 [INFO] [stderr] | [INFO] [stderr] 25 | if buffer.starts_with(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/modules/cmd.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | / match line { [INFO] [stderr] 35 | | Ok(line) => { [INFO] [stderr] 36 | | segment.lock().unwrap().value = line; [INFO] [stderr] 37 | | tx.send(()).unwrap(); [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | Err(_) => {} [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | if let Ok(line) = line { [INFO] [stderr] 35 | segment.lock().unwrap().value = line; [INFO] [stderr] 36 | tx.send(()).unwrap(); [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/modules/cpu.rs:21:12 [INFO] [stderr] | [INFO] [stderr] 21 | if utilization == 100.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(utilization - 100.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/modules/cpu.rs:21:12 [INFO] [stderr] | [INFO] [stderr] 21 | if utilization == 100.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/modules/disk.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | .map(|line| line.split_whitespace().skip(1).next().unwrap().into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `platinum`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "cdae7b1a5ae6571ef3b0a5d59c6815e3bbd210fff84216216229c42846b5be2f"` [INFO] running `"docker" "rm" "-f" "cdae7b1a5ae6571ef3b0a5d59c6815e3bbd210fff84216216229c42846b5be2f"` [INFO] [stdout] cdae7b1a5ae6571ef3b0a5d59c6815e3bbd210fff84216216229c42846b5be2f