[INFO] updating cached repository reujab/epub-optimizer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/reujab/epub-optimizer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/reujab/epub-optimizer" "work/ex/clippy-test-run/sources/stable/gh/reujab/epub-optimizer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/reujab/epub-optimizer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/reujab/epub-optimizer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/reujab/epub-optimizer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/reujab/epub-optimizer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] aaeae10e5c29cf1a78324425160cf4629e07af9e [INFO] sha for GitHub repo reujab/epub-optimizer: aaeae10e5c29cf1a78324425160cf4629e07af9e [INFO] validating manifest of reujab/epub-optimizer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of reujab/epub-optimizer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing reujab/epub-optimizer [INFO] finished frobbing reujab/epub-optimizer [INFO] frobbed toml for reujab/epub-optimizer written to work/ex/clippy-test-run/sources/stable/gh/reujab/epub-optimizer/Cargo.toml [INFO] started frobbing reujab/epub-optimizer [INFO] finished frobbing reujab/epub-optimizer [INFO] frobbed toml for reujab/epub-optimizer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/reujab/epub-optimizer/Cargo.toml [INFO] crate reujab/epub-optimizer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting reujab/epub-optimizer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/reujab/epub-optimizer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d54355d2077dca8b95d4d53a70abe9bf3c04e36e7d97d1a741ae325ad7f21c09 [INFO] running `"docker" "start" "-a" "d54355d2077dca8b95d4d53a70abe9bf3c04e36e7d97d1a741ae325ad7f21c09"` [INFO] [stderr] Compiling miniz_oxide_c_api v0.1.3 [INFO] [stderr] Compiling bzip2-sys v0.1.6 [INFO] [stderr] Checking miniz_oxide v0.1.3 [INFO] [stderr] Checking msdos_time v0.1.6 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking xmltree v0.8.0 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking zip v0.4.2 [INFO] [stderr] Checking epub-optimizer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:81:35 [INFO] [stderr] | [INFO] [stderr] 81 | if input.name().ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:158:28 [INFO] [stderr] | [INFO] [stderr] 158 | let val = &child.text.clone().unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `child.text.clone().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:174:12 [INFO] [stderr] | [INFO] [stderr] 174 | if metadata.cover_id.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!metadata.cover_id.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:188:16 [INFO] [stderr] | [INFO] [stderr] 188 | if input.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:203:16 [INFO] [stderr] | [INFO] [stderr] 203 | if metadata.subjects.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `metadata.subjects.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:81:35 [INFO] [stderr] | [INFO] [stderr] 81 | if input.name().ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:158:28 [INFO] [stderr] | [INFO] [stderr] 158 | let val = &child.text.clone().unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `child.text.clone().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:174:12 [INFO] [stderr] | [INFO] [stderr] 174 | if metadata.cover_id.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!metadata.cover_id.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:188:16 [INFO] [stderr] | [INFO] [stderr] 188 | if input.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:203:16 [INFO] [stderr] | [INFO] [stderr] 203 | if metadata.subjects.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `metadata.subjects.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.07s [INFO] running `"docker" "inspect" "d54355d2077dca8b95d4d53a70abe9bf3c04e36e7d97d1a741ae325ad7f21c09"` [INFO] running `"docker" "rm" "-f" "d54355d2077dca8b95d4d53a70abe9bf3c04e36e7d97d1a741ae325ad7f21c09"` [INFO] [stdout] d54355d2077dca8b95d4d53a70abe9bf3c04e36e7d97d1a741ae325ad7f21c09