[INFO] updating cached repository resin-io/resin-wifi-connect [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/resin-io/resin-wifi-connect [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/resin-io/resin-wifi-connect" "work/ex/clippy-test-run/sources/stable/gh/resin-io/resin-wifi-connect"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/resin-io/resin-wifi-connect'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/resin-io/resin-wifi-connect" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/resin-io/resin-wifi-connect"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/resin-io/resin-wifi-connect'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2d244b026113796441db7ecb6ca71a973069658f [INFO] sha for GitHub repo resin-io/resin-wifi-connect: 2d244b026113796441db7ecb6ca71a973069658f [INFO] validating manifest of resin-io/resin-wifi-connect on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of resin-io/resin-wifi-connect on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing resin-io/resin-wifi-connect [INFO] finished frobbing resin-io/resin-wifi-connect [INFO] frobbed toml for resin-io/resin-wifi-connect written to work/ex/clippy-test-run/sources/stable/gh/resin-io/resin-wifi-connect/Cargo.toml [INFO] started frobbing resin-io/resin-wifi-connect [INFO] finished frobbing resin-io/resin-wifi-connect [INFO] frobbed toml for resin-io/resin-wifi-connect written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/resin-io/resin-wifi-connect/Cargo.toml [INFO] crate resin-io/resin-wifi-connect has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting resin-io/resin-wifi-connect against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/resin-io/resin-wifi-connect:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a48684d6e31fed3b3259ca4949877ab069ee6bb67d9a3078dda2630148153877 [INFO] running `"docker" "start" "-a" "a48684d6e31fed3b3259ca4949877ab069ee6bb67d9a3078dda2630148153877"` [INFO] [stderr] Compiling httparse v1.3.1 [INFO] [stderr] Compiling nix v0.10.0 [INFO] [stderr] Checking sequence_trie v0.3.5 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Compiling libdbus-sys v0.1.3 [INFO] [stderr] Checking tokio-timer v0.1.2 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking thread_local v0.3.5 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking buf_redux v0.6.3 [INFO] [stderr] Checking serde_json v1.0.22 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking dbus v0.5.4 [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Checking multipart v0.13.6 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking network-manager v0.11.0 [INFO] [stderr] Checking iron v0.6.0 [INFO] [stderr] Checking persistent v0.4.0 [INFO] [stderr] Checking mount v0.4.0 [INFO] [stderr] Checking iron-cors v0.7.1 [INFO] [stderr] Checking router v0.6.0 [INFO] [stderr] Checking bodyparser v0.8.0 [INFO] [stderr] Checking staticfile v0.5.0 [INFO] [stderr] Checking urlencoded v0.6.0 [INFO] [stderr] Checking params v0.8.0 [INFO] [stderr] Checking wifi-connect v4.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | interface: interface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interface` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | ssid: ssid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ssid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | passphrase: passphrase, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `passphrase` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | gateway: gateway, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `gateway` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | dhcp_range: dhcp_range, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dhcp_range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | listening_port: listening_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `listening_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | activity_timeout: activity_timeout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `activity_timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | ui_directory: ui_directory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ui_directory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | gateway: gateway, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `gateway` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | server_rx: server_rx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `server_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | network_tx: network_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `network_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | exit_tx: exit_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `exit_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | ssid: ssid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ssid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | identity: identity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `identity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | passphrase: passphrase, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `passphrase` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | interface: interface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interface` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | ssid: ssid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ssid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | passphrase: passphrase, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `passphrase` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | gateway: gateway, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `gateway` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | dhcp_range: dhcp_range, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dhcp_range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | listening_port: listening_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `listening_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | activity_timeout: activity_timeout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `activity_timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | ui_directory: ui_directory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ui_directory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | gateway: gateway, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `gateway` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | server_rx: server_rx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `server_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | network_tx: network_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `network_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | exit_tx: exit_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `exit_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | ssid: ssid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ssid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | identity: identity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `identity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | passphrase: passphrase, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `passphrase` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/network.rs:432:14 [INFO] [stderr] | [INFO] [stderr] 432 | gateway: &Ipv4Addr, [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/network.rs:432:14 [INFO] [stderr] | [INFO] [stderr] 432 | gateway: &Ipv4Addr, [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.76s [INFO] running `"docker" "inspect" "a48684d6e31fed3b3259ca4949877ab069ee6bb67d9a3078dda2630148153877"` [INFO] running `"docker" "rm" "-f" "a48684d6e31fed3b3259ca4949877ab069ee6bb67d9a3078dda2630148153877"` [INFO] [stdout] a48684d6e31fed3b3259ca4949877ab069ee6bb67d9a3078dda2630148153877