[INFO] updating cached repository repitilesystem/repitile_core [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/repitilesystem/repitile_core [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/repitilesystem/repitile_core" "work/ex/clippy-test-run/sources/stable/gh/repitilesystem/repitile_core"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/repitilesystem/repitile_core'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/repitilesystem/repitile_core" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/repitilesystem/repitile_core"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/repitilesystem/repitile_core'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 19e8c4b9b0d0cec81262dd34a8df2f56c129e3ca [INFO] sha for GitHub repo repitilesystem/repitile_core: 19e8c4b9b0d0cec81262dd34a8df2f56c129e3ca [INFO] validating manifest of repitilesystem/repitile_core on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of repitilesystem/repitile_core on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing repitilesystem/repitile_core [INFO] finished frobbing repitilesystem/repitile_core [INFO] frobbed toml for repitilesystem/repitile_core written to work/ex/clippy-test-run/sources/stable/gh/repitilesystem/repitile_core/Cargo.toml [INFO] started frobbing repitilesystem/repitile_core [INFO] finished frobbing repitilesystem/repitile_core [INFO] frobbed toml for repitilesystem/repitile_core written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/repitilesystem/repitile_core/Cargo.toml [INFO] crate repitilesystem/repitile_core has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting repitilesystem/repitile_core against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/repitilesystem/repitile_core:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 51e0badf737e3f18f1623756e374d37861e62b286170a29a27b7953b0008ce37 [INFO] running `"docker" "start" "-a" "51e0badf737e3f18f1623756e374d37861e62b286170a29a27b7953b0008ce37"` [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Compiling nix v0.6.0 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking timer v0.2.0 [INFO] [stderr] Checking sysfs_gpio v0.5.1 [INFO] [stderr] Checking repitile_core v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin.rs:28:26 [INFO] [stderr] | [INFO] [stderr] 28 | self.is_active = if data == 1 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `data == 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin.rs:28:26 [INFO] [stderr] | [INFO] [stderr] 28 | self.is_active = if data == 1 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `data == 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.91s [INFO] running `"docker" "inspect" "51e0badf737e3f18f1623756e374d37861e62b286170a29a27b7953b0008ce37"` [INFO] running `"docker" "rm" "-f" "51e0badf737e3f18f1623756e374d37861e62b286170a29a27b7953b0008ce37"` [INFO] [stdout] 51e0badf737e3f18f1623756e374d37861e62b286170a29a27b7953b0008ce37