[INFO] updating cached repository renato-zannon/missing-constants
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/renato-zannon/missing-constants
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/renato-zannon/missing-constants" "work/ex/clippy-test-run/sources/stable/gh/renato-zannon/missing-constants"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/renato-zannon/missing-constants'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/renato-zannon/missing-constants" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/renato-zannon/missing-constants"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/renato-zannon/missing-constants'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 8d05e66d7d56610c01d0acfa4fe1e778160279aa
[INFO] sha for GitHub repo renato-zannon/missing-constants: 8d05e66d7d56610c01d0acfa4fe1e778160279aa
[INFO] validating manifest of renato-zannon/missing-constants on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of renato-zannon/missing-constants on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing renato-zannon/missing-constants
[INFO] finished frobbing renato-zannon/missing-constants
[INFO] frobbed toml for renato-zannon/missing-constants written to work/ex/clippy-test-run/sources/stable/gh/renato-zannon/missing-constants/Cargo.toml
[INFO] started frobbing renato-zannon/missing-constants
[INFO] finished frobbing renato-zannon/missing-constants
[INFO] frobbed toml for renato-zannon/missing-constants written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/renato-zannon/missing-constants/Cargo.toml
[INFO] crate renato-zannon/missing-constants has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting renato-zannon/missing-constants against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/renato-zannon/missing-constants:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] aecd03c1940f86da4d9940865f1525bff00c0ef04f8e966ffcfe457b42a60779
[INFO] running `"docker" "start" "-a" "aecd03c1940f86da4d9940865f1525bff00c0ef04f8e966ffcfe457b42a60779"`
[INFO] [stderr]     Checking pom v1.1.0
[INFO] [stderr]     Checking missing-constants v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     return parser.collect().convert(String::from_utf8);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parser.collect().convert(String::from_utf8)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     return parser.map(|(from_root, atoms)| ConstReference { from_root, atoms });
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parser.map(|(from_root, atoms)| ConstReference { from_root, atoms })`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     return sym(b' ').repeat(range).map(|v| v.len());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sym(b' ').repeat(range).map(|v| v.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:47:5
[INFO] [stderr]    |
[INFO] [stderr] 47 |     return (spaces + sym(b'\n')).discard();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(spaces + sym(b'\n')).discard()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 | /     return whole_module.map(|(mut module_decl, child_decls)| {
[INFO] [stderr] 54 | |         module_decl.child_decls = child_decls;
[INFO] [stderr] 55 | |         return module_decl;
[INFO] [stderr] 56 | |     });
[INFO] [stderr]    | |_______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 53 |     whole_module.map(|(mut module_decl, child_decls)| {
[INFO] [stderr] 54 |         module_decl.child_decls = child_decls;
[INFO] [stderr] 55 |         return module_decl;
[INFO] [stderr] 56 |     })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:55:9
[INFO] [stderr]    |
[INFO] [stderr] 55 |         return module_decl;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `module_decl`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:77:9
[INFO] [stderr]    |
[INFO] [stderr] 77 |         return call(move || module_body(min_ident));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `call(move || module_body(min_ident))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:89:5
[INFO] [stderr]    |
[INFO] [stderr] 89 |     return child_modules | module_body(indent_size).discard().map(|_| vec![]);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `child_modules | module_body(indent_size).discard().map(|_| vec![])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:86:9
[INFO] [stderr]    |
[INFO] [stderr] 86 |         return children;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `children`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:99:5
[INFO] [stderr]    |
[INFO] [stderr] 99 |     return start.map(move |const_atom| ModuleDecl { indent_size, const_atom, child_decls: vec![] });
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `start.map(move |const_atom| ModuleDecl { indent_size, const_atom, child_decls: vec![] })`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:106:5
[INFO] [stderr]     |
[INFO] [stderr] 106 |     return parser.discard();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parser.discard()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     return parser.collect().convert(String::from_utf8);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parser.collect().convert(String::from_utf8)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     return parser.map(|(from_root, atoms)| ConstReference { from_root, atoms });
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parser.map(|(from_root, atoms)| ConstReference { from_root, atoms })`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     return sym(b' ').repeat(range).map(|v| v.len());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sym(b' ').repeat(range).map(|v| v.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:47:5
[INFO] [stderr]    |
[INFO] [stderr] 47 |     return (spaces + sym(b'\n')).discard();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(spaces + sym(b'\n')).discard()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 | /     return whole_module.map(|(mut module_decl, child_decls)| {
[INFO] [stderr] 54 | |         module_decl.child_decls = child_decls;
[INFO] [stderr] 55 | |         return module_decl;
[INFO] [stderr] 56 | |     });
[INFO] [stderr]    | |_______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 53 |     whole_module.map(|(mut module_decl, child_decls)| {
[INFO] [stderr] 54 |         module_decl.child_decls = child_decls;
[INFO] [stderr] 55 |         return module_decl;
[INFO] [stderr] 56 |     })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:55:9
[INFO] [stderr]    |
[INFO] [stderr] 55 |         return module_decl;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `module_decl`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:77:9
[INFO] [stderr]    |
[INFO] [stderr] 77 |         return call(move || module_body(min_ident));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `call(move || module_body(min_ident))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:89:5
[INFO] [stderr]    |
[INFO] [stderr] 89 |     return child_modules | module_body(indent_size).discard().map(|_| vec![]);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `child_modules | module_body(indent_size).discard().map(|_| vec![])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:86:9
[INFO] [stderr]    |
[INFO] [stderr] 86 |         return children;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `children`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:99:5
[INFO] [stderr]    |
[INFO] [stderr] 99 |     return start.map(move |const_atom| ModuleDecl { indent_size, const_atom, child_decls: vec![] });
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `start.map(move |const_atom| ModuleDecl { indent_size, const_atom, child_decls: vec![] })`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:106:5
[INFO] [stderr]     |
[INFO] [stderr] 106 |     return parser.discard();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parser.discard()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `ConstReference`
[INFO] [stderr]   --> src/main.rs:19:1
[INFO] [stderr]    |
[INFO] [stderr] 19 | struct ConstReference {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `const_reference`
[INFO] [stderr]   --> src/main.rs:24:1
[INFO] [stderr]    |
[INFO] [stderr] 24 | fn const_reference() -> Parser<u8, ConstReference> {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `module_end`
[INFO] [stderr]    --> src/main.rs:102:1
[INFO] [stderr]     |
[INFO] [stderr] 102 | fn module_end(indent_size: usize) -> Parser<u8, ()> {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:10:36
[INFO] [stderr]    |
[INFO] [stderr] 10 |     const UPPER_RANGE: Range<u8> = b'A'..(b'Z' + 1);
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^ help: use: `b'A'..=b'Z'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `ConstReference`
[INFO] [stderr]   --> src/main.rs:19:1
[INFO] [stderr]    |
[INFO] [stderr] 19 | struct ConstReference {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `const_reference`
[INFO] [stderr]   --> src/main.rs:24:1
[INFO] [stderr]    |
[INFO] [stderr] 24 | fn const_reference() -> Parser<u8, ConstReference> {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `module_end`
[INFO] [stderr]    --> src/main.rs:102:1
[INFO] [stderr]     |
[INFO] [stderr] 102 | fn module_end(indent_size: usize) -> Parser<u8, ()> {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:10:36
[INFO] [stderr]    |
[INFO] [stderr] 10 |     const UPPER_RANGE: Range<u8> = b'A'..(b'Z' + 1);
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^ help: use: `b'A'..=b'Z'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.33s
[INFO] running `"docker" "inspect" "aecd03c1940f86da4d9940865f1525bff00c0ef04f8e966ffcfe457b42a60779"`
[INFO] running `"docker" "rm" "-f" "aecd03c1940f86da4d9940865f1525bff00c0ef04f8e966ffcfe457b42a60779"`
[INFO] [stdout] aecd03c1940f86da4d9940865f1525bff00c0ef04f8e966ffcfe457b42a60779