[INFO] updating cached repository remram44/dhstore [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/remram44/dhstore [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/remram44/dhstore" "work/ex/clippy-test-run/sources/stable/gh/remram44/dhstore"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/remram44/dhstore'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/remram44/dhstore" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/remram44/dhstore"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/remram44/dhstore'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3df999781da972ff457f0b85b0c269d8e7fdde8a [INFO] sha for GitHub repo remram44/dhstore: 3df999781da972ff457f0b85b0c269d8e7fdde8a [INFO] validating manifest of remram44/dhstore on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of remram44/dhstore on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing remram44/dhstore [INFO] finished frobbing remram44/dhstore [INFO] frobbed toml for remram44/dhstore written to work/ex/clippy-test-run/sources/stable/gh/remram44/dhstore/Cargo.toml [INFO] started frobbing remram44/dhstore [INFO] finished frobbing remram44/dhstore [INFO] frobbed toml for remram44/dhstore written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/remram44/dhstore/Cargo.toml [INFO] crate remram44/dhstore has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting remram44/dhstore against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/remram44/dhstore:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 928a9009245b269dabb7971f3b5528a2e478dfca099a7a2020cd5bee41ec9e48 [INFO] running `"docker" "start" "-a" "928a9009245b269dabb7971f3b5528a2e478dfca099a7a2020cd5bee41ec9e48"` [INFO] [stderr] Checking odds v0.2.25 [INFO] [stderr] Checking byte-tools v0.1.3 [INFO] [stderr] Checking bitflags v0.8.1 [INFO] [stderr] Checking cdchunking v0.2.0 [INFO] [stderr] Checking termcolor v0.3.3 [INFO] [stderr] Checking term_size v0.2.3 [INFO] [stderr] Checking clap v2.22.1 [INFO] [stderr] Checking nodrop v0.1.9 [INFO] [stderr] Checking generic-array v0.6.0 [INFO] [stderr] Checking digest v0.4.0 [INFO] [stderr] Checking digest-buffer v0.2.0 [INFO] [stderr] Checking sha2 v0.4.2 [INFO] [stderr] Checking dhstore v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/errors.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | write!(f, "I/O error: {}\n", msg)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_storage.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | first: first, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `first` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/errors.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | write!(f, "I/O error: {}\n", msg)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_storage.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | first: first, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `first` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hash.rs:42:23 [INFO] [stderr] | [INFO] [stderr] 42 | Some(ID { bytes: bytes }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hash.rs:157:14 [INFO] [stderr] | [INFO] [stderr] 157 | ID { bytes: bytes } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hash.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hash.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | hasher: hasher, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hasher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hash.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hash.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | hasher: hasher, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hasher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hash.rs:42:23 [INFO] [stderr] | [INFO] [stderr] 42 | Some(ID { bytes: bytes }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hash.rs:157:14 [INFO] [stderr] | [INFO] [stderr] 157 | ID { bytes: bytes } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hash.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hash.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | hasher: hasher, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hasher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hash.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hash.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | hasher: hasher, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hasher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory_index.rs:386:36 [INFO] [stderr] | [INFO] [stderr] 386 | let mut node = Permanode { sort: sort, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sort` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory_index.rs:387:36 [INFO] [stderr] | [INFO] [stderr] 387 | nodetype: nodetype, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `nodetype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:292:9 [INFO] [stderr] | [INFO] [stderr] 292 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:293:9 [INFO] [stderr] | [INFO] [stderr] 293 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:305:9 [INFO] [stderr] | [INFO] [stderr] 305 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | storage: storage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `storage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory_index.rs:386:36 [INFO] [stderr] | [INFO] [stderr] 386 | let mut node = Permanode { sort: sort, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sort` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory_index.rs:387:36 [INFO] [stderr] | [INFO] [stderr] 387 | nodetype: nodetype, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `nodetype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:292:9 [INFO] [stderr] | [INFO] [stderr] 292 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:293:9 [INFO] [stderr] | [INFO] [stderr] 293 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:305:9 [INFO] [stderr] | [INFO] [stderr] 305 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | storage: storage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `storage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/hash.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | const BASE64_CHARS: &'static [u8] = b"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-_"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/hash.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | const BASE64_BYTES: &'static [u8] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/serialize.rs:323:23 [INFO] [stderr] | [INFO] [stderr] 323 | const TEST_DICT: &'static [u8] = [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/serialize.rs:365:23 [INFO] [stderr] | [INFO] [stderr] 365 | const TEST_LIST: &'static [u8] = [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | / return Err(errors::Error::IoError("Can't find path to be added", [INFO] [stderr] 145 | | io::ErrorKind::NotFound.into())); [INFO] [stderr] | |_______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 144 | Err(errors::Error::IoError("Can't find path to be added", [INFO] [stderr] 145 | io::ErrorKind::NotFound.into())) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/hash.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | const BASE64_CHARS: &'static [u8] = b"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-_"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/hash.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | const BASE64_BYTES: &'static [u8] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | / return Err(errors::Error::IoError("Can't find path to be added", [INFO] [stderr] 145 | | io::ErrorKind::NotFound.into())); [INFO] [stderr] | |_______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 144 | Err(errors::Error::IoError("Can't find path to be added", [INFO] [stderr] 145 | io::ErrorKind::NotFound.into())) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `property` [INFO] [stderr] --> src/memory_index.rs:53:26 [INFO] [stderr] | [INFO] [stderr] 53 | fn handle(&mut self, property: &str, object: Object) [INFO] [stderr] | ^^^^^^^^ help: consider using `_property` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `object` [INFO] [stderr] --> src/memory_index.rs:53:42 [INFO] [stderr] | [INFO] [stderr] 53 | fn handle(&mut self, property: &str, object: Object) [INFO] [stderr] | ^^^^^^ help: consider using `_object` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `property` [INFO] [stderr] --> src/memory_index.rs:53:26 [INFO] [stderr] | [INFO] [stderr] 53 | fn handle(&mut self, property: &str, object: Object) [INFO] [stderr] | ^^^^^^^^ help: consider using `_property` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `object` [INFO] [stderr] --> src/memory_index.rs:53:42 [INFO] [stderr] | [INFO] [stderr] 53 | fn handle(&mut self, property: &str, object: Object) [INFO] [stderr] | ^^^^^^ help: consider using `_object` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Get` [INFO] [stderr] --> src/memory_index.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | Get, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Drop` [INFO] [stderr] --> src/memory_index.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | Drop, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `policy` [INFO] [stderr] --> src/memory_index.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | policy: Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/hash.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / pub fn from_str(hashstr: &[u8]) -> Option { [INFO] [stderr] 78 | | macro_rules! b64 { [INFO] [stderr] 79 | | ( $chr:expr ) => { [INFO] [stderr] 80 | | { [INFO] [stderr] ... | [INFO] [stderr] 113 | | Some(ID { bytes: out }) [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/hash.rs:117:1 [INFO] [stderr] | [INFO] [stderr] 117 | / impl hash::Hash for ID { [INFO] [stderr] 118 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 119 | | self.bytes.hash(state); [INFO] [stderr] 120 | | } [INFO] [stderr] 121 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/hash.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | #[derive(Clone, PartialEq, Eq, PartialOrd, Ord)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/memory_index.rs:296:40 [INFO] [stderr] | [INFO] [stderr] 296 | for (k, v) in list.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/memory_index.rs:334:13 [INFO] [stderr] | [INFO] [stderr] 334 | let ref id = permanode.id; [INFO] [stderr] | ----^^^^^^---------------- help: try: `let id = &permanode.id;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/memory_index.rs:393:29 [INFO] [stderr] | [INFO] [stderr] 393 | let claim = self.objects.get(claim_id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.objects[claim_id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/serialize.rs:143:24 [INFO] [stderr] | [INFO] [stderr] 143 | if last > &key { [INFO] [stderr] | ^^^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/serialize.rs:193:52 [INFO] [stderr] | [INFO] [stderr] 193 | let (n, o) = n.overflowing_add((d - b'0') as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(d - b'0')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Get` [INFO] [stderr] --> src/memory_index.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | Get, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Drop` [INFO] [stderr] --> src/memory_index.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | Drop, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `policy` [INFO] [stderr] --> src/memory_index.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | policy: Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `dhstore`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/hash.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / pub fn from_str(hashstr: &[u8]) -> Option { [INFO] [stderr] 78 | | macro_rules! b64 { [INFO] [stderr] 79 | | ( $chr:expr ) => { [INFO] [stderr] 80 | | { [INFO] [stderr] ... | [INFO] [stderr] 113 | | Some(ID { bytes: out }) [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/hash.rs:117:1 [INFO] [stderr] | [INFO] [stderr] 117 | / impl hash::Hash for ID { [INFO] [stderr] 118 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 119 | | self.bytes.hash(state); [INFO] [stderr] 120 | | } [INFO] [stderr] 121 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/hash.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | #[derive(Clone, PartialEq, Eq, PartialOrd, Ord)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/memory_index.rs:296:40 [INFO] [stderr] | [INFO] [stderr] 296 | for (k, v) in list.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/memory_index.rs:334:13 [INFO] [stderr] | [INFO] [stderr] 334 | let ref id = permanode.id; [INFO] [stderr] | ----^^^^^^---------------- help: try: `let id = &permanode.id;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/memory_index.rs:393:29 [INFO] [stderr] | [INFO] [stderr] 393 | let claim = self.objects.get(claim_id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.objects[claim_id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/serialize.rs:143:24 [INFO] [stderr] | [INFO] [stderr] 143 | if last > &key { [INFO] [stderr] | ^^^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/serialize.rs:193:52 [INFO] [stderr] | [INFO] [stderr] 193 | let (n, o) = n.overflowing_add((d - b'0') as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(d - b'0')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `dhstore`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "928a9009245b269dabb7971f3b5528a2e478dfca099a7a2020cd5bee41ec9e48"` [INFO] running `"docker" "rm" "-f" "928a9009245b269dabb7971f3b5528a2e478dfca099a7a2020cd5bee41ec9e48"` [INFO] [stdout] 928a9009245b269dabb7971f3b5528a2e478dfca099a7a2020cd5bee41ec9e48